[dualtor] use 'get_pdu_controller' to ensure same dut in test_power_off_reboot#11160
Merged
prgeor merged 1 commit intosonic-net:masterfrom Dec 30, 2023
Merged
Conversation
mihirpat1
approved these changes
Dec 29, 2023
prgeor
approved these changes
Dec 30, 2023
Contributor
Author
|
ADO # 26304800 |
Contributor
|
@StormLiangMS @yxieca - Can you please help with cherry-pick to 202305 and 202205? |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jan 5, 2024
Collaborator
|
Cherry-pick PR to 202205: #11200 |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jan 5, 2024
Collaborator
|
Cherry-pick PR to 202305: #11201 |
Contributor
|
@mihirpat1 @wenyiz2021 I added approval label for 202203 and 202305 to trigger auto cherry pick. |
mssonicbld
pushed a commit
that referenced
this pull request
Jan 5, 2024
mssonicbld
pushed a commit
that referenced
this pull request
Jan 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
#8646 made a change in fixture 'pdu_controller' to always choose supervisor if device is chassis, for non-chassis it'll choose a random dut. PR 8646 will work in the same way for single-dut, but for dualtor, the randomly chosen dut could be different dut than the one under testing.
This PR call 'get_pdu_controller' to ensure pdu_controller is getting on the same dut.
There is no generic fix for this scenario that use "enum_supervisor_dut_hostname" for both tests and fixture
pdu_controller, because platform_tests/conftest.py have a autouse fixture skip_on_simx that makes all platform tests use rand_one_dut_hostname.Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation