[lag_rate] Restore lag setting on VMs in case of failure in test#839
Merged
liat-grozovik merged 1 commit intosonic-net:masterfrom Mar 28, 2019
wangxin:lag-rate-pr
Merged
[lag_rate] Restore lag setting on VMs in case of failure in test#839liat-grozovik merged 1 commit intosonic-net:masterfrom wangxin:lag-rate-pr
liat-grozovik merged 1 commit intosonic-net:masterfrom
wangxin:lag-rate-pr
Conversation
The existing script does not restore lag rate setting on VMs in case of failure. This improvement is to restore lag setting on VMs if the testing failed. Signed-off-by: Xin Wang <xinw@mellanox.com>
mykolaf
approved these changes
Mar 28, 2019
liat-grozovik
approved these changes
Mar 28, 2019
yxieca
pushed a commit
that referenced
this pull request
Mar 28, 2019
The existing script does not restore lag rate setting on VMs in case of failure. This improvement is to restore lag setting on VMs if the testing failed. Signed-off-by: Xin Wang <xinw@mellanox.com>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
#### Why I did it
To pick up fixes from submodule sonic-sairedis which include the following fixes:
```
commit 1027eef3a331e84560827c7584ee8009baf434d5 (HEAD -> 202012, origin/202012)
Author: gechiang <62408185+gechiang@users.noreply.github.com>
Date: Wed Dec 8 03:13:34 2021 -0800
[202012] Prevent other notification event storms to keep enqueue unchecked and drained all memory that leads to crashing the switch router (sonic-net#976)
commit 94455e50d3444dcd60093b7a39c7f427337a94d2
Author: VenkatCisco <77468614+VenkatCisco@users.noreply.github.com>
Date: Tue Jun 15 03:23:20 2021 -0700
Add cisco-8000 checks to syncd_init_common (sonic-net#839)
commit 2df539483ed68519c3c9c6df958d3ed2f31dd629
Author: Kamil Cudnik <kcudnik@gmail.com>
Date: Mon Dec 6 20:50:23 2021 +0100
[lgtm] Add gmock libs to lgtm (sonic-net#979)
```
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Submodule src/sonic-swss f09ddb4..49c9c16: > Allow buffer profile apply after init (sonic-net#1099) > [aclorch]: Check for existing mirror table only when creating a new table (sonic-net#1089) > [201811] [portsorch] fix PortsOrch::allPortsReady() returns true when it should not (sonic-net#1116) > Address review comment: remove data member m_entriesCreated, which is introduced for dependancy resolution purpose. (sonic-net#839) > Fix PFC watchdog not getting lossless TC (sonic-net#876) Submodule src/sonic-utilities c049e54..2ca1ae1: > Add a generic configlet application script (sonic-net#716) Signed-off-by: Ying Xie <ying.xie@microsoft.com>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
sonic-net#842) e385212 [MPLS] Minor tweaks to VS for MPLS support for CRM polling of MPLS In-segments and NHs. c163238 Add cisco-8000 checks to syncd_init_common (sonic-net#839)
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
[fwutil]: Use overlay driver when mounting next image filesystem (sonic-net#825) Fix for adding L3 interface to Vlan group (sonic-net#826)Fix for adding L3 interface to Vlan group (sonic-net#826) [db_migrator]Do DB migration for buffer pool size change on Mellanox platform (sonic-net#833) explicitly specify command with underscores (sonic-net#846) [intfutil] set speed to 0 when interface speed is not available (sonic-net#839)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
The existing script does not restore lag rate setting on VMs in case
of failure. This improvement is to restore lag setting on VMs if the
testing failed.
Type of change
Approach
How did you do it?
Wrap the lag rate testing code in
block. Addalwayssection to restore VMs settings in case the settings are not restored in testing.How did you verify/test it?
Tested on Mellanox platform.
Any platform specific information?
No.
Supported testbed topology if it's a new test case?
Documentation