Skip to content

Add tests for interface naming mode#716

Merged
jleveque merged 8 commits intosonic-net:masterfrom
chitra-raghavan:port_alias_scripts
Mar 21, 2019
Merged

Add tests for interface naming mode#716
jleveque merged 8 commits intosonic-net:masterfrom
chitra-raghavan:port_alias_scripts

Conversation

@chitra-raghavan
Copy link
Contributor

@chitra-raghavan chitra-raghavan commented Oct 5, 2018

Description of PR

Summary:
Adding scripts for port alias feature

Type of change

  • [] Bug fix
  • [] Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

How did you do it?

Created new task under roles named port_alias.yml which in turn include files under port_alias/

How did you verify/test it?

Tested in T0/T1/PTF topologies

Any platform specific information?

Platform independent

Supported testbed topology if it's a new test case?

T0/T1/PTF

jleveque
jleveque suggested changes Oct 17, 2018
View reviewed changes
ansible/roles/test/tasks/port_alias/interface_config.yml Outdated
always:

- name: set the interface up
shell: sudo config interface startup {{intf}}
Copy link
Contributor

@jleveque jleveque Oct 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that the "config interface ..." syntax changed recently. The interface name should now be placed after "interface" and before the subcommand. Please update all "config interface ..." commands and confirm they work properly.

Copy link
Contributor Author

@chitra-raghavan chitra-raghavan Oct 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the config commands. but couldn't verify due to Issue sonic-net/SONiC#268

Copy link
Contributor

@jleveque jleveque Oct 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chitra-raghavan: Can you or @paavaanan please investigate the root cause of sonic-net/SONiC#268?

@chitra-raghavan
Copy link
Contributor Author

chitra-raghavan commented Jan 14, 2019

Script logs in z9100 for t0 and t1 topology
iface_naming_mode_z9100_t0_topo_log.log
iface_naming_mode_z9100_t1-topo_log.log

@jleveque jleveque changed the title Adding scripts for Port alias feature Add tests for interface naming mode Feb 28, 2019
@mfriyas
Copy link

mfriyas commented Mar 4, 2019

Added here the passed logs for this script with latest master build
port-alias-t0.log
port-alias-t1.log

@jleveque
Copy link
Contributor

jleveque commented Mar 4, 2019

Please fix conflicts.

jleveque
jleveque suggested changes Mar 5, 2019
View reviewed changes
jleveque
jleveque suggested changes Mar 6, 2019
View reviewed changes
@jleveque
Copy link
Contributor

jleveque commented Mar 7, 2019

@chitra-raghava: Do these test cover all the current SONiC CLI commands which utilize the interface naming mode feature? A good deal of time has passed since this PR was originally opened, so I just want to make sure we're testing everything that currently uses the feature. Can you please double-check and confirm?

jleveque
jleveque approved these changes Mar 21, 2019
View reviewed changes
Copy link
Contributor

@jleveque jleveque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving this PR, and will merge it shortly. Please review the current status of commands which utilize the interface naming mode and add tests for those which are currently not covered in a separate PR.

@jleveque jleveque merged commit d3a5228 into sonic-net:master Mar 21, 2019
yxieca pushed a commit that referenced this pull request Jul 16, 2019
@chitra-raghavan @yxieca
Add tests for interface naming mode (#716)
54af304
@chitra-raghavan chitra-raghavan deleted the port_alias_scripts branch February 22, 2021 08:41
wangxin pushed a commit to wangxin/sonic-mgmt that referenced this pull request Oct 27, 2025
@davidm-arista
Skipping PFCWD tests for lossy topos & add anchor section (sonic-net#716
0e1b31b 
)

This is adding a new section to the tests_mark_conditions.yaml file so
that common conditions can be defined once, and then re-used in the rest
of this file.

This section currently only defines lossyTopos, and this change uses
that throughout the tests_mark_conditions.yaml file.
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@yxieca
[201811][swss][utilities] advance submodule heads (sonic-net#3712)
8ada2a5 
Submodule src/sonic-swss f09ddb4..49c9c16:
  > Allow buffer profile apply after init (sonic-net#1099)
  > [aclorch]: Check for existing mirror table only when creating a new table (sonic-net#1089)
  > [201811] [portsorch] fix PortsOrch::allPortsReady() returns true when it should not (sonic-net#1116)
  > Address review comment: remove data member m_entriesCreated, which is introduced for dependancy resolution purpose. (sonic-net#839)
  > Fix PFC watchdog not getting lossless TC (sonic-net#876)

Submodule src/sonic-utilities c049e54..2ca1ae1:
  > Add a generic configlet application script (sonic-net#716)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jleveque jleveque jleveque approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Enhancement Included in 201811 branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@chitra-raghavan @mfriyas @jleveque @stcheng @yxieca