[fib_info] Avoid temp file on sonic-mgmt while templating fib_info.txt#846
Merged
qiluo-msft merged 1 commit intosonic-net:masterfrom Apr 23, 2019
wangxin:fib-info-pr
Merged
[fib_info] Avoid temp file on sonic-mgmt while templating fib_info.txt#846qiluo-msft merged 1 commit intosonic-net:masterfrom wangxin:fib-info-pr
qiluo-msft merged 1 commit intosonic-net:masterfrom
wangxin:fib-info-pr
Conversation
The decap and fib test cases use two steps to generate fib_info.txt file from template into PTF container for testing. The first step is to generate temp file to /tmp/fib_info.txt on sonic-mgmt container. There could be conflicts if two scripts use exactly the same location and same filename for temp file. This fix is to simplify the two steps templating into just one step and avoid using temp file. Signed-off-by: Xin Wang <xinw@mellanox.com>
stepanblyschak
approved these changes
Apr 23, 2019
qiluo-msft
approved these changes
Apr 23, 2019
auspham
pushed a commit
to auspham/sonic-mgmt
that referenced
this pull request
Feb 3, 2026
…ic-net#20846) (sonic-net#846) Cherry-pick sonic-net#20846 to 202503 branch. What is the motivation for this PR? The docker-sonic-mgmt will be upgraded to Ubuntu 24.04 based. The python packages will be upgraded together. Due to breaking changes in the packages, the devutils and snmp pdu controller need to be fixed to address the compability issues. How did you do it? Major changes in this PR: Updated snmp_pdu_controllers.py to use pysnmp 7.1.21 APIs. Moved the current snmp_pdu_controllers.py based on pysnmp 4.x API to snmp_pdu_controllers_legacy.py. Updated the pdu_manager.py to import correct snmp pdu controller based on pysnmp versions. Other changes: Improve the import in ssh_utils.py to make it compatible with old and new paramiko package. Add code to show traceback in task_runner.py to help troubleshooting. Improve the import in ansible_fixture.py to be compatible with old and new pytest_ansible. All the changes are compatible with old and new docker-sonic-mgmt. How did you verify/test it? Tested devutils using old and new docker-sonic-mgmt Tested pytest collect using old and new docker-sonic-mgmt
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
[fwutil]: Use overlay driver when mounting next image filesystem (sonic-net#825) Fix for adding L3 interface to Vlan group (sonic-net#826)Fix for adding L3 interface to Vlan group (sonic-net#826) [db_migrator]Do DB migration for buffer pool size change on Mellanox platform (sonic-net#833) explicitly specify command with underscores (sonic-net#846) [intfutil] set speed to 0 when interface speed is not available (sonic-net#839)
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
6cfb3ecb0248768da0a91e5f7fb4477c5da7eb4e (HEAD -> 201911, origin/201911) [build]: allow to use extra inc/lib location to build the package (sonic-net#595) 40d34872d3b7f354adac67f084eebf6ee467f779 Merge pull request sonic-net#846 from xumia/azp-201911 76ac50f147a7d820b19d8d7628a67f2fe4f5159b Disable the build test 6c9cf655b8b5b152cab1d578e05eddf8238b81b0 Fix branch reference error ca8d81d37a9b0294098f161b036d330d9ff461e0 [ci]: download artifacts from master branch (sonic-net#768) 0cbf4d55c67a9f8f52715f95536f3588acf06c4a [ci]: use sonicbld pool (sonic-net#766) b6f1265ee9bd86f8a5e909a6f1e9b2384497c906 [ci]: add build for arm64 and armhf (sonic-net#757) 9ec0a7da64d479b124815edc5b505fb88b2532a0 CI: add azure pipeline CI/CD (sonic-net#754) 1436dbe02cd3c56f796c6b3398d4075cd05d97e0 Fix RIF issue (sonic-net#835) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
The decap and fib test cases use two steps to generate fib_info.txt
file from template into PTF container for testing. The first step is to
generate temp file to /tmp/fib_info.txt on sonic-mgmt container. There
could be conflicts if two scripts use exactly the same location and same
filename for temp file.
This fix is to simplify the two steps templating into just one step and
avoid using temp file.
Type of change
Approach
How did you do it?
Simplify two steps templating into one step.
How did you verify/test it?
Tested on Mellanox platform.
Any platform specific information?
No.
Supported testbed topology if it's a new test case?
Documentation