Skip running tests if pretest failed#3712
Merged
wangxin merged 2 commits intosonic-net:masterfrom Jul 8, 2021
Merged
Conversation
When we use the run_tests.sh tool to run test, it may run some pretests to prepare DUT. In case pretests failed, its highly possible that the DUT is not in good status. There would be no point continue running rest of the tests that may take many hours to complete. This change enhanced the run_tests.sh script to skip running tests if pretest failed. Signed-off-by: Xin Wang <[email protected]>
neethajohn
reviewed
Jun 28, 2021
neethajohn
approved these changes
Jul 7, 2021
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
When we use the run_tests.sh tool to run test, it may run some pretests to prepare DUT. In case pretests failed, its highly possible that the DUT is not in good status. There would be no point continue running rest of the tests that may take many hours to complete. This change enhanced the run_tests.sh script to skip running tests if pretest failed. Signed-off-by: Xin Wang <[email protected]>
This was referenced Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
When we use the run_tests.sh tool to run test, it may run some pretests
to prepare DUT. In case pretests failed, its highly possible that the
DUT is not in good status. There would be no point continue running
rest of the tests that may take many hours to complete.
How did you do it?
This change enhanced the run_tests.sh script to skip running tests if
pretest failed.
How did you verify/test it?
Shutdown the portchannel of a neighbor VM. Use the run_tests.sh to run scripts. Do not bypass pretest.
The run_tests.sh script exit early as soon as prepare DUT failed.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation