Skip to content

Test case 1 of PFC watchdog against warm-reboot: happy path#825

Merged
wendani merged 8 commits intosonic-net:masterfrom
wendani:pfcwd_wb_master
Oct 4, 2019
Merged

Test case 1 of PFC watchdog against warm-reboot: happy path#825
wendani merged 8 commits intosonic-net:masterfrom
wendani:pfcwd_wb_master

Conversation

@wendani
Copy link
Contributor

@wendani wendani commented Mar 9, 2019 •
edited
Loading

Introduce warm-reboot test path to current PFC watchdog test harness.

sudo ansible-playbook test_sonic.yml -i str --limit str-dx010-acs-1 --vault-password-file ../ansible_passwd -e testcase_name=pfc_wd -e testbed_name=vms3-t0-dx010-1 -e warm_reboot_test=true -vvv

Add test case 1:
PFC storm detected and restored before warm-reboot
no on-going storm before warm-reboot emission
PFC storm detect and restore functional after warm-reboot

Infrastructure change:
Fine control PFC storm stop at fanout to allow per-queue per-port granularity

Tested on regular pfc watchdog without break.

Signed-off-by: Wenda Ni [email protected]

Description of PR

Summary:
Fixes # (issue)

Type of change

  • [] Bug fix
  • [] Testbed and Framework(new/improvement)
  • [] Test case(new/improvement)

Approach

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@wendani wendani changed the title First test case of PFC watchdog against warm-reboot Test case 1 of PFC watchdog against warm-reboot Mar 14, 2019
@wendani wendani changed the title Test case 1 of PFC watchdog against warm-reboot Test case 1 of PFC watchdog against warm-reboot: happy path Mar 22, 2019
@wendani wendani mentioned this pull request Mar 22, 2019
Merged
stepanblyschak
stepanblyschak requested changes Jul 2, 2019
View reviewed changes
@wendani wendani mentioned this pull request Sep 28, 2019
Merged
@stepanblyschak
Copy link
Contributor

stepanblyschak commented Oct 2, 2019

@wendani One additional small change requested.
Verified on Mellanox platform - passes. PR to change pfc storm start/stop for Mellanox fanout will come after internal review

@wendani wendani requested a review from stepanblyschak October 2, 2019 17:45
@wendani
Copy link
Contributor Author

wendani commented Oct 2, 2019 •
edited
Loading

Thx for prompt action. Let's move on to test case 2 once this one is set. #825 (comment)

@stepanblyschak stepanblyschak mentioned this pull request Oct 3, 2019
Closed
@wendani wendani merged commit 4bf0bdf into sonic-net:master Oct 4, 2019
yxieca pushed a commit that referenced this pull request Oct 7, 2019
@wendani @yxieca
Test case 1 of PFC watchdog against warm-reboot: happy path (#825)
1b9a128 
* First test case of PFC watchdog against warm-reboot

Signed-off-by: Wenda Ni <[email protected]>

* Add more comments for code readability

Signed-off-by: Wenda Ni <[email protected]>

* Use boolean variable to determine the test run type: regular pfc wd test
or pfcwd warm-reboot test

Signed-off-by: Wenda Ni <[email protected]>

* Feed reboot type to reboot_sonic.yml in warm-reboot happy path test

Signed-off-by: Wenda Ni <[email protected]>
deerao02 pushed a commit to deerao02/sonic-mgmt that referenced this pull request Dec 18, 2025
@mssonicbld
[action] [PR:20658] Adding a step to test_xcvr_info_in_db that verify…
4ec99ad 
… and test_check_sfp_eeprom.py that the pmon docker is running at least 6 minutes, and if not, it waits until it does- to make sure it contains all interfaces TRANSCEIVER_DOM_SENSOR and TRANSCEIVER_INFO (sonic-net#825)

<!--
Please make sure you've read and understood our contributing guidelines;
https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md

Please provide following information to help code review process a bit easier:
-->
### Description of PR
<!--
- Please include a summary of the change and which issue is fixed.
- Please also include relevant motivation and context. Where should reviewer start? background context?
- List any dependencies that are required for this change.
-->

Summary:
Adding a step to test_xcvr_info_in_db that verify and test_check_sfp_eeprom.py that the pmon docker is running at least 6 minutes, and if not, it waits until it does- to make sure it contains all interfaces TRANSCEIVER_DOM_SENSOR and TRANSCEIVER_INFO

### Type of change

<!--
- Fill x for your type of change.
- e.g.
- [x] Bug fix
-->

- [ ] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] New Test case
 - [ ] Skipped for non-supported platforms
- [x] Test case improvement

### Back port request
- [ ] 202205
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [ ] 202411
- [x] 202505

### Approach
#### What is the motivation for this PR?
Adding a step to test_xcvr_info_in_db that verify and test_check_sfp_eeprom.py that the pmon docker is running at least 6 minutes, and if not, it waits until it does- to make sure it contains all interfaces TRANSCEIVER_DOM_SENSOR and TRANSCEIVER_INFO.

#### How did you do it?
The test checks if pmon docker is running at least 6 minutes, and if not, it waits until it does
#### How did you verify/test it?
run it multiple times to make sure the pmon has the data after it has been up for 6 minutes

#### Any platform specific information?
no.
#### Supported testbed topology if it's a new test case?
no.
### Documentation
<!--
(If it's a new feature, new test case)
Did you update documentation/Wiki relevant to your implementation?
Link to the wiki page?
-->
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@stcheng
[submodules]: Backport ACL/MIRROR features to 201811 branch (sonic-ne…
b8bdeff 
…t#3112)

0ed90ba - [policerorch]: Fix return code comparison error (sonic-net#968) (1 minutes ago) <Shuotian Cheng)
80fcada -  remove crm acl_counters when acl_table removed (sonic-net#918) (3 hours ago) <JaredLius>
bd3651f - [aclorch]: Fix matching MIRROR_DSCP throws unnecessary errors (sonic-net#966) (2 minutes ago) <Shuotian Cheng>
0af226a - [aclorch]: Add MIRROR_DSCP table type (sonic-net#906) (4 weeks ago) <Shuotian Cheng>
9005962 - [vstest]: Update the mirror session state table name (sonic-net#917) (5 weeks ago) <Shuotian Cheng>
c4e3e54 - [policerorch]: Add PolicerOrch to bundle with mirror session (sonic-net#889) (6 weeks ago) <Shuotian Cheng>
ee49926 - [Makefile]: Remove header files from source files (sonic-net#883) (8 weeks ago) <Shuotian Cheng>
f889f80 - [aclorch]: Add ICMP type/code match for v4/v6 (sonic-net#868) (8 weeks ago) <Shuotian Cheng>
9931450 - [aclorch]: Add MIRRORv6 and MIRRORv4v6 support for ACL table (sonic-net#825) (9 weeks ago) <Shuotian Cheng>
a1ab18c - [mirrororch]: Fix comments typo (sonic-net#863) (9 weeks ago) <Shuotian Cheng>

sonic-swss-common
485db07 - [schema]: Add SWITCH_CAPABILITY_TABLE (sonic-net#276) (6 weeks ago) <Shuotian Cheng>        
3f49b20 - [schema]: Add POLICER configuration table (sonic-net#277) (6 weeks ago) <Shuotian Cheng>    
539b87d - [schema]: Add STATE_MIRROR_SESSION_TABLE_NAME (sonic-net#278) (6 weeks ago) <Shuotian Cheng>

sonic-utilities
dc52015 - [Sonic-utilities]: Added commands to view acl and port running configs (sonic-net#557) (6 days ago) <Prem Prakash>
635dc88 - [config]: Add config acl add/remove table command (sonic-net#541) (4 weeks ago) <Shuotian Cheng>
dcdc922 - [show]: Add show policer command (sonic-net#540) (4 weeks ago) <Shuotian Cheng>                                        
128462a - [config]: Add --policer option for mirror session (sonic-net#537) (6 weeks ago) <Shuotian Cheng>                       
38da7f3 - [acl_loader]: Add policer attribute in show mirror_session command (sonic-net#538) (6 weeks ago) <Shuotian Cheng>      
f95ff00 - [acl_loader]: Do not apply default DENY rule for MIRRORV6 table (sonic-net#522) (6 weeks ago) <Shuotian Cheng>

Signed-off-by: Shu0T1an ChenG <[email protected]>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@abdosi
[Submodule Update] sonic-utilities Following Changes:
1ba8944 
[fwutil]: Use overlay driver when mounting next image filesystem (sonic-net#825)
Fix for adding L3 interface to Vlan group (sonic-net#826)Fix for adding L3 interface to Vlan group (sonic-net#826)
[db_migrator]Do DB migration for buffer pool size change on Mellanox platform (sonic-net#833)
explicitly specify command with underscores (sonic-net#846)
[intfutil] set speed to 0 when interface speed is not available (sonic-net#839)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marian-pritsak marian-pritsak Awaiting requested review from marian-pritsak

@qiluo-msft qiluo-msft Awaiting requested review from qiluo-msft

@yxieca yxieca Awaiting requested review from yxieca

@lguohan lguohan Awaiting requested review from lguohan

@stepanblyschak stepanblyschak Awaiting requested review from stepanblyschak

1 more reviewer

@stcheng stcheng stcheng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Included in 201811 branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wendani @stepanblyschak @stcheng @yxieca