Skip to content

Enhance reboot_sonic.yml to be suitable for all types of reboot#755

Merged
pavel-shirshov merged 1 commit intosonic-net:masterfrom
romankachur-mlnx:reboot_sonic
Dec 11, 2018
Merged

Enhance reboot_sonic.yml to be suitable for all types of reboot#755
pavel-shirshov merged 1 commit intosonic-net:masterfrom
romankachur-mlnx:reboot_sonic

Conversation

@romankachur-mlnx
Copy link
Contributor

  1. Modified roles/test/tasks/common_tasks/reboot_sonic.yml

Description of PR

Summary:
The scenario reboot_sonic.yml which is used for reboot of sonic,
was modified to support other types of reboot: fast-reboot and warm-reboot.
It is possible to extend it to support any other type of reboot.

Type of change

  • [] Bug fix
  • [] Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

How did you do it?

  1. I defined possible (and allowed) types of reboots:
    reboot_types: ["reboot", "fast-reboot", "warm-reboot" ]
  2. The desired reboot type may be passed as reboot_type external parameter:
    ansible-playbook reboot.yml -e reboot_type=< reboot | fast-reboot | warm-reboot >
  3. Default reboot type is set to regular reboot, so reboot_type parameter is not mandatory, and the scenario may be used as before.
  4. Sonic is rebooted with a unified step:
    command: "{{ reboot_type }}"
  5. The reboot_type parameter is cheched against allowed values,
    - fail:
    ....
    when: reboot_type not in reboot_types

    So that it would not be possible to pass malicious commands to the sonic.

How did you verify/test it?

I tested it with regular reboot and, fast-reboot, and with default value:

  1. ansible-playbook ..... -e testcase_name=continuous_reboot ... -e reboot_type=fast-reboot
  2. ansible-playbook ..... -e testcase_name=continuous_reboot ... -e reboot_type=reboot
  3. ansible-playbook ..... -e testcase_name=continuous_reboot ...

Any platform specific information?

N/A

Supported testbed topology if it's a new test case?

N/A

Documentation

N/A

@pavel-shirshov pavel-shirshov merged commit 4b20c44 into sonic-net:master Dec 11, 2018
@romankachur-mlnx romankachur-mlnx deleted the reboot_sonic branch December 12, 2018 08:19
wangxin pushed a commit to wangxin/sonic-mgmt that referenced this pull request Oct 27, 2025
…te converge time in scale test (sonic-net#755)

<!--
Please make sure you've read and understood our contributing guidelines;
https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md

Please provide following information to help code review process a bit easier:
-->
### Description of PR
<!--
- Please include a summary of the change and which issue is fixed.
- Please also include relevant motivation and context. Where should reviewer start? background context?
- List any dependencies that are required for this change.
-->

Summary:
Fixes # (issue)
To get the route converge time of one port flap, we can leverage sairedis log and syslog to calculate that.
To get collect results of all test cases, we can save all results into a single dictionary and print at last.
### Type of change

<!--
- Fill x for your type of change.
- e.g.
- [x] Bug fix
-->

- [ ] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] New Test case
 - [ ] Skipped for non-supported platforms
- [ ] Test case improvement

### Back port request
- [ ] 202205
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [ ] 202411
- [x] 202505

### Approach
#### What is the motivation for this PR?
To get the route converge time of one port flap.
To get collect results of all test cases.
#### How did you do it?
Leverage sairedis log and syslog to calculate that.
Save all results into single dictionary and print it at last.
#### How did you verify/test it?
Run on testbed
#### Any platform specific information?

#### Supported testbed topology if it's a new test case?

### Documentation
<!--
(If it's a new feature, new test case)
Did you update documentation/Wiki relevant to your implementation?
Link to the wiki page?
-->
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
[ci]: download artifacts from master branch (sonic-net#768)
Do not create fabric port if mapping is not available (sonic-net#769)
[syncd] Comparison logic log also current attr value on set operation (sonic-net#763)
Add fabric port test to vslib (sonic-net#737)
[ci]: use sonicbld pool (sonic-net#766)
[tests] Remove exit command blocking all tests to run (sonic-net#765)
[vslib]: adapt macsec sai 1.7.1 (sonic-net#755)
Add support for SAI_SWITCH_ATTR_AVAILABLE_IPMC_ENTRY needed by CRM (sonic-net#756)

Signed-off-by: Danny Allen <[email protected]>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…nch (sonic-net#2526)

* [submodule 201811] advance sairedis and swss submodule for 201811 branch

Submodule src/sonic-sairedis 60f97c3..bdb0074:
  > Add more information on failed map sizes (sonic-net#416)
  > Add WRED specific comparison logic (sonic-net#413)
  > Initialize notification queue pointer before switch create (sonic-net#411)
  > Add log info for not matching SG/IPG/QUEUES (sonic-net#409)
  > Add support for any number of ports in virtual switch using lane map (sonic-net#407)

Submodule src/sonic-swss 85f6322..65a0256:
  > Increase the watermark polling interval to 10s (sonic-net#777)
  > [vstest]: fix test_port_an_warm.py test (sonic-net#779)
  > [wartermarkorch] Fix repeated m_pg_ids and m_unicast_queue_ids add up issue (sonic-net#752)
  > [teammgrd] Fix inconsistent port admin status (sonic-net#755)
  > Remove AclTableGroup upon removal of port/lag/vlan (sonic-net#751)


Signed-off-by: Ying Xie <[email protected]>

* [submodule] advance sonic-swss submodule

Submodule src/sonic-swss 65a0256..bf21ee3:
  > On a routing vlan, the neighbor entry in the /31 subnet is not added … (sonic-net#784)
  > portsorch ports init done flag should means buffer, autoneg, speed, m… (sonic-net#747) (sonic-net#783)

Signed-off-by: Ying Xie <[email protected]>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…#3827)

Submodule src/sonic-utilities 4f87e4d..e548793:
  > Fix a bug in idempotent check. (sonic-net#755)

Signed-off-by: Ying Xie <[email protected]>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…D automatically (#25593)

#### Why I did it
src/sonic-platform-daemons
```
* aa50994 - (HEAD -> 202511, origin/202511) PSUD: Handle Redis BUSY errors gracefully (sonic-net#761) (2 hours ago) [mssonicbld]
* dfe00a2 - Read SFP temperature from TRANSCEIVER_DOM_TEMPERATURE table (sonic-net#760) (6 hours ago) [Vasundhara Volam]
* fe5ec7d - Set initial state before config manager task is up (sonic-net#752) (sonic-net#755) (5 days ago) [Gagan Punathil Ellath]
* 0a250b6 - psud: Handle all exceptions in try_get() to prevent crashes (sonic-net#754) (5 days ago) [mssonicbld]
* e23750e - [xcvrd] Separate VDM basic and statistic observables (sonic-net#753) (6 days ago) [mssonicbld]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants