[decap] Extend the existing decap test to cover TTL testing#761
Merged
pavel-shirshov merged 3 commits intosonic-net:masterfrom Jan 15, 2019
wangxin:decap-ttl
Merged
[decap] Extend the existing decap test to cover TTL testing#761pavel-shirshov merged 3 commits intosonic-net:masterfrom wangxin:decap-ttl
pavel-shirshov merged 3 commits intosonic-net:masterfrom
wangxin:decap-ttl
Conversation
Signed-off-by: Xin Wang <[email protected]>
|
|
* Use a new way to limit IP ranges to be covered. Previously random sampling is used. The new method limits the number of podsets and subnets to be covered in the fib.j2 template. * Use a new way to set DSCP and TTL values. Previously DSCP and TTL values are randomly generated. The new method picks DSCP and TTL values from allowed range in a round-robin way. * Remove trailing spaces * Improve comments Signed-off-by: Xin Wang <[email protected]>
prsunny
reviewed
Jan 3, 2019
Contributor
prsunny
left a comment
prsunny
left a comment
There was a problem hiding this comment.
Overall, the changes looks good to me
When TTL mode is uniform and outer_ttl is 1, the decapsulated packet would have TTL=0 and would not be forwarded. Add logic to test outer_ttl=2 when TTL mode is uniform. Signed-off-by: Xin Wang <[email protected]>
prsunny
approved these changes
Jan 4, 2019
pavel-shirshov
approved these changes
Jan 15, 2019
auspham
pushed a commit
to auspham/sonic-mgmt
that referenced
this pull request
Feb 3, 2026
…#19463) (sonic-net#761) What is the motivation for this PR? Fix generic_config_updater/test_monitor_config.py::test_monitor_config_tc1_suite failure on 202412 due to policer not supported for MIRROR_SESSION creation on TH5 platform as Broadcom clarified it in CS00012412189: [TH5-512]Error log "Platform does not support SAI_MIRROR_SESSION_ATTR_POLICER". How did you do it? Check the platform before building and verifying monitor session config, remove the policer if platform startwith "x86_64-arista_7060x6_64pe". How did you verify/test it? Run generic_config_updater/test_monitor_config.py::test_monitor_config_tc1_suite locally on 7060x6 and it passed. generic_config_updater/test_monitor_config.py::test_monitor_config_tc1_suite PASSED [100%]
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
To incldue following changes: - [ci]: add build for arm64 and armhf (sonic-net#757) - Use template hgetall, because we will tune the return types of library functions (sonic-net#759) - [syncd] Fix bulk multi attrs for same key db update (sonic-net#761) Signed-off-by: Ying Xie <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…omatically (sonic-net#14743) #### Why I did it src/sonic-swss-common ``` * c942d74 - (HEAD -> 202012, origin/202012) [Ci][202012] Fix collect log error in azp template (sonic-net#800) (6 weeks ago) [xumia] * 14fa3e5 - Cherry-pick PRs in master branch to unblock PR checks. (sonic-net#761) (5 months ago) [Liu Shilong] ```
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Submodule src/sonic-utilities ae274e5..8237848: > [fast/warm reboot] ignore errors after shutting down critical service(s) (sonic-net#761) > [neighbor advertiser] raise exception when http endpoint return failure (sonic-net#758) Signed-off-by: Ying Xie <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…D automatically (#25593) #### Why I did it src/sonic-platform-daemons ``` * aa50994 - (HEAD -> 202511, origin/202511) PSUD: Handle Redis BUSY errors gracefully (sonic-net#761) (2 hours ago) [mssonicbld] * dfe00a2 - Read SFP temperature from TRANSCEIVER_DOM_TEMPERATURE table (sonic-net#760) (6 hours ago) [Vasundhara Volam] * fe5ec7d - Set initial state before config manager task is up (sonic-net#752) (sonic-net#755) (5 days ago) [Gagan Punathil Ellath] * 0a250b6 - psud: Handle all exceptions in try_get() to prevent crashes (sonic-net#754) (5 days ago) [mssonicbld] * e23750e - [xcvrd] Separate VDM basic and statistic observables (sonic-net#753) (6 days ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xin Wang [email protected]
Description of PR
Summary: Extend the existing decap test to cover TTL testing
Fixes # (issue)
Type of change
Approach
How did you do it?
How did you verify/test it?
Tested and verified on Mellanox switch using different topologies.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation
https://github.com/Azure/SONiC/wiki/IPv4-Decapsulation-test
The wiki page is not updated for this change because I am not authorized yet. I will update the wiki after I got required permission.