Fix Asymmetric PFC testcase skip for vlan-less topologies#737
Merged
lguohan merged 1 commit intosonic-net:masterfrom Nov 30, 2018
Merged
Fix Asymmetric PFC testcase skip for vlan-less topologies#737lguohan merged 1 commit intosonic-net:masterfrom
lguohan merged 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Andriy Moroz <c_andriym@mellanox.com>
andriymoroz-mlnx
changed the title
oleksandrivantsiv
approved these changes
Nov 20, 2018
volodymyrsamotiy
approved these changes
Nov 21, 2018
wangxin
pushed a commit
to wangxin/sonic-mgmt
that referenced
this pull request
Oct 27, 2025
…e to github issue 19658 (sonic-net#737) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Add xfail for `test_lldp_neighbor_post_orchagent_reboot` due to github issue [19658](sonic-net#19658) Fixes # (issue) ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [x] 202505 ### Approach #### What is the motivation for this PR? #### How did you do it? #### How did you verify/test it? #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
[ci]: download artifacts from master branch (sonic-net#768) Do not create fabric port if mapping is not available (sonic-net#769) [syncd] Comparison logic log also current attr value on set operation (sonic-net#763) Add fabric port test to vslib (sonic-net#737) [ci]: use sonicbld pool (sonic-net#766) [tests] Remove exit command blocking all tests to run (sonic-net#765) [vslib]: adapt macsec sai 1.7.1 (sonic-net#755) Add support for SAI_SWITCH_ATTR_AVAILABLE_IPMC_ENTRY needed by CRM (sonic-net#756) Signed-off-by: Danny Allen <daall@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andriy Moroz c_andriym@mellanox.com
Description of PR
Improved skipping of Asymmetric PFC test cases if not requested
Type of change
How did you do it?
No matter of "when:" condition Ansible analyses value specified in "with_items"
On topology without VLAN defined it caused an error.
Declared empty list for with_items when it is not needed
How did you verify/test it?
PFC_WD test on t1 topology does not fail
Any platform specific information?
No
Supported testbed topology if it's a new test case?
Documentation