Merged
Conversation
1. The current ACL loader will insert a default DROP rule that whatever doesn't match any rules will fall into this slot and get dropped. Thus the current DROP rules inserted during the test cannot be used to inspect if a rule is successfully inserted or not. Thus I modified the rule file to make it test if a packet is forwarded and received. 2. A test #0 is added to make sure that if a packet doesn't fall into any slots it will be dropped by default. 3. Remove the current EtherType match rule since whatever ethertypes that are not IP or IPv6 would be dropped. A TODO task is to add rules that matches IPv4/IPv6 separately and determine if the field works or not. Signed-off-by: Shuotian Cheng <stcheng_89@hotmail.com>
andriymoroz-mlnx
approved these changes
Dec 14, 2018
Contributor
Author
|
thanks @andriymoroz-mlnx ! |
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
To include following changes: - [teammgrd]: Add retry logic for starting port channel with teamd (sonic-net#756) - [portsorch] fix bug in initializePort (sonic-net#753) - [intfmgrd] Fix intfmgrd hanging untill first interface becomes ready (sonic-net#748) - [intfmgrd]: Support loopback (sonic-net#742) -Improve comments for neighbor warmrestart related functions and warmRestartAssist class (sonic-net#740) Signed-off-by: Ying Xie <ying.xie@microsoft.com>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…D automatically (#25593) #### Why I did it src/sonic-platform-daemons ``` * aa50994 - (HEAD -> 202511, origin/202511) PSUD: Handle Redis BUSY errors gracefully (sonic-net#761) (2 hours ago) [mssonicbld] * dfe00a2 - Read SFP temperature from TRANSCEIVER_DOM_TEMPERATURE table (sonic-net#760) (6 hours ago) [Vasundhara Volam] * fe5ec7d - Set initial state before config manager task is up (sonic-net#752) (sonic-net#755) (5 days ago) [Gagan Punathil Ellath] * 0a250b6 - psud: Handle all exceptions in try_get() to prevent crashes (sonic-net#754) (5 days ago) [mssonicbld] * e23750e - [xcvrd] Separate VDM basic and statistic observables (sonic-net#753) (6 days ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current ACL loader will insert a default DROP rule that
whatever doesn't match any rules will fall into this slot and
get dropped. Thus the current DROP rules inserted during the
test cannot be used to inspect if a rule is successfully
inserted or not. Thus I modified the rule file to make it test
if a packet is forwarded and received.
A test #0 is added to make sure that if a packet doesn't fall into
any slots it will be dropped by default.
Remove the current EtherType match rule since whatever ethertypes
that are not IP or IPv6 would be dropped. A TODO task is to add
rules that matches IPv4/IPv6 separately and determine if the field
works or not.
Signed-off-by: Shuotian Cheng stcheng_89@hotmail.com