[gcu] Refactor generic_config_updater/test_vlan_interface.py#6496
Merged
Blueve merged 2 commits intosonic-net:masterfrom Oct 10, 2022
Merged
[gcu] Refactor generic_config_updater/test_vlan_interface.py#6496Blueve merged 2 commits intosonic-net:masterfrom
Blueve merged 2 commits intosonic-net:masterfrom
Conversation
Blueve
requested changes
Oct 10, 2022
tests/common/plugins/conditional_mark/tests_mark_conditions.yaml
Outdated
Show resolved
Hide resolved
yaqiangz
changed the title
yaqiangz
changed the title
Blueve
approved these changes
Oct 10, 2022
wangxin
pushed a commit
that referenced
this pull request
Oct 11, 2022
What is the motivation for this PR? Fix this case failed in M0 topo caused by hard codes about vlan ip. How did you do it? Get vlan ip based on current topo config. How did you verify/test it? Run test.
Azarack
pushed a commit
to Azarack/sonic-mgmt
that referenced
this pull request
Oct 17, 2022
…et#6496) What is the motivation for this PR? Fix this case failed in M0 topo caused by hard codes about vlan ip. How did you do it? Get vlan ip based on current topo config. How did you verify/test it? Run test.
allen-xf
pushed a commit
to allen-xf/sonic-mgmt
that referenced
this pull request
Oct 28, 2022
…et#6496) What is the motivation for this PR? Fix this case failed in M0 topo caused by hard codes about vlan ip. How did you do it? Get vlan ip based on current topo config. How did you verify/test it? Run test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix this case failed in M0 topo caused by hard codes about vlan ip.
How did you do it?
Get vlan ip based on current topo config.
How did you verify/test it?
Run test.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation