Wait until VLAN and CPU port up#752
Merged
qiluo-msft merged 1 commit intosonic-net:masterfrom Dec 8, 2018
Merged
Conversation
Signed-off-by: Qi Luo <qiluo-msft@users.noreply.github.com>
qiluo-msft
requested review from
lguohan,
pavel-shirshov,
stepanblyschak and
yxieca
Collaborator
|
what if the dut doesn't have vlan port? like T1 topology. |
Contributor
fast/warm reboot test is intended to run on T0 topologies |
Collaborator
|
I don't have object to the claim that we might only have needs to use warm/fast reboot features on T0 switches. However, these features are generic enough that they could also be used on T1 switches. We could discuss if we want to test this feature on T1 switches. Personally I think we should. Because there is no mechanism to prevent switch admin from invoke warm/fast reboot on T1 switch, then we should test it. This discussion doesn't have to block this PR. IMO. |
pavel-shirshov
approved these changes
Dec 8, 2018
wangxin
pushed a commit
to wangxin/sonic-mgmt
that referenced
this pull request
Oct 27, 2025
…opo (sonic-net#752) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Update tests for V6 only topo. - _custom_acl_, _null_route_ - do validation only for ipv6 - _stress_acl_ - the test is ipv4 only, added skip in conditions mark ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [x] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 ### Approach #### What is the motivation for this PR? Tests running on new topologies #### How did you do it? Updated existing tests #### How did you verify/test it? Tests verified on t0-isolated-v6-d32u32s2 ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…nch (sonic-net#2526) * [submodule 201811] advance sairedis and swss submodule for 201811 branch Submodule src/sonic-sairedis 60f97c3..bdb0074: > Add more information on failed map sizes (sonic-net#416) > Add WRED specific comparison logic (sonic-net#413) > Initialize notification queue pointer before switch create (sonic-net#411) > Add log info for not matching SG/IPG/QUEUES (sonic-net#409) > Add support for any number of ports in virtual switch using lane map (sonic-net#407) Submodule src/sonic-swss 85f6322..65a0256: > Increase the watermark polling interval to 10s (sonic-net#777) > [vstest]: fix test_port_an_warm.py test (sonic-net#779) > [wartermarkorch] Fix repeated m_pg_ids and m_unicast_queue_ids add up issue (sonic-net#752) > [teammgrd] Fix inconsistent port admin status (sonic-net#755) > Remove AclTableGroup upon removal of port/lag/vlan (sonic-net#751) Signed-off-by: Ying Xie <ying.xie@microsoft.com> * [submodule] advance sonic-swss submodule Submodule src/sonic-swss 65a0256..bf21ee3: > On a routing vlan, the neighbor entry in the /31 subnet is not added … (sonic-net#784) > portsorch ports init done flag should means buffer, autoneg, speed, m… (sonic-net#747) (sonic-net#783) Signed-off-by: Ying Xie <ying.xie@microsoft.com>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…D automatically (#25593) #### Why I did it src/sonic-platform-daemons ``` * aa50994 - (HEAD -> 202511, origin/202511) PSUD: Handle Redis BUSY errors gracefully (sonic-net#761) (2 hours ago) [mssonicbld] * dfe00a2 - Read SFP temperature from TRANSCEIVER_DOM_TEMPERATURE table (sonic-net#760) (6 hours ago) [Vasundhara Volam] * fe5ec7d - Set initial state before config manager task is up (sonic-net#752) (sonic-net#755) (5 days ago) [Gagan Punathil Ellath] * 0a250b6 - psud: Handle all exceptions in try_get() to prevent crashes (sonic-net#754) (5 days ago) [mssonicbld] * e23750e - [xcvrd] Separate VDM basic and statistic observables (sonic-net#753) (6 days ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add one step in fast/warm-reboot test: wait until VLAN and CPU port up