Skip to content

[ACL] Add acl stress test#6903

Merged
xwjiang-ms merged 1 commit intosonic-net:masterfrom
xwjiang-ms:add_acl_stress_test
Nov 29, 2022
Merged

[ACL] Add acl stress test#6903
xwjiang-ms merged 1 commit intosonic-net:masterfrom
xwjiang-ms:add_acl_stress_test

Conversation

@xwjiang-ms
Copy link
Contributor

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205

Approach

What is the motivation for this PR?

Dynamic acl will add/delete acl entries frequently, need a testcase to test stress acl.
Issue link: #6801

How did you do it?

Send a template sh file to dut, run 1000 times add/delete acl, and check dut status

How did you verify/test it?

Run testcase

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

What is the motivation for this PR?
Dynamic acl will add/delete acl entries frequently, need a testcase to test stress acl.
Issue link: sonic-net#6801

How did you do it?
Send a template sh file to dut, run 1000 times add/delete acl, and check dut
status

How did you verify/test it?
Run testcase

Any platform specific information?
Supported testbed topology if it's a new test case?
@xwjiang-ms xwjiang-ms requested a review from wsycqyz November 28, 2022 08:01
@xwjiang-ms xwjiang-ms merged commit 9747b04 into sonic-net:master Nov 29, 2022
@xwjiang-ms xwjiang-ms deleted the add_acl_stress_test branch November 29, 2022 04:47
@bingwang-ms
Copy link
Collaborator

A few comments on this test case

  1. The IO test is missing, so we have no idea if the ACL is still working after stress test.
  2. The ACL table creation can be failed on dualtor platform because of insufficient resources
  3. The test case only add/delete a same rule, which is not the real scenario in production. We may add 100 different rules, and delete some of them, and then readd some rules (inseration)
    Please consider improving the test script.

wangxin pushed a commit that referenced this pull request Dec 7, 2022
What is the motivation for this PR?
Dynamic acl will add/delete acl entries frequently, need a testcase to test stress acl.
Issue link: #6801

How did you do it?
Send a template sh file to dut, run 1000 times add/delete acl, and check dut
status

How did you verify/test it?
Run testcase

Any platform specific information?
Supported testbed topology if it's a new test case?
@Blueve
Copy link
Collaborator

Blueve commented Dec 29, 2022

@xwjiang-ms add one more comment, we cannot assume all topo have 4 port channel. I think the intention here is to add/del acl on up links, can we use conn_graph to find up links (or port channels)?

wangxin pushed a commit that referenced this pull request Jan 30, 2023
What is the motivation for this PR?
Dynamic acl will add/delete acl entries frequently, need a testcase to test stress acl.
Issue link: #6801

How did you do it?
Send a template sh file to dut, run 1000 times add/delete acl, and check dut
status

How did you verify/test it?
Run testcase

Any platform specific information?
Supported testbed topology if it's a new test case?
bingwang-ms pushed a commit to bingwang-ms/sonic-mgmt that referenced this pull request Jul 27, 2023
…ic-mgmt into internal-202205

Fix merge conflicts.
- [pre-commit] Fix style issues in test scripts under `tests/acl` folder (sonic-net#6679)
- Moving check for reboot cause after interface status check (sonic-net#6721)
- Adding watchdog timeout values for Cisco 8808 Supervisor and Different LCs (sonic-net#6776)
- add Ether check in macsec_dp_poll (sonic-net#6828)
- Disable PFC watchdog in test_cpu_memory_usage_counterpoll (sonic-net#6851)
- Testcase to verify that lossless traffic is not dropped during congesion. (sonic-net#6853)
- Ignore Broadcom sai sai unbind ERR log for now (sonic-net#6539)
- [chassis][multi-asic] update the loganalyser regex for multi asic (sonic-net#6885)
- [mx] Fix test_acl failed on mx topo (sonic-net#6971) (sonic-net#6983)
- [202205][mx] Add support for mx in test_null_route_helper (sonic-net#6967) (sonic-net#6982)
- [m0][everflow] Add m0 support for everflow and refactor everflow setup_info (sonic-net#6900)
- [ACL] Add acl stress test (sonic-net#6903)
- Enhance test_tor_ecn (sonic-net#6906)
- Fix erros - Added unique IPV6 address for the missed ACL rules PR sonic-net#6390 (sonic-net#6909)
- enabled bfd tests (sonic-net#6919)
- Skip bgp speaker test on backend topo (sonic-net#6922)
- [advanced-reboot] Handle logs in tmpfs: backup two log files before reboot (sonic-net#6923)
- Fix missing definition (sonic-net#6930)
- [Mellanox] Add minimal table definition for SN2201 (sonic-net#6943)
- Update qos test param for dualtor topology (sonic-net#6948)
- fix setup for single asic lc (sonic-net#6951)
- Fix QoS sai test for running with python3 (sonic-net#6961)
- Don't fail if logrotate cron job file isn't present (sonic-net#6964)
- Disable post sanity check for vxlan test (sonic-net#6980)
- Merge branch 'azure-202205' into dev/yaqiangzhu/202205_merge
wangxin pushed a commit that referenced this pull request Jan 13, 2024
The goal of test_stress_acl.py is to add/delete acl entries frequently. Refer: #6903
test_stress_acl.py is adding new acl table and it will fail if the TCAM space is not available. As done in other acl tests, removing DATAACL to free TCAM resources to run test_stress_acl.py.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants