Moving check for reboot cause after interface status check

[vperumal]

Description of PR

Currently if there is an issue in reboot cause, it immediately aborts the test case and moves on to the next script. Because interface/transceivers check is not done and the timeout for it not exercised, it can cause other scripts to prematurely error out stating that the interfaces are not up.

Type of change

• [] Bug fix
• Testbed and Framework(new/improvement)
• Test case(new/improvement)

Back port request

• 201911
• 202012
• 202205

Approach

What is the motivation for this PR?

Make sure that interfaces are up before moving on to the next testcase/script.

How did you do it?

Moved reboot cause check after interface/transceivers status check

How did you verify/test it?

Verified it on T2 profile.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

[vperumal]

FYI @abdosi @gechiang

[azure-pipelines]

The pre-commit check detected issues in the files touched by this pull request.
The detected issues may be old or new. For new issues, please try to fix them.

For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame
author of this pull request. But if you can take extra effort to fix the old issues as well, that would be great!

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/platform_tests/test_reboot.py:11:1: F401 're' imported but unused
tests/platform_tests/test_reboot.py:14:1: F401 'datetime.datetime' imported but unused
tests/platform_tests/test_reboot.py:18:1: F401 'tests.common.fixtures.conn_graph_facts.conn_graph_facts' imported but unused
tests/platform_tests/test_reboot.py:20:1: F403 'from tests.common.reboot import *' used; unable to detect undefined names
tests/platform_tests/test_reboot.py:37:65: F811 redefinition of unused 'conn_graph_facts' from line 18
tests/platform_tests/test_reboot.py:47:78: F405 'REBOOT_TYPE_COLD' may be undefined, or defined from star imports: tests.common.reboot
tests/platform_tests/test_reboot.py:47:121: E501 line too long (135 > 120 characters)
tests/platform_tests/test_reboot.py:60:5: F405 'sync_reboot_history_queue_with_dut' may be undefined, or defined from star imports: tests.common.reboot
tests/platform_tests/test_reboot.py:63:5: F405 'reboot' may be undefined, or defined from star imports: tests.common.reboot
tests/platform_tests/test_reboot.py:67:5: F405 'REBOOT_TYPE_HISTOYR_QUEUE' may be undefined, or defined from star imports: tests.common.reboot
tests/platform_tests/test_reboot.py:72:79: E251 unexpected spaces around keyword / parameter equals
...
[truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
   the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
   docker container.
2. Ensure that the pre-commit package is installed:

sudo pip install pre-commit

3. Go to repository root folder
4. Install the pre-commit hooks:

pre-commit install

5. Use pre-commit to check staged file:

pre-commit

6. Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

[shyam77git]

LGTM