Remove DATAACL to free TCAM resources for test_stress_acl.py#11250
Remove DATAACL to free TCAM resources for test_stress_acl.py#11250wangxin merged 1 commit intosonic-net:masterfrom
Conversation
|
The pre-commit check detected issues in the files touched by this pull request. Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
e356cc9 to
cd4e1bc
Compare
tests/acl/test_stress_acl.py
Outdated
There was a problem hiding this comment.
- Config reload takes time. Is there a faster way to recover DATAACL after testing?
- If config reload is the only way to recover configuration, please use config source from running_golden_config:
config_reload(duthost, config_source="running_golden_config"
The reason is that there are some pretests updated a few configurations and saved the running config to "running_golden_config". We have a common fixture always compare the running config with the running golden config to detect any configuration not recovered by the current script to avoid affecting subsequent test scripts. If there are any configuration differences, the common fixture will do a reload.
So, if a test does not restore the configuration to running config, the common fixture has to do a config reload again. This will unnecessarily increase test time.
There was a problem hiding this comment.
Thanks for your comments, i have removed config reload and used other method to reconfigure the acl.
cd4e1bc to
c20ca15
Compare
|
The pre-commit check detected issues in the files touched by this pull request. Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
c20ca15 to
2e7ce61
Compare
What is the motivation for this PR? MX failed to fetch acl port due to DATAACL table in running config is removed by this PR: #11250 How did you do it? Fetch acl port from mg_facts How did you verify/test it? Run test
What is the motivation for this PR? MX failed to fetch acl port due to DATAACL table in running config is removed by this PR: sonic-net#11250 How did you do it? Fetch acl port from mg_facts How did you verify/test it? Run test
What is the motivation for this PR? MX failed to fetch acl port due to DATAACL table in running config is removed by this PR: #11250 How did you do it? Fetch acl port from mg_facts How did you verify/test it? Run test
What is the motivation for this PR? MX failed to fetch acl port due to DATAACL table in running config is removed by this PR: sonic-net#11250 How did you do it? Fetch acl port from mg_facts How did you verify/test it? Run test
What is the motivation for this PR? MX failed to fetch acl port due to DATAACL table in running config is removed by this PR: sonic-net#11250 How did you do it? Fetch acl port from mg_facts How did you verify/test it? Run test
Description of PR
The goal of test_stress_acl.py is to add/delete acl entries frequently. Refer: #6903
test_stress_acl.py is adding new acl table and it will fail if the TCAM space is not available. As done in other acl tests, removing DATAACL to free TCAM resources to run test_stress_acl.py.
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation