Skip to content

Improve mux-simulator to support drop#2673

Merged
wangxin merged 2 commits intosonic-net:masterfrom
wangxin:improve-mux-simulator
Dec 17, 2020
Merged

Improve mux-simulator to support drop#2673
wangxin merged 2 commits intosonic-net:masterfrom
wangxin:improve-mux-simulator

Conversation

@wangxin
Copy link
Collaborator

@wangxin wangxin commented Dec 16, 2020

Description of PR

Summary:
Fixes # (issue)
This PR is to implement a new mux-simulator API for dropping packets to specified out ports.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

To fully support dualToR testing, we need to simulate packet drop condition in mux. This PR is to implement a new mux-simulator API for dropping packets to specified out ports. Tests can call this API to simulate packet dropping in mux.

How did you do it?

This change improved the mux-simulator to support a new API for dropping traffic to specified output ports. For example:
POST /mux/<vm_set/<port_index>/drop with data:

{"out_ports": ["nic", "tor_b"}

Then mux simulator will change the flow action to NIC port (PTF interface) and torB to "drop".

POST /mux/<vm_set/<port_index>/output with data:

{"out_ports": ["nic", "tor_a"}

Then mux simulator will change the flow action to NIC port (PTF interface) and torA to "output".

This change also enhanced the mux-simulator with logging capability for easier troubleshooting.

How did you verify/test it?

Call the API with different arguments by curl.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

This change improved the mux-simulator to support a new API
for dropping traffic to specified output ports. For example:
POST /mux/<vm_set/<port_index>/drop with data:
{"out_ports": ["nic", "tor_b"}
Then mux simulator will change the flow action to NIC port (PTF
interface) and torB to "drop".

POST /mux/<vm_set/<port_index>/output with data:
{"out_ports": ["nic", "tor_a"}
Then mux simulator will change the flow action to NIC port (PTF
interface) and torA to "output".

This change also enhanced the mux-simulator with logging
capability for easier troubleshooting.

Signed-off-by: Xin Wang <[email protected]>
@wangxin wangxin requested review from a team and theasianpianist December 16, 2020 02:29
@wangxin wangxin merged commit 0c8fcd4 into sonic-net:master Dec 17, 2020
bingwang-ms added a commit that referenced this pull request Dec 21, 2020
…2675)

Description of PR
Summary:
Fixes # (issue)
This PR is to introduce new interfaces for packet drop in y_cable simulator. The interfaces interact with mux simulator server introduced in PR #2673 and control the flow on each interface.

Type of change
 Bug fix
 Testbed and Framework(new/improvement)
 Test case(new/improvement)
Approach
What is the motivation for this PR?
This PR is to introduce new interfaces for packet drop in y_cable simulator.

How did you do it?
Send HTTP requests to interact with mux simulator server introduced in PR #2673 and control the flow on each interface.

How did you verify/test it?
Verified on a dualtor-56 topo.

Verify all interfaces work as expected
Verify packets are dropped as expected
Verify no packet is dropped after recover.
@wangxin wangxin deleted the improve-mux-simulator branch February 1, 2021 08:22
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…net#14561)

Why I did it
src/sonic-platform-common

* 41e2a6e - (HEAD -> 202205, origin/202205) Fix pipeline apt-get purge error. (sonic-net#349) (sonic-net#358) (6 days ago) [Liu Shilong]
src/sonic-swss

* 804e5ac - (HEAD -> 202205, origin/202205) [FDB]Fixing FDB consolidated flush for Remote MACs (sonic-net#2673) (sonic-net#2725) (4 hours ago) [Sudharsan Dhamal Gopalarathnam]
src/sonic-utilities

* ea1d849a - (HEAD -> 202205, origin/202205) Use sonic-swss-common artifacts from the matching source branch (sonic-net#2783) (5 days ago) [Saikrishna Arcot]
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…lly (sonic-net#14655)

src/sonic-swss

* 804e5ac - (HEAD -> 202205, origin/202205) [FDB]Fixing FDB consolidated flush for Remote MACs (sonic-net#2673) (sonic-net#2725) (5 days ago
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
Why I did it
submodule advance

b085b5f - [ci] Fix pipeline error about team5 not found. (Core dump in orchagent when assigning router interface to a vlan with untagged mode  sonic-net#2684) (3 hours ago) [Liu Shilong]
4549b4c - Fix issue: there is no retry while creating a RIF which is in removing state ([201811 sub-module] advance sub-modules: utilities, swss, swss-common sonic-net#2679) (3 hours ago) [Junchao-Mellanox]
980a45b - [FDB]Fixing FDB consolidated flush for Remote MACs (pmon to stretch sonic-net#2673) (3 hours ago) [Sudharsan Dhamal Gopalarathnam]
c646607 - Do not allow to add port to .1Q bridge while router port deletion is not completed (Update SDK, FW and SAI sonic-net#2669) (3 hours ago) [Lior Avramov]
4a321f0 - [orchagent]: Get bridge port ID from orchagent cache instead of SAI API ([201811 sub module] advance sairedis sub module sonic-net#2657) (3 hours ago) [Lawrence Lee]
f4b88f3 - [Dual-ToR] handle 'mux_tunnel_egress_acl' attrib in order to change ACL configuration (drop on ingress/egress) on standby ToR (lm75 doesn't support written alarm to syslog. sonic-net#2646) (3 hours ago) [Andriy Yurkiv]
a4f29c1 - [Workaround] EvpnRemoteVnip2pOrch warmboot check failure ([teamd]: wait for swss db flush done before starting teamd container sonic-net#2626) (3 hours ago) [jcaiMR]
53ee0a8 - Support for tc-dot1p and tc-dscp qosmap ([201803] [router-advertiser] Add templated script to wait for pertinent interfaces to be ready before starting radvd sonic-net#2559) (3 hours ago) [Divya Mukundan]
b953866 - [dual-tor] add missing SAI attribte in order to create IPNIP tunnel (Config reload/load_minigraph not clearing State DB sonic-net#2503) (3 hours ago) [Andriy Yurkiv]
How I did it
How to verify it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants