Skip to content

[test]add more ARP and neighbor-mac tests#303

Merged
maggiemsft merged 3 commits intosonic-net:masterfrom
maggiemsft:masun/arp_and_neigh
Oct 20, 2017
Merged

[test]add more ARP and neighbor-mac tests#303
maggiemsft merged 3 commits intosonic-net:masterfrom
maggiemsft:masun/arp_and_neigh

Conversation

@maggiemsft
Copy link
Copy Markdown
Contributor

@maggiemsft maggiemsft commented Oct 13, 2017

this PR covers 2 issues: #287; #302

  1. add additional neighbor-mac test using kernel mac change and cover ipv6
  2. improve ARP test coverage to test unicast ARP request

lguohan
lguohan reviewed Oct 18, 2017
View reviewed changes
ansible/library/switch_arptable.py Outdated
@@ -59,7 +102,7 @@ def main():
if arp_tbl == None:
Copy link
Copy Markdown
Contributor

@lguohan lguohan Oct 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on the impl, it can never return None. It can only throw exception, you need to catch exception.

lguohan
lguohan reviewed Oct 18, 2017
View reviewed changes
ansible/roles/test/files/acstests/arptest.py Outdated
send_packet(self, 1, pkt)
verify_packet(self, exp_pkt, 1)

class ExpectUnicastReply(acs_base_test.ACSDataplaneTest):
Copy link
Copy Markdown
Contributor

@lguohan lguohan Oct 18, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the function name is confusing.

ExpectUnicatReply mean expect unicast reply. What your function really does is SendUnicastArpRequest, I prefer function name to be VerifyUnicastArpRequest. #Resolved

lguohan
lguohan reviewed Oct 18, 2017
View reviewed changes
ansible/roles/test/tasks/neighbour-mac-noptf.yml Outdated
# - debug: var=arptable

- fail: msg="cannot find a IPv4 and IPv6 neighbor to change mac address"
when: ( arptable.v4 | length == 0 ) or ( arptable.v6 | length == 0 )
Copy link
Copy Markdown
Contributor

@lguohan lguohan Oct 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do not need to fail if there is no neighbor, we can just first create a neigbhor entry.

lguohan
lguohan reviewed Oct 18, 2017
View reviewed changes
ansible/roles/test/tasks/neighbour-mac-noptf.yml Outdated
with_dict: "{{ arptable.v6 }}"
when:
- "'fe80::' not in item.key | lower"
- ('Ethernet' in item.value['interface']) or ('PortChannel' in item.value['interface'])
Copy link
Copy Markdown
Contributor

@lguohan lguohan Oct 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to v6 section below.

lguohan
lguohan reviewed Oct 18, 2017
View reviewed changes
ansible/roles/test/tasks/neighbour-mac.yml Outdated
# ansible-playbook -i inventory --limit arc-switch1027 test_sonic.yml -b -e "ptf_host=ptf-1" --tags neighbour

- name: Add a new test to test SONiC kernel change neighbor mac address, no ptf neighbor requried
include: neighbour-mac-noptf.yml
Copy link
Copy Markdown
Contributor

@lguohan lguohan Oct 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add this to the sonic.yml make it independent of neighour-mac.yml

lguohan
lguohan requested changes Oct 18, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as comments.

lguohan
lguohan approved these changes Oct 20, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@lguohan
Copy link
Copy Markdown
Contributor

lguohan commented Oct 20, 2017

we need later consider mac address change on the vlan interface.

@maggiemsft maggiemsft merged commit 24e4d57 into sonic-net:master Oct 20, 2017
@maggiemsft maggiemsft deleted the masun/arp_and_neigh branch November 21, 2017 04:26
praveen-li pushed a commit to praveen-li/sonic-mgmt that referenced this pull request Jun 20, 2019
Merge remote-tracking branch 'msft_github/master'
cf1c3a7 
* msft_github/master:
  [test]: Add ptf_platform_dir: ptftests to enable more than 32 ports testbed (sonic-net#315)
  [bgp_speaker]: Support t0-64 topology (sonic-net#316)
  [Minigraph Templates]: Add new <DhcpRelays> node to Vlans as appropriate (sonic-net#298)
  [sensors]: Add comment to indicate the sensors data file path
  [ptf_runner]: Add ptf_platform_dir option to indicate --platform-dir option (sonic-net#304)
  Make fetch command arguments supported by newer ansible version (sonic-net#310)
  [arista7260cx3] define t0 116 ports topology
  [fast-reboot test]: Cosmetic fixes (sonic-net#307)
  [test]add more ARP and neighbor-mac tests (sonic-net#303)
  After boot_onie, admin up all bgp interfaces (sonic-net#306)
  Update README.test.md
  add test case bgp multipath relax (sonic-net#284)
  [minigraph]: Remove unnecessary quotes (sonic-net#301)
@daall daall mentioned this pull request Apr 28, 2020
Closed
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@vdahiya12
[sonic-platform-common][sonic-platform-daemons] submodule update (son…
3f3d472 
…ic-net#12105)

sonic-platform-common
c87fd2d (HEAD -> 202012, origin/202012) [Credo][Ycable] enhancement and error exception for some APIs (sonic-net#303)
5e990c2 [ycable] add definitions of some new API's for Y-Cable infrastructure (sonic-net#301)

sonic-platform-daemons
5f3d0a7 (HEAD -> 202012, origin/202012) [ycabled] fix insert events from xcvrd;cleanup some mux toggle logic (sonic-net#287
Signed-off-by: vaibhav-dahiya [email protected]
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@yxieca
[202205][platform-daemon][platform-common] advance submodule head (so…
552c801 
…nic-net#12870)

platform-daemon:
* f057b9a 2022-11-30 | [ycabled] fix minor appl_db retrieving logic for update (sonic-net#319) (HEAD -> 202205) [vdahiya12]
* 9983106 2022-11-15 | [chassisd] update chassisd to write fabric and lc asics on sep erate table (sonic-net#311) (HEAD -> 202205) [arlakshm]
* 8324c26 2022-11-10 | [ycabled] fix exception-handling logic for ycabled (sonic-net#306) [vdahiya12]
* eaf73f8 2022-11-07 | [ycabled] move swsscommon API's from subroutines to call them exactly once per task_worker/thread (sonic-net#303) [vdahiya12]

platform-common:
* 4b528a0 2022-11-21 | Add missing PM and VDM related EEPROM read (sonic-net#326) (HEAD -> 202205) [mihirpat1]
* 8ca6c17 2022-11-14 | Initial commit (sonic-net#323) [mihirpat1]
* 47f87d9 2022-11-23 | EEPROM/DOM Info: The Compliance Code will show "unknown" by using FINISAR 10G LR XCVR (sonic-net#319) [ChiouRung Haung]
* 6273850 2022-06-01 | [ssd_generic] Fix innodisk health regex (sonic-net#287) [Alexander Allen]

Signed-off-by: Ying Xie <[email protected]>

Signed-off-by: Ying Xie <[email protected]>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@yxieca
[202205][utilities][kenerl][swss] advance submodule head (sonic-net#1…
1f677f5 
…3075)

utilities:
* efd2ab8 2022-12-14 | [muxcable][show] update `show mux tunnel-route` to separate ASIC and kernel into two columns (sonic-net#2553) (HEAD -> 202205) [Jing Zhang]

kernel:
* 085d8cb 2022-12-14 | Merge pull request sonic-net#303 from madhava28/cisco/kernel_config (HEAD -> 202205) [Saikrishna Arcot]

swss:
* d8e46b9 2022-12-16 | [muxorch] Skip programming ACL for standby `active-active` ports (sonic-net#2569) (HEAD -> 202205) [Longxiang Lyu]

Signed-off-by: Ying Xie <[email protected]>

Signed-off-by: Ying Xie <[email protected]>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@mssonicbld
[submodule] Update submodule sonic-platform-common to the latest HEAD…
ba8a88a 
… automatically (sonic-net#16107)

src/sonic-platform-common

* 3b993c5 - (HEAD -> 202205, origin/202205) [Credo][Ycable] enhancement and error exception for some APIs (sonic-net#303) (7 hours ago) [Xinyu Lin]
* ab91fde - [ycable] add definitions of some new API's for Y-Cable infrastructure (sonic-net#301) (7 hours ago) [vdahiya12]
* 2b551f2 - [Credo][Ycable] fix incorrect uart statistics (sonic-net#296) (7 hours ago) [Xinyu Lin]
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@mssonicbld
[submodule] Update submodule sonic-snmpagent to the latest HEAD autom…
0cd76e0 
…atically (sonic-net#17723)

src/sonic-snmpagent

* a201154 - (HEAD -> 202205, origin/202205) Fix SNMP dropping some of the queue counter when create_only_config_db_buffers is set to true (sonic-net#303) (sonic-net#305) (29 hours ago) [mssonicbld]
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@mssonicbld
[submodule] Update submodule sonic-host-services to the latest HEAD a…
751c27a 
…utomatically (#23899)

#### Why I did it
src/sonic-host-services
```
* bf1eb69 - (HEAD -> 202505, origin/202505) [202505] Backport: [reboot-cause] Use UTC to ensure consistent sorting (sonic-net#303) (4 minutes ago) [Jianyue Wu]
```
#### How I did it
#### How to verify it
#### Description for the changelog
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@mssonicbld
[submodule] Update submodule sonic-snmpagent to the latest HEAD autom…
1337597 
…atically (sonic-net#17722)

#### Why I did it
src/sonic-snmpagent
```
* e5fd192 - (HEAD -> 202305, origin/202305) Fix SNMP dropping some of the queue counter when create_only_config_db_buffers is set to true (sonic-net#303) (9 hours ago) [DavidZagury]
```
#### How I did it
#### How to verify it
#### Description for the changelog
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@mssonicbld
[submodule] Update submodule sonic-snmpagent to the latest HEAD autom…
208c170 
…atically (sonic-net#17859)

#### Why I did it
src/sonic-snmpagent
```
* 2efaf2e - (HEAD -> 202305, origin/202305) Revert "[action] [PR:303] Fix SNMP dropping some of the queue counter when create_only_config_db_buffers is set to true (sonic-net#303)" (sonic-net#308) (4 minutes ago) [StormLiangMS]
```
#### How I did it
#### How to verify it
#### Description for the changelog
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@mssonicbld
[submodule] Update submodule sonic-snmpagent to the latest HEAD autom…
5d30151 
…atically (sonic-net#17863)

#### Why I did it
src/sonic-snmpagent
```
* 6f59d29 - (HEAD -> 202305, origin/202305) Fix SNMP dropping some of the queue counter when create_only_config_db_buffers is set to true (sonic-net#303) (sonic-net#309) (33 minutes ago) [mssonicbld]
```
#### How I did it
#### How to verify it
#### Description for the changelog
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@mssonicbld
[submodule] Update submodule sonic-gnmi to the latest HEAD automatica…
a3f3a25 
…lly (sonic-net#20518)

#### Why I did it
src/sonic-gnmi
```
* 96d4fde - (HEAD -> 202305, origin/202305) Update all the dbus timeout (sonic-net#301) (26 hours ago) [ganglv]
* dae8924 - Fix pipeline for 202305 branch (sonic-net#303) (2 days ago) [ganglv]
```
#### How I did it
#### How to verify it
#### Description for the changelog
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@stephenxs @StormLiangMS
[submodule] Advance sonic-utilities and sonic-platform-common pointers (
a338427 
sonic-net#12791)

* Update submodule sonic-utilities

72b9cf9 [psushow & psuutil] Support PSU power threshold checking (sonic-net#2326)
dfdc92e Revert "Support the bandit check by GitHub Action (sonic-net#2358)" (sonic-net#2509)
85638b2 YANG Validation for ConfigDB Updates: DEVICE_METADATA, SNMP, SNMP_COMMUNITY tables (sonic-net#2481)
da44d71 YANG Validation for ConfigDB Updates: PORT_STORM_CONTROL, PORT_QOS_MAP, BUFFER_PROFILE, BUFFER_PG, BUFFER_QUEUE, BUFFER_POOL, FEATURE, DEFAULT_LOSSLESS_BUFFER_PARAMETER tables (#
ba9b628 [sfp] Fix issue: Application Advertisement is not well formatted (sonic-net#2491)

Signed-off-by: Stephen Sun <[email protected]>

* Update submodule sonic-platform-daemons

ed818f8 [PSU daemon] Support PSU power threshold checking (sonic-net#288)
707a720 [chassisd] update chassisd to write fabric and lc asics on sep erate table (sonic-net#311)
e8c5657 [ycabled] fix exception-handling logic for ycabled (sonic-net#306)
905874d [ycabled] move swsscommon API's from subroutines to call them exactly once per task_worker/thread (sonic-net#303)
510d330 Fix typo in xcvrd (sonic-net#313)
9ae551f [ycabled] add support for detach mode in 'active-active' topology (sonic-net#309)
82fc7a6 Added filtering logic to send filtered fields from DB event (sonic-net#307)
8a2dad9 [ycabled] fix no port/state returned by grpc server (sonic-net#308)
4ea12cf Fix xcvrd to support 400G ZR optic (sonic-net#293)
23b6970 [ycabled] fix naming error for error condition for CLI handling (sonic-net#302)
501abb2 [ycabled] add some exception catching logic to some vendor specific API's (sonic-net#301)
534f839 [ycabled] add support for getting grpc secerts via shared file (sonic-net#298)
3622aac Remove shell=True (sonic-net#300)
143422b add support to execute new ycable API's, add datetime field to mux_info (sonic-net#297)
6522c46 [ycabled] add notification for gRPC connection state transitions to  IDLE/TRANSIENT_FAILURE (sonic-net#295)
4b3b238 Install libyang to azure pipeline (sonic-net#292)
8ff5f37 Use get() to fetch default value from dictionary for port admin_status sonic-net#286
b03cc74 [Xcvrd] Soak duplicate events and process only updated interested events (sonic-net#285)
3acb171 [ycable] cleanup logic for creating grpc future ready (sonic-net#289)
ce3b6db [ycabled] fix insert events from xcvrd;cleanup some mux toggle logic (sonic-net#287)

Signed-off-by: Stephen Sun <[email protected]>

* Update submodule sonic-platform-common

7c48be2 Add warning/critical thresholds for PSU power (sonic-net#304)
f5ba0d0 Add missing PM and VDM related EEPROM read (sonic-net#326)
02dd597 implement CMIS set_laser_freq to support 100GHz grid space (sonic-net#294)

Signed-off-by: Stephen Sun <[email protected]>

* Revert "Update submodule sonic-platform-daemons"

This reverts commit aea648b157b5083a5ba59fb2cfc2ae2a61779549.

Signed-off-by: Stephen Sun <[email protected]>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@vdahiya12 @StormLiangMS
[sonic-platform-daemons] submodule update (sonic-net#12728)
5bc43c2 
* [sonic-platform-daemons] submodule update

git log --oneline 7c0a326..master
e8c5657 (HEAD -> master, origin/master, origin/HEAD) [ycabled] fix
exception-handling logic for ycabled (sonic-net#306)
905874d [ycabled] move swsscommon API's from subroutines to call them
exactly once per task_worker/thread (sonic-net#303)
510d330 Fix typo in xcvrd (sonic-net#313)
9ae551f [ycabled] add support for detach mode in 'active-active'
topology (sonic-net#309)
82fc7a6 Added filtering logic to send filtered fields from DB event
(sonic-net#307)
8a2dad9 [ycabled] fix no port/state returned by grpc server (sonic-net#308)
4ea12cf Fix xcvrd to support 400G ZR optic (sonic-net#293)
23b6970 [ycabled] fix naming error for error condition for CLI handling
(sonic-net#302)
501abb2 [ycabled] add some exception catching logic to some vendor
specific API's (sonic-net#301)
534f839 [ycabled] add support for getting grpc secerts via shared file
(sonic-net#298)
3622aac Remove shell=True (sonic-net#300)
143422b add support to execute new ycable API's, add datetime field to
mux_info (sonic-net#297)
6522c46 [ycabled] add notification for gRPC connection state transitions
to  IDLE/TRANSIENT_FAILURE (sonic-net#295)
4b3b238 Install libyang to azure pipeline (sonic-net#292)
8ff5f37 Use get() to fetch default value from dictionary for port
admin_status sonic-net#286
b03cc74 [Xcvrd] Soak duplicate events and process only updated
interested events (sonic-net#285)
3acb171 [ycable] cleanup logic for creating grpc future ready (sonic-net#289)
ce3b6db [ycabled] fix insert events from xcvrd;cleanup some mux toggle
logic (sonic-net#287)

Signed-off-by: vaibhav-dahiya <[email protected]>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@StormLiangMS
[submodule advance] advance sonic-platform-daemons submodule for 2022…
57c347d 
…11 branch (sonic-net#13203)

Why I did it
advance sonic-platform-daemons submodule for 202211 branch

a35b57d - (HEAD, origin/202211) Remove TODO comments which are no longer needed (Support centec platform sonic-net#325) (3 days ago) [Junchao-Mellanox]
3a3726b - [thermalctld] fix some redundant removal of state DB tables (configurations are re-generated across reboots sonic-net#315) (3 days ago) [vdahiya12]
c5afac0 - Add new fields to status/dom_sensor/pm tables in STATE_DB for CMIS/C-CMIS (Combine alias_map.json with port_config.ini sonic-net#304) (3 days ago) [longhuan-cisco]
1a338d4 - Create TRANSCEIVER_DOM_THRESHOLD table in state DB (Fix the reference in docker-snmp-sv2 to deprecated alias_map.json sonic-net#320) (3 days ago) [mihirpat1]
7c77907 - Remove the argument that is causing the xcvrd to crash (ingrasys-s9100: Add ingrasys switch s9100 sonic-net#318) (3 days ago) [Vivek]
5a70e7f - [ycabled] fix minor appl_db retrieving logic for update (dockers/docker-snmp-sv2/config.sh still references deprecated alias_map.json file sonic-net#319) (3 days ago) [vdahiya12]
b669533 - Use github code scanning instead of LGTM (Consolidate device-specific files; install as a Debian package sonic-net#316) (3 days ago) [Liu Shilong]
d3c6739 - Pass grid parameter while calling set_laser_freq ([swss]: update sonic-swss to fix buffer configuration on mlnx platform sonic-net#317) (3 days ago) [mihirpat1]
778f843 - [PSU daemon] Support PSU power threshold checking (Add get_graph service to fetch minigraph automatically sonic-net#288) (9 days ago) [Stephen Sun]
707a720 - [chassisd] update chassisd to write fabric and lc asics on sep erate table (ingrasys-s9100: Add ingrasys switch s9100 sonic-net#311) (8 weeks ago) [arlakshm]
e8c5657 - [ycabled] fix exception-handling logic for ycabled (Move sysDescription to /etc/snmp sonic-net#306) (8 weeks ago) [vdahiya12]
905874d - [ycabled] move swsscommon API's from subroutines to call them exactly once per task_worker/thread (Disable BCM54616S MII isolate mode sonic-net#303) (9 weeks ago) [vdahiya12]
510d330 - Fix typo in xcvrd ([platform] Add support configurations files for DCS-7060CX-32S sonic-net#313) (9 weeks ago) [Junchao-Mellanox]
9ae551f - [ycabled] add support for detach mode in 'active-active' topology (minigraph.py crashed when no png is in the minigraph sonic-net#309) (2 months ago) [vdahiya12]
How I did it
How to verify it
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@mssonicbld
[submodule] Update submodule sonic-gnmi to the latest HEAD automatica…
8877a90 
…lly (sonic-net#20517)

#### Why I did it
src/sonic-gnmi
```
* 7fdd5b5 - (HEAD -> 202311, origin/202311) Update all the dbus timeout (sonic-net#301) (sonic-net#307) (26 hours ago) [mssonicbld]
* dc79bce - Fix pipeline for 202305 branch (sonic-net#303) (2 days ago) [ganglv]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lguohan lguohan lguohan approved these changes

@stcheng stcheng Awaiting requested review from stcheng

@pavel-shirshov pavel-shirshov Awaiting requested review from pavel-shirshov

@marian-pritsak marian-pritsak Awaiting requested review from marian-pritsak

Assignees

No one assigned

Labels

Enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maggiemsft @lguohan @stcheng