Refactor var name testbed_name to vm_set_name in testbed-cli.sh#2414
Merged
wangxin merged 1 commit intosonic-net:masterfrom Oct 30, 2020
wangxin:refactor-var-name
Merged
Refactor var name testbed_name to vm_set_name in testbed-cli.sh#2414wangxin merged 1 commit intosonic-net:masterfrom wangxin:refactor-var-name
testbed_name to vm_set_name in testbed-cli.sh#2414wangxin merged 1 commit intosonic-net:masterfrom
wangxin:refactor-var-name
Conversation
The original variable name `testbed_name` in testbed-cli.sh is mis-leading. This change refactored it to `vm_set_name`. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
lguohan
approved these changes
Oct 28, 2020
Collaborator
Author
|
retest this please |
2 similar comments
Collaborator
Author
|
retest this please |
Collaborator
Author
|
retest this please |
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…onic-net#14048) For sonic-platform-daemons following commits are added to the submodule dd8fbae (HEAD -> 202012, origin/202012) [ycabled] add more coverage to ycabled; add minor name change for vendor API CLI return key-values pairs (sonic-net#338) 846555e [thermalctld] fix some redundant removal of state DB tables (sonic-net#315) 3d92fb9 Use github code scanning instead of LGTM (sonic-net#316) For sonic-utilities the following commits are added in this PR to the submodule git log --oneline 39cdb49c..202012 ec4c6ea5 (HEAD -> 202012, origin/202012) [show][muxcable] add some new commands health, reset-cause, queue_info support for muxcable (sonic-net#2414) (sonic-net#2704) 03ef272e [202012][vlan] Remove add field of vlanid to DHCP_RELAY table while adding vlan (sonic-net#2681) e00a81ac [202012][dhcp-relay] Add support for dhcp_relay config cli (sonic-net#2640) 274184e1 [vlan] Refresh dhcpv6_relay config while adding/deleting a vlan (sonic-net#2660) (sonic-net#2668 #### Why I did it updating the submodule of sonic-platform-daemons, sonic-utilities #### How I did it updated the submodule
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Update sonic-swss submodule pointer to include the following: * 8eea92e [202205][counters] Revert PR sonic-net#2432 for the buffer queue/pg counters improvement ([sonic-net#2462](sonic-net/sonic-swss#2462)) * 5d8636a [202205] Enhance orchagent and buffer manager in error handling (sonic-net#2414) ([sonic-net#2449](sonic-net/sonic-swss#2449)) * aa22237 [Everflow/ERSPAN] Set correct destination port and mac address when the nexthop is updated for ERSPAN mirror destination (sonic-net#2392) ([sonic-net#2455](sonic-net/sonic-swss#2455)) * 04ce7be check state_db for po before sending ARP/ND pkts (sonic-net#2444) ([sonic-net#2450](sonic-net/sonic-swss#2450)) * f0138a2 [portmgr] Fixed the orchagent crash due to late arrival of notif (sonic-net#2431) ([sonic-net#2451](sonic-net/sonic-swss#2451)) * 7cfde48 Change the log messages in addKernelNeigh/Route from ERROR to INFO ([sonic-net#2437](sonic-net/sonic-swss#2437)) * 2c5116e [202205][counters] Improve performance by polling only configured ports buffer queue/pg counters ([sonic-net#2432](sonic-net/sonic-swss#2432))
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Why I did it 8c7ddf56 - [warm/fast-reboot] Backup logs from tmpfs to disk during fast/warm shutdown ([swss]: update swss docker to stretch sonic-net#2714) (3 hours ago) [Vaibhav Hemant Dixit] f2a31b30 - [ci] Fix pipeline issue caused by sonic-slave-* change. ([201803] Modify Debian apt repos to reflect changes made by maintainers sonic-net#2709) (3 hours ago) [Liu Shilong] 586ecf0e - [dhcp_relay] Fix dhcp_relay restart error while add/del vlan ([thrift] add a patch to revert THRIFT-3650 sonic-net#2688) (3 hours ago) [Yaqiang Zhu] 07b0ef4c - [portstat CLI] don't print reminder if use json format ([devices] add new accton platform minipack. sonic-net#2670) (3 hours ago) [wenyiz2021] 48d3d3ef - [show][muxcable] add some new commands health, reset-cause, queue_info support for muxcable (DUT takes more than 7 seconds to finish update ip v6 neighbor sonic-net#2414) (3 hours ago) [vdahiya12] How I did it How to verify it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Refactor var name
testbed_nametovm_set_namein testbed-cli.shType of change
Approach
What is the motivation for this PR?
The original variable name
testbed_namein testbed-cli.sh is mis-leading.How did you do it?
This change refactored it to
vm_set_name.How did you verify/test it?
Use
testbed-cli.shto run:Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation