[test_fgnhg] Test enhancement for link operational change and matchmode changes to fine grained ECMP by anish-n · Pull Request #2670 · sonic-net/sonic-mgmt

anish-n · 2020-12-15T18:17:04Z

Description of PR

Summary:
Enhance test_fgnhg with link operational change testing.

Type of change

Bug fix
Testbed and Framework(new/improvement)
Test case(new/improvement)

Approach

What is the motivation for this PR?

HLD update: sonic-net/SONiC#693

How did you do it?

Change link operational state in the test and validate that ECMP adjusts to account for it

How did you verify/test it?

By running the test via pytest/ptf

Any platform specific information?

Applicable to all platforms which support fine grained ecmp

Supported testbed topology if it's a new test case?

Documentation

sonic-net/SONiC#693

lgtm-com · 2020-12-15T18:40:09Z

This pull request introduces 2 alerts when merging 63034b2 into c86b445 - view on LGTM.com

new alerts:

2 for Result of integer division may be truncated

tests/ecmp/test_fgnhg.py

lgtm-com · 2021-02-01T21:00:24Z

This pull request introduces 2 alerts when merging 6594039 into b901773 - view on LGTM.com

new alerts:

2 for Result of integer division may be truncated

lgtm-com · 2021-02-18T05:22:28Z

This pull request introduces 6 alerts when merging 298a5bf into a0836c8 - view on LGTM.com

new alerts:

5 for Result of integer division may be truncated
1 for Wrong number of arguments in a call

anish-n · 2021-03-03T21:49:52Z

@nazariig please can you help review?

… in the pytest currently, it is planned to be added to pytest in a future PR

tests/ecmp/test_fgnhg.py

ansible/roles/test/files/ptftests/fg_ecmp_test.py

tests/ecmp/test_fgnhg.py

… common args

lgtm-com · 2021-03-31T01:07:28Z

This pull request introduces 12 alerts when merging 013ce50 into 1141ee7 - view on LGTM.com

new alerts:

5 for Result of integer division may be truncated
4 for Testing equality to None
2 for Unused local variable
1 for Wrong number of arguments in a call

wangxin

Can you also fix the LGTM alerts?

tests/ecmp/test_fgnhg.py

lgtm-com · 2021-04-01T00:08:34Z

This pull request introduces 6 alerts when merging 5097deb into a2a435c - view on LGTM.com

new alerts:

5 for Result of integer division may be truncated
1 for Unused import

anish-n · 2021-04-01T00:15:06Z

Can you also fix the LGTM alerts?

Fixed LGTM errors, the remaining one on result of integer division may be truncated is fine from the test logic perspective and may be ignored.

lgtm-com · 2021-04-01T00:42:58Z

This pull request introduces 5 alerts when merging e2c17ba into a2a435c - view on LGTM.com

new alerts:

5 for Result of integer division may be truncated

abdosi · 2021-04-01T23:14:46Z

can you fix LGTM ?

anish-n · 2021-04-01T23:23:02Z

can you fix LGTM ?

Have fixed most LGTM errors, the remaining one on result of integer division may be truncated is fine from the test logic perspective and can be ignored?

it can't be fix ?

anish-n · 2021-04-06T16:41:23Z

@abdosi , @wangxin can you please help merge the PR if it is good to go?

…de changes to fine grained ECMP (sonic-net#2670) Enhance test_fgnhg with link operational change testing.

…nux-kernel] advance submodule head (sonic-net#13906) linkmgrd: * 3e7a9df 2023-02-19 | [active-active] Toggle to standby if default route is missing (sonic-net#171) (HEAD -> 202205) [Longxiang Lyu] * 8ab1b2b 2023-02-15 | [active-active] fix issue that interfaces get stuck in `active` if service starts up with link state down (sonic-net#169) [Jing Zhang] * df862ad 2023-02-11 | Fix mux config when gRPC connection is lost (sonic-net#166) [Longxiang Lyu] utilities: * 8aa7930c 2023-02-13 | [portstat CLI] don't print reminder if use json format (sonic-net#2670) (HEAD -> 202205, github/202205) [wenyiz2021] * 4e3bb6fa 2023-02-21 | Add "show fabric reachability" command. (sonic-net#2672) [jfeng-arista] * 3587a94b 2023-02-18 | [202205][dhcp_relay] Remove add field of vlanid to DHCP_RELAY table while adding vlan (sonic-net#2680) [Yaqiang Zhu] * 4f07f7f0 2023-02-10 | Skip saidump for Spine Router as this can take more than 5 sec (sonic-net#2637) (sonic-net#2671) [kenneth-arista] * e61c5ec4 2023-02-10 | [vlan] Refresh dhcpv6_relay config while adding/deleting a vlan (sonic-net#2660) (sonic-net#2669) [Yaqiang Zhu] swss: * 1bbf725 2023-02-14 | [Workaround] EvpnRemoteVnip2pOrch warmboot check failure (sonic-net#2626) (HEAD -> 202205) [jcaiMR] * 380f72b 2023-02-20 | Support for tc-dot1p and tc-dscp qosmap (sonic-net#2559) [Divya Mukundan] * dbf6fcc 2022-11-01 | Added LAG member check on addLagMember() (sonic-net#2464) [Andriy Kokhan] swss-common: * b31391b 2023-02-21 | Prevent sonic-db-cli generate core dump (sonic-net#749) (HEAD -> 202205) [Hua Liu] * 16ff689 2022-12-13 | Support for TC-DOT1p qos map (sonic-net#721) [Divya Mukundan] platform-daemons: * fb92af4 2023-02-09 | [ycabled] add more coverage to ycabled; add minor name change for vendor API CLI return key-values pairs (sonic-net#338) (HEAD -> 202205) [vdahiya12] linux-kernel: * 4e62401 2023-02-09 | Update linux kernel for hw-mgmt V.7.0020.4104 (sonic-net#305) (HEAD -> 202205) [Stephen Sun] Signed-off-by: Ying Xie <ying.xie@microsoft.com>

Why I did it 8c7ddf56 - [warm/fast-reboot] Backup logs from tmpfs to disk during fast/warm shutdown ([swss]: update swss docker to stretch sonic-net#2714) (3 hours ago) [Vaibhav Hemant Dixit] f2a31b30 - [ci] Fix pipeline issue caused by sonic-slave-* change. ([201803] Modify Debian apt repos to reflect changes made by maintainers sonic-net#2709) (3 hours ago) [Liu Shilong] 586ecf0e - [dhcp_relay] Fix dhcp_relay restart error while add/del vlan ([thrift] add a patch to revert THRIFT-3650 sonic-net#2688) (3 hours ago) [Yaqiang Zhu] 07b0ef4c - [portstat CLI] don't print reminder if use json format ([devices] add new accton platform minipack. sonic-net#2670) (3 hours ago) [wenyiz2021] 48d3d3ef - [show][muxcable] add some new commands health, reset-cause, queue_info support for muxcable (DUT takes more than 7 seconds to finish update ip v6 neighbor sonic-net#2414) (3 hours ago) [vdahiya12] How I did it How to verify it

anish-n added 2 commits December 15, 2020 01:15

Initial link oper state handling changes

b0987ff

Improve test logging and other misc improvements

63034b2

kktheballer reviewed Dec 18, 2020

View reviewed changes

tests/ecmp/test_fgnhg.py Outdated Show resolved Hide resolved

kktheballer reviewed Dec 18, 2020

View reviewed changes

tests/ecmp/test_fgnhg.py Outdated Show resolved Hide resolved

kktheballer reviewed Dec 18, 2020

View reviewed changes

tests/ecmp/test_fgnhg.py Outdated Show resolved Hide resolved

Add pseudo route/link flap test

6594039

kktheballer approved these changes Feb 2, 2021

View reviewed changes

Add FG matchmode changes

298a5bf

anish-n requested a review from a team as a code owner February 18, 2021 04:54

anish-n changed the title ~~[test_fgnhg] Link operational change testing~~ [test_fgnhg] Test enhancement for link operational change and matchmode changes to fine grained ECMP Feb 22, 2021

Add support for warm boot in the ptf test, warm boot is not triggered…

337dded

… in the pytest currently, it is planned to be added to pytest in a future PR

vivekrnv reviewed Mar 18, 2021

View reviewed changes

tests/ecmp/test_fgnhg.py Show resolved Hide resolved

nazariig reviewed Mar 24, 2021

View reviewed changes

ansible/roles/test/files/ptftests/fg_ecmp_test.py Show resolved Hide resolved

nazariig approved these changes Mar 24, 2021

View reviewed changes

abdosi requested changes Mar 24, 2021

View reviewed changes

tests/ecmp/test_fgnhg.py Outdated Show resolved Hide resolved

tests/ecmp/test_fgnhg.py Show resolved Hide resolved

tests/ecmp/test_fgnhg.py Show resolved Hide resolved

tests/ecmp/test_fgnhg.py Outdated Show resolved Hide resolved

Incorporate review comment to have a separate ptf runner function for…

013ce50

… common args

wangxin reviewed Mar 31, 2021

View reviewed changes

tests/ecmp/test_fgnhg.py Outdated Show resolved Hide resolved

tests/ecmp/test_fgnhg.py Outdated Show resolved Hide resolved

Incorporate review comments and fix lgtm warnings

5097deb

Fix import LGTM alert

e2c17ba

anish-n requested a review from abdosi April 1, 2021 00:15

wangxin approved these changes Apr 1, 2021

View reviewed changes

abdosi approved these changes Apr 1, 2021

View reviewed changes

abdosi merged commit f8a5a6b into sonic-net:master Apr 6, 2021

JibinBao mentioned this pull request Apr 13, 2021

In test ecmp/test_fgnhg.py , 'DEFAULT_NAMESPACE' is not defined or imported #3323

Open

saravanansv pushed a commit to saravanansv/sonic-mgmt that referenced this pull request May 6, 2021

[test_fgnhg] Test enhancement for link operational change and matchmo…

7ce0117

…de changes to fine grained ECMP (sonic-net#2670) Enhance test_fgnhg with link operational change testing.

vmittal-msft pushed a commit to vmittal-msft/sonic-mgmt that referenced this pull request Sep 28, 2021

[test_fgnhg] Test enhancement for link operational change and matchmo…

4f20f8a

…de changes to fine grained ECMP (sonic-net#2670) Enhance test_fgnhg with link operational change testing.

Conversation

anish-n commented Dec 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

Type of change

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

lgtm-com bot commented Dec 15, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lgtm-com bot commented Feb 1, 2021

Uh oh!

lgtm-com bot commented Feb 18, 2021

Uh oh!

anish-n commented Mar 3, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lgtm-com bot commented Mar 31, 2021

Uh oh!

wangxin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

lgtm-com bot commented Apr 1, 2021

Uh oh!

anish-n commented Apr 1, 2021

Uh oh!

lgtm-com bot commented Apr 1, 2021

Uh oh!

abdosi commented Apr 1, 2021

Uh oh!

anish-n commented Apr 1, 2021 • edited by abdosi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anish-n commented Apr 6, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

anish-n commented Dec 15, 2020 •

edited

Loading

anish-n commented Apr 1, 2021 •

edited by abdosi

Loading