SPyTest 2.1 release, LGTM fixes and new test cases

[ramakristipati]

Description of PR

LGTM fixes and new test cases

Summary:
Fixes # LGTM issues

Type of change

• Bug fix
• Testbed and Framework(new/improvement)
• Test case(new/improvement)

Approach

What is the motivation for this PR?

Contribute More Test Cases

How did you do it?

List of new test modules added which can be used to verify Broadcom PRs

• qos/acl/test_acls_l3_forwarding.py
• qos/test_cos.py
• qos/test_wred.py
• routing/BGP/test_bgp_rr_traffic.py
• routing/NAT/test_nat.py
• routing/NAT/test_nat_reboot_long_run.py
• routing/NAT/test_nat_tcp.py
• routing/VRF/test_vrf.py
• routing/VRF/test_vrf_scale.py
• routing/test_arp_static_route_long_run.py
• routing/test_l3_performance.py
• routing/test_ndp.py
• sanity/test_sanity_l3.py
• switching/test_vlan.py
• system/test_sflow.py
• system/test_snapshot.py
• system/threshold/test_threshold.py

How did you verify/test it?

Execute using build with modifications to SONiC by Broadcom in PTF and Ixia testbeds

Any platform specific information?

None

Supported testbed topology if it's a new test case?

PTF,IXIA

Documentation

Added Framework Updates in Doc folder

[lgtm-com]

This pull request fixes 72 alerts when merging 693744d into 0c8fcd4 - view on LGTM.com

fixed alerts:

• 20 for Unreachable code
• 14 for Non-iterable used in for loop
• 9 for Unused local variable
• 8 for Variable defined multiple times
• 7 for Membership test with a non-container
• 5 for Result of integer division may be truncated
• 4 for Modification of parameter with default
• 1 for Wrong name for an argument in a call
• 1 for Conflicting attributes in base classes
• 1 for Suspicious unused loop iteration variable
• 1 for Binding a socket to all network interfaces
• 1 for __init__ method calls overridden method

[lgtm-com]

This pull request introduces 3 alerts and fixes 84 when merging a19d66ba1d94ba11de0b1447fca2c1dcd0dfd5f3 into fc9bd4b - view on LGTM.com

new alerts:

• 1 for Unused local variable
• 1 for Unused import
• 1 for Module is imported with 'import' and 'import from'

fixed alerts:

• 20 for Unreachable code
• 15 for Non-iterable used in for loop
• 11 for Unused import
• 9 for Unused local variable
• 8 for Variable defined multiple times
• 7 for Membership test with a non-container
• 5 for Result of integer division may be truncated
• 4 for Modification of parameter with default
• 1 for Wrong name for an argument in a call
• 1 for Conflicting attributes in base classes
• 1 for Suspicious unused loop iteration variable
• 1 for Binding a socket to all network interfaces
• 1 for __init__ method calls overridden method

[lgtm-com]

This pull request fixes 84 alerts when merging 693744d into fc9bd4b - view on LGTM.com

fixed alerts:

• 20 for Unreachable code
• 15 for Non-iterable used in for loop
• 11 for Unused import
• 9 for Unused local variable
• 8 for Variable defined multiple times
• 7 for Membership test with a non-container
• 5 for Result of integer division may be truncated
• 4 for Modification of parameter with default
• 1 for Wrong name for an argument in a call
• 1 for Conflicting attributes in base classes
• 1 for Suspicious unused loop iteration variable
• 1 for Binding a socket to all network interfaces
• 1 for __init__ method calls overridden method