[test_fan_drawer_fans] Fix test_fan_drawer_fans on API tests#2668
Merged
wangxin merged 2 commits intosonic-net:masterfrom Jan 4, 2021
shlomibitton:shlomi_fix_fan_drawer_fans_led_platform_api
Merged
[test_fan_drawer_fans] Fix test_fan_drawer_fans on API tests#2668wangxin merged 2 commits intosonic-net:masterfrom shlomibitton:shlomi_fix_fan_drawer_fans_led_platform_api
wangxin merged 2 commits intosonic-net:masterfrom
shlomibitton:shlomi_fix_fan_drawer_fans_led_platform_api
Conversation
Add WA for mellanox since it is not supporting setting leds to 'off' Change-Id: I3bd7cfbfb97b247089aaeb6b64674f1bb5963422 Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
Contributor
Author
|
retest vsimage please |
jleveque
reviewed
Dec 15, 2020
Collaborator
|
@wangxin can you please review? |
wangxin
approved these changes
Jan 4, 2021
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…onic-net#14048) For sonic-platform-daemons following commits are added to the submodule dd8fbae (HEAD -> 202012, origin/202012) [ycabled] add more coverage to ycabled; add minor name change for vendor API CLI return key-values pairs (sonic-net#338) 846555e [thermalctld] fix some redundant removal of state DB tables (sonic-net#315) 3d92fb9 Use github code scanning instead of LGTM (sonic-net#316) For sonic-utilities the following commits are added in this PR to the submodule git log --oneline 39cdb49c..202012 ec4c6ea5 (HEAD -> 202012, origin/202012) [show][muxcable] add some new commands health, reset-cause, queue_info support for muxcable (sonic-net#2414) (sonic-net#2704) 03ef272e [202012][vlan] Remove add field of vlanid to DHCP_RELAY table while adding vlan (sonic-net#2681) e00a81ac [202012][dhcp-relay] Add support for dhcp_relay config cli (sonic-net#2640) 274184e1 [vlan] Refresh dhcpv6_relay config while adding/deleting a vlan (sonic-net#2660) (sonic-net#2668 #### Why I did it updating the submodule of sonic-platform-daemons, sonic-utilities #### How I did it updated the submodule
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…ance submodule head (sonic-net#14029) utilities: * a4f141f1 2023-01-10 | [sfputil] Firmware download/upgrade CLI support for QSFP-DD (sonic-net#1947) (sonic-net#2349) (HEAD -> 202205) [CliveNi] swss-common: * 41fcad8 2023-01-30 | Increase the netlink buffer size from 3MB to 16MB. (sonic-net#739) (HEAD -> 202205) [KISHORE KUNAL] sairedis: * 5ce9990 2023-02-27 | [Dual-ToR] update sai.profile with SAI_ADDITIONAL_MAC_ENABLED attribute if corresponding arg passed to syncd (sonic-net#1201) (HEAD -> 202205) [Andriy Yurkiv] * 3c2e0c5 2023-02-23 | Use new value of STATE_DB FAST_REBOOT entry (sonic-net#1196) [Aryeh Feigin] * fe7756f 2023-02-28 | [submodule][SAI]Advance SAI head (sonic-net#1210) (github/202205) [Richard.Yu] platform-common: * 321a8e7 2022-09-23 | Cdb fw upgrade (sonic-net#308) (HEAD -> 202205) [CliveNi] swss: * ceea558 2023-02-28 | [orchagent]: Get bridge port ID from orchagent cache instead of SAI API (sonic-net#2657) (HEAD -> 202205) [Lawrence Lee] * bd04e24 2023-03-01 | [dualtor] Fix neighbor miss when mux is not ready (sonic-net#2676) (HEAD -> 202205) [Longxiang Lyu] * 7d87a90 2023-02-28 | [ci] Fix pipeline error about team5 not found. (sonic-net#2684) [Liu Shilong] * 93a924c 2023-02-27 | [aclorch] Fixed issue sonic-net#2204.Support IN_PORTS qualifer in MIRRORV6 table. (sonic-net#2668) [Rajkumar-Marvell] * 9d87ec4 2023-02-23 | swss: Fix Invalid port oid messages generated because of voq counters. (sonic-net#2653) [Sambath Kumar Balasubramanian] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
swss: * 143cd44 2023-03-04 | Revert "[aclorch] Fixed issue sonic-net#2204.Support IN_PORTS qualifer in MIRRORV6 table. (sonic-net#2668)" (sonic-net#2687) (HEAD -> 202205, github/202205) [StormLiangMS] * 25812f8 2023-02-06 | [test_mux] add sleep in test_NH (sonic-net#2648) [Nikola Dancejic] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shlomi Bitton shlomibi@nvidia.com
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
Each platform support different LED colors, but the functionality is the same.
This fix group LED colors into groups of same logical meaning and test accordingly, with no need to define vendor and platform specific LED colors.
How did you do it?
Group same logical LED colors into different Led "types".
How did you verify/test it?
Run the test on any platform.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation