[SONiC Fanout] Config template for SONiC Fanout switch with buffer configuration by vaibhavhd · Pull Request #2431 · sonic-net/sonic-mgmt

vaibhavhd · 2020-10-29T19:11:06Z

Description of PR

Summary: Configuration template for SONiC leaf fanout switch

Type of change

Bug fix
Testbed and Framework(new/improvement)
Test case(new/improvement)

Approach

New j2 template included for SONiC fanout configuration support for 7060 switches.

What is the motivation for this PR?

To run SONiC on leaf fanout switches.

How did you do it?

Added new template, modified playbook to fail for unsupported HwSku, and disabled config reload for fanout switches.

How did you verify/test it?

SONiC Fanout configuration playbook

TASK [fanout : Find the root fanout switch] ********************************************************************************************************************************************************************************
Thursday 29 October 2020  17:33:33 +0000 (0:00:00.036)       0:00:08.981 ******
skipping: [str-7060cx-32s-08]

TASK [fanout : set_fact] ***************************************************************************************************************************************************************************************************
Thursday 29 October 2020  17:33:33 +0000 (0:00:00.038)       0:00:09.020 ******
skipping: [str-7060cx-32s-08]

TASK [fanout : Change root fanout port vlan] *******************************************************************************************************************************************************************************
Thursday 29 October 2020  17:33:33 +0000 (0:00:00.043)       0:00:09.063 ******
skipping: [str-7060cx-32s-08]

PLAY RECAP *****************************************************************************************************************************************************************************************************************
str-7060cx-32s-08          : ok=12   changed=3    unreachable=0    failed=0    skipped=24   rescued=0    ignored=0

Thursday 29 October 2020  17:33:33 +0000 (0:00:00.026)       0:00:09.089 ******
===============================================================================

Results of test_qos_sai tests executed on a SONiC DUT connected to SONiC leaf Fanout switch

================ test session starts ================
collected 18 items                                                                                                                                                                                                         

qos/test_qos_sai.py::TestQosSai::testParameter PASSED                                                                                                                                                                [  5%]
qos/test_qos_sai.py::TestQosSai::testQosSaiPfcXoffLimit[xoff_1] PASSED                                                                                                                                               [ 11%]
qos/test_qos_sai.py::TestQosSai::testQosSaiPfcXoffLimit[xoff_2] PASSED                                                                                                                                               [ 16%]
qos/test_qos_sai.py::TestQosSai::testQosSaiPfcXonLimit[xon_1] PASSED                                                                                                                                                 [ 22%]
qos/test_qos_sai.py::TestQosSai::testQosSaiPfcXonLimit[xon_2] PASSED                                                                                                                                                 [ 27%]
qos/test_qos_sai.py::TestQosSai::testQosSaiHeadroomPoolSize PASSED                                                                                                                                                   [ 33%]
qos/test_qos_sai.py::TestQosSai::testQosSaiBufferPoolWatermark[wm_buf_pool_lossless] SKIPPED                                                                                                                         [ 38%]
qos/test_qos_sai.py::TestQosSai::testQosSaiBufferPoolWatermark[wm_buf_pool_lossy] SKIPPED                                                                                                                            [ 44%]
qos/test_qos_sai.py::TestQosSai::testQosSaiLossyQueue PASSED                                                                                                                                                         [ 50%]
qos/test_qos_sai.py::TestQosSai::testQosSaiDscpQueueMapping PASSED                                                                                                                                                   [ 55%]
qos/test_qos_sai.py::TestQosSai::testQosSaiDwrr PASSED                                                                                                                                                               [ 61%]
qos/test_qos_sai.py::TestQosSai::testQosSaiPgSharedWatermark[wm_pg_shared_lossless] PASSED                                                                                                                           [ 66%]
qos/test_qos_sai.py::TestQosSai::testQosSaiPgSharedWatermark[wm_pg_shared_lossy] PASSED                                                                                                                              [ 72%]
qos/test_qos_sai.py::TestQosSai::testQosSaiPgHeadroomWatermark PASSED                                                                                                                                                [ 77%]
qos/test_qos_sai.py::TestQosSai::testQosSaiQSharedWatermark[wm_q_shared_lossless] PASSED                                                                                                                             [ 83%]
qos/test_qos_sai.py::TestQosSai::testQosSaiQSharedWatermark[wm_q_shared_lossy] PASSED                                                                                                                                [ 88%]
qos/test_qos_sai.py::TestQosSai::testQosSaiDscpToPgMapping SKIPPED                                                                                                                                                   [ 94%]
qos/test_qos_sai.py::TestQosSai::testQosSaiDwrrWeightChange PASSED                                                                                                                                                   [100%]

================ short test summary info ================
================ 15 passed, 3 skipped in 1634.65 seconds ================

SONiC Fanout switches of unsupported type will fail the fanout playbook:

TASK [fanout : build fanout vlan config] ***********************************************************************************************************************************************************************************
Thursday 29 October 2020  18:29:59 +0000 (0:00:01.600)       0:00:02.595 ******
fatal: [str-7060cx-32s-08]: FAILED! => {"changed": false, "msg": "SONiC fanout switch with HwSku ABC-123 not supported"}

PLAY RECAP *****************************************************************************************************************************************************************************************************************
str-7060cx-32s-08          : ok=5    changed=0    unreachable=0    failed=1    skipped=8    rescued=0    ignored=0

Thursday 29 October 2020  18:29:59 +0000 (0:00:00.036)       0:00:02.631 ******

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Update sonic-swss submodule pointer to include the following: * 8eea92e [202205][counters] Revert PR sonic-net#2432 for the buffer queue/pg counters improvement ([sonic-net#2462](sonic-net/sonic-swss#2462)) * 5d8636a [202205] Enhance orchagent and buffer manager in error handling (sonic-net#2414) ([sonic-net#2449](sonic-net/sonic-swss#2449)) * aa22237 [Everflow/ERSPAN] Set correct destination port and mac address when the nexthop is updated for ERSPAN mirror destination (sonic-net#2392) ([sonic-net#2455](sonic-net/sonic-swss#2455)) * 04ce7be check state_db for po before sending ARP/ND pkts (sonic-net#2444) ([sonic-net#2450](sonic-net/sonic-swss#2450)) * f0138a2 [portmgr] Fixed the orchagent crash due to late arrival of notif (sonic-net#2431) ([sonic-net#2451](sonic-net/sonic-swss#2451)) * 7cfde48 Change the log messages in addKernelNeigh/Route from ERROR to INFO ([sonic-net#2437](sonic-net/sonic-swss#2437)) * 2c5116e [202205][counters] Improve performance by polling only configured ports buffer queue/pg counters ([sonic-net#2432](sonic-net/sonic-swss#2432))

Config template for SONiC Fanout switch with buffer configuration

86e70a7

vaibhavhd requested a review from a team October 29, 2020 19:11

vaibhavhd changed the title ~~Config template for SONiC Fanout switch with buffer configuration~~ [SONiC Fanout] Config template for SONiC Fanout switch with buffer configuration Oct 29, 2020

yxieca approved these changes Oct 30, 2020

View reviewed changes

vaibhavhd merged commit 8d98d5b into sonic-net:master Oct 30, 2020

vaibhavhd deleted the sonic-fanout-playbook branch October 30, 2020 16:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SONiC Fanout] Config template for SONiC Fanout switch with buffer configuration#2431

[SONiC Fanout] Config template for SONiC Fanout switch with buffer configuration#2431
vaibhavhd merged 1 commit intosonic-net:masterfrom
vaibhavhd:sonic-fanout-playbook

vaibhavhd commented Oct 29, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

vaibhavhd commented Oct 29, 2020

Description of PR

Type of change

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants