Skip to content

[Vrf] Added missing ptftests folder to test_vrf_attr#2709

Merged
yxieca merged 1 commit intosonic-net:masterfrom
AndriiLozovyi:Add_missing_ptftests_folder
Dec 28, 2020
Merged

[Vrf] Added missing ptftests folder to test_vrf_attr#2709
yxieca merged 1 commit intosonic-net:masterfrom
AndriiLozovyi:Add_missing_ptftests_folder

Conversation

@AndriiLozovyi
Copy link
Copy Markdown
Contributor

Signed-off-by: Andrii-Yosafat Lozovyi [email protected]

Description of PR

Summary: test_vrf_attr fails due to missing ptftests folder on PTF and incorrect patch to jinja template vrf_attr_src_mac.j2

E RunAnsibleModuleFail: run module shell failed, Ansible Results =>
ptf: error: invalid value for --test-dir: directory ptftests does not exist

E RunAnsibleModuleFail: run module shell failed, Ansible Results =>
Could not find or access 'vrf_attr_src_mac.j2'
Searched in: sonic-mgmt/tests/templates/vrf_attr_src_mac.j2 on the Ansible Controller.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

Fix test_vrf_attr and make it working.

How did you do it?

Edited patch to jinja template and added copy_ptftests_directory fixture.

How did you verify/test it?

Run test_vrf_attr TC on topo t0

vrf/test_vrf_attr.py::TestVrfAttrSrcMac::test_vrf_src_mac_cfg PASSED
vrf/test_vrf_attr.py::TestVrfAttrSrcMac::test_vrf2_neigh_with_default_router_mac PASSED
vrf/test_vrf_attr.py::TestVrfAttrIpAction::test_vrf1_fwd_pkts_without_ip_opt PASSED
vrf/test_vrf_attr.py::TestVrfAttrIpAction::test_vrf2_fwd_pkts_with_ip_opt PASSED

Any platform specific information?

SONiC.master.67-dirty-20201218.064842
Distribution: Debian 10.7
Kernel: 4.19.0-9-2-amd64
Build commit: 317a4b34
Build date: Fri Dec 18 06:57:50 UTC 2020
Platform: x86_64-arista_7170_64c

Supported testbed topology if it's a new test case?

Documentation

Signed-off-by: Andrii-Yosafat Lozovyi <[email protected]>
@AndriiLozovyi
Copy link
Copy Markdown
Contributor Author

retest vsimage please

@AndriiLozovyi
Copy link
Copy Markdown
Contributor Author

Pls review @wangxin @yxieca

@yxieca yxieca merged commit ff713c2 into sonic-net:master Dec 28, 2020
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…sonic-net#14120)

linkmgrd:
* 046bdd0 2023-03-06 | [active-active] add state transition handler for (LinkProber: Unknown, MuxState: Active, LinkState: Down) (sonic-net#179) (HEAD -> 202205) [Jing Zhang]
* 15ba715 2023-03-06 | loose link down swithcover condition (sonic-net#178) [Jing Zhang]

utilities:
* 51d9c9f6 2023-03-06 | [warm/fast-reboot] Backup logs from tmpfs to disk during fast/warm shutdown (sonic-net#2714) (HEAD -> 202205) [Vaibhav Hemant Dixit]
* 03aa77b3 2023-03-02 | [ci] Fix pipeline issue caused by sonic-slave-* change. (sonic-net#2709) [Liu Shilong]
* 4bd7d4f1 2023-03-03 | [db_migrator] Add missing attribute 'weight' to route entries in APPL DB (sonic-net#2691) [Vaibhav Hemant Dixit]
* 69a60397 2023-03-01 | removed duplicates and resolved conflicts (sonic-net#2674) (github/202205) [kannankvs]

platform-daemon:
* 10bc119 2023-03-06 | [ycable] add changes for correcting telemetry values for 'active-active' (sonic-net#341) (HEAD -> 202205) [vdahiya12]

Signed-off-by: Ying Xie <[email protected]>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
Why I did it
8c7ddf56 - [warm/fast-reboot] Backup logs from tmpfs to disk during fast/warm shutdown ([swss]: update swss docker to stretch sonic-net#2714) (3 hours ago) [Vaibhav Hemant Dixit]
f2a31b30 - [ci] Fix pipeline issue caused by sonic-slave-* change. ([201803] Modify Debian apt repos to reflect changes made by maintainers sonic-net#2709) (3 hours ago) [Liu Shilong]
586ecf0e - [dhcp_relay] Fix dhcp_relay restart error while add/del vlan ([thrift] add a patch to revert THRIFT-3650 sonic-net#2688) (3 hours ago) [Yaqiang Zhu]
07b0ef4c - [portstat CLI] don't print reminder if use json format ([devices] add new accton platform minipack. sonic-net#2670) (3 hours ago) [wenyiz2021]
48d3d3ef - [show][muxcable] add some new commands health, reset-cause, queue_info support for muxcable (DUT takes more than 7 seconds to finish update ip v6 neighbor sonic-net#2414) (3 hours ago) [vdahiya12]
How I did it
How to verify it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants