[Platform API][Chassis][Module] Remove tests for deprecated, redundant get_serial_number() methods#2343
Merged
jleveque merged 1 commit intosonic-net:masterfrom Oct 14, 2020
jleveque:remove_deprecated
Merged
[Platform API][Chassis][Module] Remove tests for deprecated, redundant get_serial_number() methods#2343jleveque merged 1 commit intosonic-net:masterfrom jleveque:remove_deprecated
jleveque merged 1 commit intosonic-net:masterfrom
jleveque:remove_deprecated
Conversation
…t get_serial_number() methods
vdahiya12
approved these changes
Oct 14, 2020
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…ic-net#11223) swss: * 43b9f06 2022-06-23 | [ACL] Support stage particular match fields (sonic-net#2341) (HEAD -> 202205) [bingwang-ms] * c7f1add 2022-06-22 | Fix qos map test in vs test (sonic-net#2343) [bingwang-ms] * 0549f3c 2022-06-22 | Fix for "orchagent crashed when trying to delete fdb static entry with swssconfig sonic-net#11046" (sonic-net#2332) [anilkpan] utilities: * 785508d 2022-05-25 | [GCU] Handling type1 lists (sonic-net#2171) (HEAD -> 202205) [Mohamed Ghoneim] * 56c2c6b 2022-06-22 | [config reload] Fixing config reload when timer based services are disabled (sonic-net#2200) (sonic-net#2226) (HEAD -> 202205, github/202205) [Sudharsan Dhamal Gopalarathnam] * 600979e 2022-06-16 | Fix header for the output table following 'show ipv6 interface' command (sonic-net#2219) [Dror Prital] sairedis: * 14fba45 2022-06-13 | [vslib]: Fixbug in cleanup MACsec device (sonic-net#1059) (HEAD -> 202205) [Ze Gan] * ac6e7ad 2022-04-29 | [vslib]: Update packet number of MACsec SA at runtime (sonic-net#1007) [Ze Gan] platform-daemons: * 6ffec22 2022-06-22 | [ycabled] Fix the init values for active-active ports (sonic-net#266) (HEAD -> 202205) [vdahiya12] Signed-off-by: Ying Xie <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…e submodule head (sonic-net#12149) linkmgrd: * 05e5f4c 2022-09-20 | [Active-Active] flaky LinkmgrdBootupSequence unit tests (sonic-net#134) (HEAD -> 202205) [Jing Zhang] * 16fcadf 2022-09-13 | [active-standby] update warmboot reconciliation logic (sonic-net#129) [Jing Zhang] * e656a87 2022-09-09 | [active-active] shutdown link prober when starting as isolated (sonic-net#130) [Jing Zhang] uttilities: yinxi@ying-dev-vm-01:~/src/sonic-202205/src/sonic-utilities$ git hist github/202205..HEAD * 562188f 2022-09-14 | Use 'default' VRF when VRF name is not provided (sonic-net#2368) (HEAD -> 202205) [Sumukha Tumkur Vani] * c50ba4f 2022-09-20 | [minigraph] add option to specify golden path in load_minigraph (sonic-net#2350) [jingwenxie] * cec5ab2 2022-09-20 | [GCU]Remove GCU unique lane check for duplicate lanes platforms (sonic-net#2343) [jingwenxie] * 8d20771 2022-09-15 | Vnet_route_check Vxlan tunnel route update. (sonic-net#2281) [siqbal1986] swss: * 88371f7 2022-09-21 | [ci] Only when test stage succeeded or succeededwithissues, PR run Gcov (sonic-net#2460) (HEAD -> 202205) [Liu Shilong] * c11dbd7 2022-09-15 | [QoS] Enforce drop probability only for colors whose WRED are enabled (sonic-net#2422) [Stephen Sun] sairedis: * 80928dd 2022-09-06 | [lgtm] Add uuid library (sonic-net#1119) (HEAD -> 202205, github/202205) [Kamil Cudnik] * c147dd0 2022-09-16 | [202205][vslib]: Add SAI_PORT_ATTR_OPER_SPEED get sonic-net#1123 [Ze Gan] platform-daemon: * 9cf8adf 2022-09-21 | [ycabled] add notification for gRPC connection state transitions to IDLE/TRANSIENT_FAILURE (sonic-net#295) (HEAD -> 202205) [vdahiya12] * 1e07ae3 2022-09-20 | Use get() to fetch default value from dictionary for port admin_status sonic-net#286 [anamehra] * 157f483 2022-09-15 | [Xcvrd] Soak duplicate events and process only updated interested events (sonic-net#285) [Prince George] Signed-off-by: Ying Xie <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
No longer test deprecated
get_serial_number()methods of Chassis and Module classesType of change
Approach
What is the motivation for this PR?
The
get_serial_number()methods are redundant and are being removed in sonic-net/sonic-platform-common#130How did you do it?
With the backspace key ;)
How did you verify/test it?
Ensure all remaining tests run correctly, and that the remaining "get_serial()" methods still get tested.
Any platform specific information?
No