Added two test cases of LAG testing (on t1-lag topology)#129
Closed
antonpatenko wants to merge 6 commits intosonic-net:masterfrom
Closed
Added two test cases of LAG testing (on t1-lag topology)#129antonpatenko wants to merge 6 commits intosonic-net:masterfrom
antonpatenko wants to merge 6 commits intosonic-net:masterfrom
Conversation
* VM LAG members traffic testing
* LACP rate verifying on VMs and DUT
stcheng
reviewed
Mar 15, 2017
| #--------------------------------------------------------- | ||
|
|
||
| # --- TEST FIRST LAG MEMBER --- | ||
| - block: |
Contributor
There was a problem hiding this comment.
this test assumes that each lag has two members, need to check if the test bed type is t1-lag or not before running the test.
Contributor
Author
There was a problem hiding this comment.
You mean automatic topology type checking performed by the test itself?
Contributor
There was a problem hiding this comment.
i wonder about it, or if we pass the testbed type as an extra argument and just check the argument's value?
Contributor
Author
There was a problem hiding this comment.
Well, I can make test checking the topology type, but I'm not sure it makes sense. Test assumes, that the user (who runs this test) guarantees that topology type is T1-LAG. But I can change that approach if we really need that.
|
i dont think we should.
lag test should run only on the relevant topology. you should not run it on non lag topology
Best regards,
Liat Grozovik +972-54-923-7674
Sent from my Samsung Galaxy smartphone.
-------- Original message --------
From: antonpatenko <[email protected]>
Date: 3/15/17 17:56 (GMT+02:00)
To: Azure/sonic-mgmt <[email protected]>
Cc: Subscribed <[email protected]>
Subject: Re: [Azure/sonic-mgmt] Added two test cases of LAG testing (on t1-lag topology) (#129)
@antonpatenko commented on this pull request.
________________________________
In ansible/roles/test/tasks/lag_vm_ports_test.yml<#129 (comment)>:
+# 1.2) Verify all the traffic goes through another LAG member and no packets lost.
+#
+# @ params: login_creds - credentials for Arista VM
+# @ params: vm_name
+# @ params: lag_ip - LAG interface IP address
+# @ params: lag_member_0 - First LAG member on VM
+# @ params: lag_member_1 - Second LAG member on VM
+# @ params: iface_behind_lag_member_0 - PTF docker iface, connected to LAG VM
+# @ params: iface_behind_lag_member_1 - PTF docker iface, connected to LAG VM
+# @ params: not_behind_lag_iface - PTF docker interface that is connected to non-LAG VM (meaning eth31)
+# @ params: vm_ip - VM mgmt IP; taken from lag_link_flap_vars.yml
+# @ params: num_of_pkts - number of packets to send while PTF test.
+#---------------------------------------------------------
+
+ # --- TEST FIRST LAG MEMBER ---
+- block:
Well, I can make test checking the topology type, but I'm not sure it makes sense. Test assumes, that the user (who runs this test) guarantees that topology type is T1-LAG. But I can change that approach if we really need that.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#129 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AQ8YX9z6N_QB-lb6wa-AbUJtli16e7fpks5rmAo-gaJpZM4MI7ze>.
|
nhe-NV
pushed a commit
to nhe-NV/sonic-mgmt
that referenced
this pull request
May 12, 2025
…ties (sonic-net#129) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: In daily operations, the switches may perform configuration reloading or BGP service restart to recover from transient failures. We need to add test cases to verify that SRv6 functionalities work correctly after the recovery. Fixes # (issue) ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [x] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202012 - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [x] 202412 ### Approach #### What is the motivation for this PR? #### How did you do it? #### How did you verify/test it? #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
[202012][sonic-linkmgrd] submodule udpate ddbd792 Jing Zhang Tue Sep 13 10:34:32 2022 -0700 [active-standby] update warmboot reconciliation logic (sonic-net#129) sign-off: Jing Zhang [email protected]
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Update sonic-restapi submodule for the following commits: 86543d0 - 2022-10-05 : Updates to route PATCH API (sonic-net#129) [Sumukha Tumkur Vani] a1af82c - 2022-09-21 : Install libyang to azure pipeline (sonic-net#128) [Hua Liu] 2007c4c - 2022-09-09 : Increase coverage threshold (sonic-net#126) [Sumukha Tumkur Vani]
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…e submodule head (sonic-net#12149) linkmgrd: * 05e5f4c 2022-09-20 | [Active-Active] flaky LinkmgrdBootupSequence unit tests (sonic-net#134) (HEAD -> 202205) [Jing Zhang] * 16fcadf 2022-09-13 | [active-standby] update warmboot reconciliation logic (sonic-net#129) [Jing Zhang] * e656a87 2022-09-09 | [active-active] shutdown link prober when starting as isolated (sonic-net#130) [Jing Zhang] uttilities: yinxi@ying-dev-vm-01:~/src/sonic-202205/src/sonic-utilities$ git hist github/202205..HEAD * 562188f 2022-09-14 | Use 'default' VRF when VRF name is not provided (sonic-net#2368) (HEAD -> 202205) [Sumukha Tumkur Vani] * c50ba4f 2022-09-20 | [minigraph] add option to specify golden path in load_minigraph (sonic-net#2350) [jingwenxie] * cec5ab2 2022-09-20 | [GCU]Remove GCU unique lane check for duplicate lanes platforms (sonic-net#2343) [jingwenxie] * 8d20771 2022-09-15 | Vnet_route_check Vxlan tunnel route update. (sonic-net#2281) [siqbal1986] swss: * 88371f7 2022-09-21 | [ci] Only when test stage succeeded or succeededwithissues, PR run Gcov (sonic-net#2460) (HEAD -> 202205) [Liu Shilong] * c11dbd7 2022-09-15 | [QoS] Enforce drop probability only for colors whose WRED are enabled (sonic-net#2422) [Stephen Sun] sairedis: * 80928dd 2022-09-06 | [lgtm] Add uuid library (sonic-net#1119) (HEAD -> 202205, github/202205) [Kamil Cudnik] * c147dd0 2022-09-16 | [202205][vslib]: Add SAI_PORT_ATTR_OPER_SPEED get sonic-net#1123 [Ze Gan] platform-daemon: * 9cf8adf 2022-09-21 | [ycabled] add notification for gRPC connection state transitions to IDLE/TRANSIENT_FAILURE (sonic-net#295) (HEAD -> 202205) [vdahiya12] * 1e07ae3 2022-09-20 | Use get() to fetch default value from dictionary for port admin_status sonic-net#286 [anamehra] * 157f483 2022-09-15 | [Xcvrd] Soak duplicate events and process only updated interested events (sonic-net#285) [Prince George] Signed-off-by: Ying Xie <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Update transceiver info DB key names (sonic-net#146) [Multiasic]: Provide namespace support for ipNetToMediaPhysAddress (sonic-net#129) [LLDP]: Modify OID index of LLDPRemTableUpdater MIB (sonic-net#155) [Namespace]: Simplify sync_d functions to use higher order (sonic-net#154) [Namespace]: Fix interface counters in RFC 1213 (sonic-net#145) Signed-off-by: Abhishek Dosi <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Update sonic-py-swsssdk submodule pointer to include the following: d3584fc Remove LOGLEVEL DB since is no longer used (sonic-net#129) Signed-off-by: dprital <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Why I did it [Submodule][202211] Advance sonic-restapi pointer The branch 202012 has already updated to commit 47e4b53. 4f6f979 Fix the redis security issue CVE-2023-28858 and CVE-2023-28859 (sonic-net#139) 47e4b53 Fix adv_pfx len for ipv6 (sonic-net#135) 44121be Support ipv6 prefix lenght greater than 64 and check for adv_prefix (sonic-net#134) 99c467d Add API support for adv prefix and custom monitoring (sonic-net#133) 347684a Use github code scanning instead of LGTM (sonic-net#132) 86543d0 Updates to route PATCH API (sonic-net#129) a1af82c Install libyang to azure pipeline (sonic-net#128) 2007c4c Increase coverage threshold (sonic-net#126) Work item tracking Microsoft ADO (number only): 17705422 How I did it How to verify it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: there is also an issue with SSH connection to VMs, so sometimes, when running cisco scripts, the test can hang.
Full LAG test plan is available here:
https://github.com/Azure/SONiC/wiki/LAG-test-plan