Skip to content

[vxlan_decap] Fix test issue on bonding_masters file#2200

Merged
daall merged 1 commit intosonic-net:masterfrom
OlaOliynyk:vxlan_decap_bonding
Sep 14, 2020
Merged

[vxlan_decap] Fix test issue on bonding_masters file#2200
daall merged 1 commit intosonic-net:masterfrom
OlaOliynyk:vxlan_decap_bonding

Conversation

@OlaOliynyk
Copy link
Contributor

@OlaOliynyk OlaOliynyk commented Sep 10, 2020

Description of PR

The PR fixes vxlan_decap test case error on bonding_master file.

Summary:
Fixes # (issue)
Test case vxlan_decap errors when test tries to take address with opening the file bonding_masters.
The error occurs: Not a directory

Test was run on SONiC:
SONiC Software Version: SONiC.HEAD.765-dirty-20200907.114217
Distribution: Debian 10.5
Kernel: 4.19.0-9-2-amd64
Build commit: 8d285b4

Logs from testrun:
Traceback: File \"ptftests/vxlan-decap.py\", line 236, in setUp self.ptf_mac_addrs = self.readMacs() File \"ptftests/vxlan-decap.py\", line 108, in readMacs with open('/sys/class/net/%s/address' % intf) as fp: Error: [Errno 20] Not a directory: '/sys/class/net/bonding_masters/address

Type of change

Added verification if the element is a directory before opening.
This approach allows to omit file if any in /sys/class/net directory exists.

  • [+] Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@daall
Copy link
Contributor

daall commented Sep 11, 2020

@OlaOliynyk can you add the Signed-off-by: ... line to the PR description so we can include it in the merge commit, please? :)

@OlaOliynyk
Copy link
Contributor Author

Signed-off. Done.

@daall daall merged commit 04cc877 into sonic-net:master Sep 14, 2020
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…ic-net#11223)

swss:
* 43b9f06 2022-06-23 | [ACL] Support stage particular match fields (sonic-net#2341) (HEAD -> 202205) [bingwang-ms]
* c7f1add 2022-06-22 | Fix qos map test in vs test (sonic-net#2343) [bingwang-ms]
* 0549f3c 2022-06-22 | Fix for "orchagent crashed when trying to delete fdb static entry with swssconfig sonic-net#11046" (sonic-net#2332) [anilkpan]

utilities:
* 785508d 2022-05-25 | [GCU] Handling type1 lists (sonic-net#2171) (HEAD -> 202205) [Mohamed Ghoneim]
* 56c2c6b 2022-06-22 | [config reload] Fixing config reload when timer based services are disabled (sonic-net#2200) (sonic-net#2226) (HEAD -> 202205, github/202205) [Sudharsan Dhamal Gopalarathnam]
* 600979e 2022-06-16 | Fix header for the output table following 'show ipv6 interface' command (sonic-net#2219) [Dror Prital]

sairedis:
* 14fba45 2022-06-13 | [vslib]: Fixbug in cleanup MACsec device (sonic-net#1059) (HEAD -> 202205) [Ze Gan]
* ac6e7ad 2022-04-29 | [vslib]: Update packet number of MACsec SA at runtime (sonic-net#1007) [Ze Gan]

platform-daemons:
* 6ffec22 2022-06-22 | [ycabled] Fix the init values for active-active ports (sonic-net#266) (HEAD -> 202205) [vdahiya12]

Signed-off-by: Ying Xie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants