[pytest conn graph] leverage the conn_graph_facts.py lookup capability#2226
Merged
yxieca merged 1 commit intosonic-net:masterfrom Sep 18, 2020
Merged
[pytest conn graph] leverage the conn_graph_facts.py lookup capability#2226yxieca merged 1 commit intosonic-net:masterfrom
yxieca merged 1 commit intosonic-net:masterfrom
Conversation
|
This pull request introduces 1 alert when merging 2fc797ea4daf581e8c5b0985c40069b8b8c7907b into e01b6be - view on LGTM.com new alerts:
|
Collaborator
Author
neethajohn
approved these changes
Sep 17, 2020
ansible/library/conn_graph_facts.py
Outdated
Getting ready to deprecte the inventory graph map. Introduce code to leverage the conn_graph_facts.py lookup capability. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Collaborator
Author
|
retest vsimage please |
1 similar comment
Collaborator
Author
|
retest vsimage please |
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…ic-net#11223) swss: * 43b9f06 2022-06-23 | [ACL] Support stage particular match fields (sonic-net#2341) (HEAD -> 202205) [bingwang-ms] * c7f1add 2022-06-22 | Fix qos map test in vs test (sonic-net#2343) [bingwang-ms] * 0549f3c 2022-06-22 | Fix for "orchagent crashed when trying to delete fdb static entry with swssconfig sonic-net#11046" (sonic-net#2332) [anilkpan] utilities: * 785508d 2022-05-25 | [GCU] Handling type1 lists (sonic-net#2171) (HEAD -> 202205) [Mohamed Ghoneim] * 56c2c6b 2022-06-22 | [config reload] Fixing config reload when timer based services are disabled (sonic-net#2200) (sonic-net#2226) (HEAD -> 202205, github/202205) [Sudharsan Dhamal Gopalarathnam] * 600979e 2022-06-16 | Fix header for the output table following 'show ipv6 interface' command (sonic-net#2219) [Dror Prital] sairedis: * 14fba45 2022-06-13 | [vslib]: Fixbug in cleanup MACsec device (sonic-net#1059) (HEAD -> 202205) [Ze Gan] * ac6e7ad 2022-04-29 | [vslib]: Update packet number of MACsec SA at runtime (sonic-net#1007) [Ze Gan] platform-daemons: * 6ffec22 2022-06-22 | [ycabled] Fix the init values for active-active ports (sonic-net#266) (HEAD -> 202205) [vdahiya12] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
fc29641 [pbh] [aclorch] Fixed a bug causes by updating the flow-counter value for the PBH rule (sonic-net#2226) 6c38ef7 [QoS] Resolve an issue in the sequence where a referenced object removed and then the referencing object deleting and then re-adding (sonic-net#2210)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
Having both inventory graph map and graph file look up is redundant. Prefer to use a common lookup in conn_graph_facts.py which works for both ansible and pytest.
How did you do it?
Getting ready to deprecte the inventory graph map. Introduce code to leverage the conn_graph_facts.py lookup capability.
Signed-off-by: Ying Xie ying.xie@microsoft.com
How did you verify/test it?
run test with inventory map file in place to test current method works. Then remove the map file and verify that conn_graph_facts lookup has been properly hooked up.
test_announce_routes.py::test_announce_routes PASSED