[vnet/crm]: Add CRM test case for bitmap VNET resources#1123
Merged
prsunny merged 2 commits intosonic-net:masterfrom Nov 1, 2019
Merged
[vnet/crm]: Add CRM test case for bitmap VNET resources#1123prsunny merged 2 commits intosonic-net:masterfrom
prsunny merged 2 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Volodymyr Samotiy <[email protected]>
prsunny
reviewed
Oct 18, 2019
| shell: grep "Vlan" /tmp/vnet.intf.json | wc -l | ||
| register: out | ||
| - set_fact: | ||
| ipv4_route_num: "{{ out.stdout_lines[0] }}" |
Contributor
There was a problem hiding this comment.
Where do we account for the actual routes added via vnet.route.json ?
Contributor
Author
There was a problem hiding this comment.
All routes should be added correctly at this stage since if something failed at the "apply" stage then playbook would fail before this and we never get here. So if we at this step that means all config was applied correctly and this value represents actual number of routes.
Contributor
There was a problem hiding this comment.
Can you please add a comment here that it only considers local routes for CRM
| config: True | ||
| cleanup: False | ||
|
|
||
| - set_fact: cfg_removed=False |
Contributor
There was a problem hiding this comment.
What is the purpose of this variable?
Contributor
Author
There was a problem hiding this comment.
It is used to check whether config is removed or not, so in cleanup section we can:
- perform cleanup if for example config is already applied and playbook failed before "remove" logic
- don't perform cleanup in case playbook passed which means that config was already removed as part of test logic
* Fix review comment Signed-off-by: Volodymyr Samotiy <[email protected]>
prsunny
approved these changes
Nov 1, 2019
prsunny
reviewed
Dec 4, 2019
|
|
||
| - name: Run test case "CRM VNET resources" | ||
| include: roles/test/tasks/crm/crm_test_vnet_bitmap.yml | ||
| when: testbed_type == "t0" |
Contributor
There was a problem hiding this comment.
This may need to be checked for platform
yvolynets-mlnx
pushed a commit
to yvolynets-mlnx/sonic-mgmt
that referenced
this pull request
Dec 13, 2019
* [vnet/crm]: Add CRM test case for bitmap VNET resources
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…e submodule head (sonic-net#12149) linkmgrd: * 05e5f4c 2022-09-20 | [Active-Active] flaky LinkmgrdBootupSequence unit tests (sonic-net#134) (HEAD -> 202205) [Jing Zhang] * 16fcadf 2022-09-13 | [active-standby] update warmboot reconciliation logic (sonic-net#129) [Jing Zhang] * e656a87 2022-09-09 | [active-active] shutdown link prober when starting as isolated (sonic-net#130) [Jing Zhang] uttilities: yinxi@ying-dev-vm-01:~/src/sonic-202205/src/sonic-utilities$ git hist github/202205..HEAD * 562188f 2022-09-14 | Use 'default' VRF when VRF name is not provided (sonic-net#2368) (HEAD -> 202205) [Sumukha Tumkur Vani] * c50ba4f 2022-09-20 | [minigraph] add option to specify golden path in load_minigraph (sonic-net#2350) [jingwenxie] * cec5ab2 2022-09-20 | [GCU]Remove GCU unique lane check for duplicate lanes platforms (sonic-net#2343) [jingwenxie] * 8d20771 2022-09-15 | Vnet_route_check Vxlan tunnel route update. (sonic-net#2281) [siqbal1986] swss: * 88371f7 2022-09-21 | [ci] Only when test stage succeeded or succeededwithissues, PR run Gcov (sonic-net#2460) (HEAD -> 202205) [Liu Shilong] * c11dbd7 2022-09-15 | [QoS] Enforce drop probability only for colors whose WRED are enabled (sonic-net#2422) [Stephen Sun] sairedis: * 80928dd 2022-09-06 | [lgtm] Add uuid library (sonic-net#1119) (HEAD -> 202205, github/202205) [Kamil Cudnik] * c147dd0 2022-09-16 | [202205][vslib]: Add SAI_PORT_ATTR_OPER_SPEED get sonic-net#1123 [Ze Gan] platform-daemon: * 9cf8adf 2022-09-21 | [ycabled] add notification for gRPC connection state transitions to IDLE/TRANSIENT_FAILURE (sonic-net#295) (HEAD -> 202205) [vdahiya12] * 1e07ae3 2022-09-20 | Use get() to fetch default value from dictionary for port admin_status sonic-net#286 [anamehra] * 157f483 2022-09-15 | [Xcvrd] Soak duplicate events and process only updated interested events (sonic-net#285) [Prince George] Signed-off-by: Ying Xie <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Fix load minigraph on 201911 branch. (sonic-net#1124) Fixed config load_minigrpah not working for Multi-asic platfroms. (sonic-net#1123) Signed-off-by: Abhishek Dosi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Volodymyr Samotiy [email protected]
Description of PR
Summary:
Add CRM test case for bitmap VNET resources
Type of change
Approach
How did you do it?
Added new CRM test case for bitmap VNET resources
How did you verify/test it?
Ran the test and verified it passed
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
T0
Documentation
N/A