[pytest] Relocate Session Level Fixtures To Test Files#1795
Merged
tahmed-dev merged 1 commit intosonic-net:masterfrom Jun 23, 2020
Merged
Conversation
Commit b0237f1 introduced session level fixtures, however indirect import of those fixtures is not being respected. Relocation of fixture import to pytest test files solves this issue. signed-off-by: Tamer Ahmed <[email protected]>
|
This pull request introduces 8 alerts and fixes 8 when merging bcc3dfa into eefb131 - view on LGTM.com new alerts:
fixed alerts:
|
daall
approved these changes
Jun 22, 2020
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
* d03ba4f [202012] [portstat, intfstat] added rates and utilization (sonic-net#1812) * 499ad3f [config reload] Fix config reload failure due to sonic.target job cancellation (sonic-net#1814) * 96d658c [202012][sonic installer] Add swap setup support (sonic-net#1815) * a9c6970 platform pre-check for reboot in 202012 branch (sonic-net#1788) * 0e0478b Unify the number format in the ourput of portstat and pfcstat in all cases (sonic-net#1795) * 2d1e00e [ecnconfig] Fix exception seen during display and add unit tests (#1784) (sonic-net#1789) Signed-off-by: Volodymyr Samotiy <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Commit b0237f1 introduced session level fixtures, however indirect
import of those fixtures is not being respected. Relocation of
fixture import to pytest test files solves this issue.
signed-off-by: Tamer Ahmed [email protected]
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
Fixing failures when running test case with indirect import of session level fixture
How did you do it?
Relocate import to test files
How did you verify/test it?
ran with and without this issue test_qos_sai. Issue is resolved with this fix
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation