Merged
Conversation
|
This pull request introduces 11 alerts when merging 3214e86 into ca24f81 - view on LGTM.com new alerts:
|
|
This pull request introduces 11 alerts when merging 87039c7 into 9cd2589 - view on LGTM.com new alerts:
|
lguohan
reviewed
Aug 18, 2020
… to send encapped packets in test
abdosi
reviewed
Oct 8, 2020
abdosi
approved these changes
Oct 16, 2020
Contributor
|
@anish-n minigraph based test cases will be added later |
Contributor
Author
Yes, will raise a separate PR to include minigraph based test case, this is because the test case for minigraph is expected to have a good deal of minigraph-related distinct changes and can be made into a separate PR. Also the minigraph changes are still open in PR form, so this would raise a dependency, so good to merge this now if possible, and have a 2nd PR to deal with the minigraph side. |
nazariig
requested changes
Oct 19, 2020
nazariig
reviewed
Oct 19, 2020
nazariig
reviewed
Oct 19, 2020
nazariig
reviewed
Oct 19, 2020
nazariig
reviewed
Oct 19, 2020
nazariig
reviewed
Oct 19, 2020
nazariig
reviewed
Oct 19, 2020
nazariig
requested changes
Oct 19, 2020
nazariig
reviewed
Oct 19, 2020
Contributor
|
@nazariig Can you approve this ? |
nazariig
approved these changes
Oct 22, 2020
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
* d03ba4f [202012] [portstat, intfstat] added rates and utilization (sonic-net#1812) * 499ad3f [config reload] Fix config reload failure due to sonic.target job cancellation (sonic-net#1814) * 96d658c [202012][sonic installer] Add swap setup support (sonic-net#1815) * a9c6970 platform pre-check for reboot in 202012 branch (sonic-net#1788) * 0e0478b Unify the number format in the ourput of portstat and pfcstat in all cases (sonic-net#1795) * 2d1e00e [ecnconfig] Fix exception seen during display and add unit tests (#1784) (sonic-net#1789) Signed-off-by: Volodymyr Samotiy <volodymyrs@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
##Description of PR
This PR contains the changes for Fine Grained ECMP test.
It is based on the following specs:
https://github.com/Azure/SONiC/blob/master/doc/ecmp/fine_grained_next_hop_hld.md
https://github.com/Azure/SONiC/pull/623/files
Summary:
Type of change
Approach
This test creates Fine Grained ECMP objects on the DUT, and validates data plane for fine grained ecmp via PTF tests.
What is the motivation for this PR?
https://github.com/Azure/SONiC/blob/master/doc/ecmp/fine_grained_next_hop_hld.md
How did you do it?
Initially create a route with x next-hops, send 1000 flows, change the set of next-hops for all the possible fine grained ecmp scenarios and validate that the 1000 flows adjust as expected in the scenario
How did you verify/test it?
By running the PTF test
Any platform specific information?
Applicable to all platforms which support fine grained ecmp
Supported testbed topology if it's a new test case?
T0
Documentation
https://github.com/Azure/SONiC/blob/master/doc/ecmp/fine_grained_next_hop_hld.md