Add min_distance_to_obstacle parameter to RPP #4543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doisyg
force-pushed
the
rpp_min_distance_to_obstacle
branch
from
1714665 to
c469e19
Compare
nav2_regulated_pure_pursuit_controller/src/collision_checker.cpp
Outdated
Show resolved
Hide resolved
|
@doisyg what's the story here? |
doisyg
force-pushed
the
rpp_min_distance_to_obstacle
branch
from
c469e19 to
40c6abf
Compare
added 3 commits
June 10, 2025 18:50
Signed-off-by: Guillaume Doisy <[email protected]>
Signed-off-by: Guillaume Doisy <[email protected]>
Signed-off-by: Guillaume Doisy <[email protected]>
doisyg
force-pushed
the
rpp_min_distance_to_obstacle
branch
from
40c6abf to
4abc648
Compare
|
@doisyg, your PR has failed to build. Please check CI outputs and resolve issues. |
nav2_regulated_pure_pursuit_controller/src/collision_checker.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Guillaume Doisy <[email protected]>
|
@doisyg, your PR has failed to build. Please check CI outputs and resolve issues. |
SteveMacenski
approved these changes
Jun 10, 2025
stevedanomodolor
pushed a commit
to stevedanomodolor/navigation2
that referenced
this pull request
Jun 11, 2025
* min_distance_to_obstacle Signed-off-by: Guillaume Doisy <[email protected]> * suggestion to time base and combine Signed-off-by: Guillaume Doisy <[email protected]> * typo Signed-off-by: Guillaume Doisy <[email protected]> * use min_approach_linear_velocity Signed-off-by: Guillaume Doisy <[email protected]> --------- Signed-off-by: Guillaume Doisy <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]>
stevedanomodolor
pushed a commit
to stevedanomodolor/navigation2
that referenced
this pull request
Jun 11, 2025
* min_distance_to_obstacle Signed-off-by: Guillaume Doisy <[email protected]> * suggestion to time base and combine Signed-off-by: Guillaume Doisy <[email protected]> * typo Signed-off-by: Guillaume Doisy <[email protected]> * use min_approach_linear_velocity Signed-off-by: Guillaume Doisy <[email protected]> --------- Signed-off-by: Guillaume Doisy <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]>
SteveMacenski
added a commit
that referenced
this pull request
Jun 15, 2025
* cherry pick Signed-off-by: Stevedan Omodolor <[email protected]> * cherry pick 6a74ba6 Signed-off-by: Stevedan Omodolor <[email protected]> * cherrpy pick Signed-off-by: Stevedan Omodolor <[email protected]> * include x11 forwarding Signed-off-by: Stevedan Omodolor <[email protected]> * kind of working version Signed-off-by: Stevedan Omodolor <[email protected]> * cleanup Signed-off-by: Stevedan Omodolor <[email protected]> * formatting Signed-off-by: Stevedan Omodolor <[email protected]> * minor format change Signed-off-by: Stevedan Omodolor <[email protected]> * change naming Signed-off-by: Stevedan Omodolor <[email protected]> * minor changes Signed-off-by: Stevedan Omodolor <[email protected]> * working with new changes Signed-off-by: Stevedan Omodolor <[email protected]> * Revert "Fix Ci from key signing (#5220)" (#5237) * Revert "Fix Ci from key signing (#5220)" This reverts the changes to the Dockerfile done in 1345c22. Signed-off-by: Nils-Christian Iseke <[email protected]> * Update Cache Version Signed-off-by: Nils-Christian Iseke <[email protected]> --------- Signed-off-by: Nils-Christian Iseke <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * Revert back Signed-off-by: Stevedan Omodolor <[email protected]> * enable_groot_monitoring_ false (#5246) Signed-off-by: Guillaume Doisy <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * Updating readme table for kilted release (#5249) * updating readme table for kilted release Signed-off-by: Steve Macenski <[email protected]> * Updating table lint Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: Steve Macenski <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * Add min_distance_to_obstacle parameter to RPP (#4543) * min_distance_to_obstacle Signed-off-by: Guillaume Doisy <[email protected]> * suggestion to time base and combine Signed-off-by: Guillaume Doisy <[email protected]> * typo Signed-off-by: Guillaume Doisy <[email protected]> * use min_approach_linear_velocity Signed-off-by: Guillaume Doisy <[email protected]> --------- Signed-off-by: Guillaume Doisy <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * Fixing builds for message filters API change while retaining Jazzy, Kilted, and Rolling support (#5251) * Update amcl_node.hpp Signed-off-by: Steve Macenski <[email protected]> * Update amcl_node.cpp Signed-off-by: Steve Macenski <[email protected]> * Working for Kilted, Jazzy Signed-off-by: Steve Macenski <[email protected]> * Update amcl_node.cpp Signed-off-by: Steve Macenski <[email protected]> * Update amcl_node.cpp Signed-off-by: Steve Macenski <[email protected]> * Update amcl_node.cpp Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: Steve Macenski <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * Change max_cost default to 254 (#5256) Signed-off-by: Tony Najjar <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * linter Signed-off-by: Stevedan Omodolor <[email protected]> * remove const Signed-off-by: Stevedan Omodolor <[email protected]> * pass const pointer by value Signed-off-by: Stevedan Omodolor <[email protected]> * pass const pointer by value Signed-off-by: Stevedan Omodolor <[email protected]> * remove unused param Signed-off-by: Stevedan Omodolor <[email protected]> --------- Signed-off-by: Stevedan Omodolor <[email protected]> Signed-off-by: Nils-Christian Iseke <[email protected]> Signed-off-by: Guillaume Doisy <[email protected]> Signed-off-by: Steve Macenski <[email protected]> Signed-off-by: Tony Najjar <[email protected]> Co-authored-by: Steve Macenski <[email protected]> Co-authored-by: Nils-Christian Iseke <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> Co-authored-by: Tony Najjar <[email protected]>
mergify bot
pushed a commit
that referenced
this pull request
Jun 15, 2025
* cherry pick Signed-off-by: Stevedan Omodolor <[email protected]> * cherry pick 6a74ba6 Signed-off-by: Stevedan Omodolor <[email protected]> * cherrpy pick Signed-off-by: Stevedan Omodolor <[email protected]> * include x11 forwarding Signed-off-by: Stevedan Omodolor <[email protected]> * kind of working version Signed-off-by: Stevedan Omodolor <[email protected]> * cleanup Signed-off-by: Stevedan Omodolor <[email protected]> * formatting Signed-off-by: Stevedan Omodolor <[email protected]> * minor format change Signed-off-by: Stevedan Omodolor <[email protected]> * change naming Signed-off-by: Stevedan Omodolor <[email protected]> * minor changes Signed-off-by: Stevedan Omodolor <[email protected]> * working with new changes Signed-off-by: Stevedan Omodolor <[email protected]> * Revert "Fix Ci from key signing (#5220)" (#5237) * Revert "Fix Ci from key signing (#5220)" This reverts the changes to the Dockerfile done in 1345c22. Signed-off-by: Nils-Christian Iseke <[email protected]> * Update Cache Version Signed-off-by: Nils-Christian Iseke <[email protected]> --------- Signed-off-by: Nils-Christian Iseke <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * Revert back Signed-off-by: Stevedan Omodolor <[email protected]> * enable_groot_monitoring_ false (#5246) Signed-off-by: Guillaume Doisy <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * Updating readme table for kilted release (#5249) * updating readme table for kilted release Signed-off-by: Steve Macenski <[email protected]> * Updating table lint Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: Steve Macenski <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * Add min_distance_to_obstacle parameter to RPP (#4543) * min_distance_to_obstacle Signed-off-by: Guillaume Doisy <[email protected]> * suggestion to time base and combine Signed-off-by: Guillaume Doisy <[email protected]> * typo Signed-off-by: Guillaume Doisy <[email protected]> * use min_approach_linear_velocity Signed-off-by: Guillaume Doisy <[email protected]> --------- Signed-off-by: Guillaume Doisy <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * Fixing builds for message filters API change while retaining Jazzy, Kilted, and Rolling support (#5251) * Update amcl_node.hpp Signed-off-by: Steve Macenski <[email protected]> * Update amcl_node.cpp Signed-off-by: Steve Macenski <[email protected]> * Working for Kilted, Jazzy Signed-off-by: Steve Macenski <[email protected]> * Update amcl_node.cpp Signed-off-by: Steve Macenski <[email protected]> * Update amcl_node.cpp Signed-off-by: Steve Macenski <[email protected]> * Update amcl_node.cpp Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: Steve Macenski <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * Change max_cost default to 254 (#5256) Signed-off-by: Tony Najjar <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * linter Signed-off-by: Stevedan Omodolor <[email protected]> * remove const Signed-off-by: Stevedan Omodolor <[email protected]> * pass const pointer by value Signed-off-by: Stevedan Omodolor <[email protected]> * pass const pointer by value Signed-off-by: Stevedan Omodolor <[email protected]> * remove unused param Signed-off-by: Stevedan Omodolor <[email protected]> --------- Signed-off-by: Stevedan Omodolor <[email protected]> Signed-off-by: Nils-Christian Iseke <[email protected]> Signed-off-by: Guillaume Doisy <[email protected]> Signed-off-by: Steve Macenski <[email protected]> Signed-off-by: Tony Najjar <[email protected]> Co-authored-by: Steve Macenski <[email protected]> Co-authored-by: Nils-Christian Iseke <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> Co-authored-by: Tony Najjar <[email protected]> (cherry picked from commit afb9e7d)
SteveMacenski
added a commit
that referenced
this pull request
Jun 15, 2025
* cherry pick * cherry pick 6a74ba6 * cherrpy pick * include x11 forwarding * kind of working version * cleanup * formatting * minor format change * change naming * minor changes * working with new changes * Revert "Fix Ci from key signing (#5220)" (#5237) * Revert "Fix Ci from key signing (#5220)" This reverts the changes to the Dockerfile done in 1345c22. * Update Cache Version --------- * Revert back * enable_groot_monitoring_ false (#5246) * Updating readme table for kilted release (#5249) * updating readme table for kilted release * Updating table lint --------- * Add min_distance_to_obstacle parameter to RPP (#4543) * min_distance_to_obstacle * suggestion to time base and combine * typo * use min_approach_linear_velocity --------- * Fixing builds for message filters API change while retaining Jazzy, Kilted, and Rolling support (#5251) * Update amcl_node.hpp * Update amcl_node.cpp * Working for Kilted, Jazzy * Update amcl_node.cpp * Update amcl_node.cpp * Update amcl_node.cpp --------- * Change max_cost default to 254 (#5256) * linter * remove const * pass const pointer by value * pass const pointer by value * remove unused param --------- (cherry picked from commit afb9e7d) Signed-off-by: Stevedan Omodolor <[email protected]> Signed-off-by: Nils-Christian Iseke <[email protected]> Signed-off-by: Guillaume Doisy <[email protected]> Signed-off-by: Steve Macenski <[email protected]> Signed-off-by: Tony Najjar <[email protected]> Co-authored-by: Stevedan Ogochukwu Omodolor <[email protected]> Co-authored-by: Steve Macenski <[email protected]> Co-authored-by: Nils-Christian Iseke <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> Co-authored-by: Tony Najjar <[email protected]>
SteveMacenski
pushed a commit
that referenced
this pull request
Jun 17, 2025
* min_distance_to_obstacle Signed-off-by: Guillaume Doisy <[email protected]> * suggestion to time base and combine Signed-off-by: Guillaume Doisy <[email protected]> * typo Signed-off-by: Guillaume Doisy <[email protected]> * use min_approach_linear_velocity Signed-off-by: Guillaume Doisy <[email protected]> --------- Signed-off-by: Guillaume Doisy <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]>
SteveMacenski
added a commit
that referenced
this pull request
Jun 17, 2025
* cherry pick Signed-off-by: Stevedan Omodolor <[email protected]> * cherry pick 6a74ba6 Signed-off-by: Stevedan Omodolor <[email protected]> * cherrpy pick Signed-off-by: Stevedan Omodolor <[email protected]> * include x11 forwarding Signed-off-by: Stevedan Omodolor <[email protected]> * kind of working version Signed-off-by: Stevedan Omodolor <[email protected]> * cleanup Signed-off-by: Stevedan Omodolor <[email protected]> * formatting Signed-off-by: Stevedan Omodolor <[email protected]> * minor format change Signed-off-by: Stevedan Omodolor <[email protected]> * change naming Signed-off-by: Stevedan Omodolor <[email protected]> * minor changes Signed-off-by: Stevedan Omodolor <[email protected]> * working with new changes Signed-off-by: Stevedan Omodolor <[email protected]> * Revert "Fix Ci from key signing (#5220)" (#5237) * Revert "Fix Ci from key signing (#5220)" This reverts the changes to the Dockerfile done in 1345c22. Signed-off-by: Nils-Christian Iseke <[email protected]> * Update Cache Version Signed-off-by: Nils-Christian Iseke <[email protected]> --------- Signed-off-by: Nils-Christian Iseke <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * Revert back Signed-off-by: Stevedan Omodolor <[email protected]> * enable_groot_monitoring_ false (#5246) Signed-off-by: Guillaume Doisy <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * Updating readme table for kilted release (#5249) * updating readme table for kilted release Signed-off-by: Steve Macenski <[email protected]> * Updating table lint Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: Steve Macenski <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * Add min_distance_to_obstacle parameter to RPP (#4543) * min_distance_to_obstacle Signed-off-by: Guillaume Doisy <[email protected]> * suggestion to time base and combine Signed-off-by: Guillaume Doisy <[email protected]> * typo Signed-off-by: Guillaume Doisy <[email protected]> * use min_approach_linear_velocity Signed-off-by: Guillaume Doisy <[email protected]> --------- Signed-off-by: Guillaume Doisy <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * Fixing builds for message filters API change while retaining Jazzy, Kilted, and Rolling support (#5251) * Update amcl_node.hpp Signed-off-by: Steve Macenski <[email protected]> * Update amcl_node.cpp Signed-off-by: Steve Macenski <[email protected]> * Working for Kilted, Jazzy Signed-off-by: Steve Macenski <[email protected]> * Update amcl_node.cpp Signed-off-by: Steve Macenski <[email protected]> * Update amcl_node.cpp Signed-off-by: Steve Macenski <[email protected]> * Update amcl_node.cpp Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: Steve Macenski <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * Change max_cost default to 254 (#5256) Signed-off-by: Tony Najjar <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * linter Signed-off-by: Stevedan Omodolor <[email protected]> * remove const Signed-off-by: Stevedan Omodolor <[email protected]> * pass const pointer by value Signed-off-by: Stevedan Omodolor <[email protected]> * pass const pointer by value Signed-off-by: Stevedan Omodolor <[email protected]> * remove unused param Signed-off-by: Stevedan Omodolor <[email protected]> --------- Signed-off-by: Stevedan Omodolor <[email protected]> Signed-off-by: Nils-Christian Iseke <[email protected]> Signed-off-by: Guillaume Doisy <[email protected]> Signed-off-by: Steve Macenski <[email protected]> Signed-off-by: Tony Najjar <[email protected]> Co-authored-by: Steve Macenski <[email protected]> Co-authored-by: Nils-Christian Iseke <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> Co-authored-by: Tony Najjar <[email protected]>
SteveMacenski
added a commit
that referenced
this pull request
Jun 17, 2025
* Add speed filter zones to depot and warehouse maps. (#5146) * Added keepout prefix to keepout zone related params. Signed-off-by: Leander Stephen D'Souza <[email protected]> * Add namespace support for speed filter zones. Signed-off-by: Leander Stephen D'Souza <[email protected]> * Added speed filter zones to depot and warehouse maps. Signed-off-by: Leander Stephen D'Souza <[email protected]> * Added dedicated launch file for speed zone support. Signed-off-by: Leander Stephen D'Souza <[email protected]> * Updated rviz2 config to include speed zone filter. Signed-off-by: Leander Stephen D'Souza <[email protected]> * Preserve initial nature of costmap filters tests. Signed-off-by: Leander Stephen D'Souza <[email protected]> * Enable namespace for the speed limit topic. Signed-off-by: Leander Stephen D'Souza <[email protected]> * Update speed filter zones in depot and warehouse maps Signed-off-by: Leander Stephen D'Souza <[email protected]> * Readjust speed filter zones in depot and warehouse maps. Signed-off-by: Leander Stephen D'Souza <[email protected]> * Enable namespace support for speed limit topic. Signed-off-by: Leander Stephen D'Souza <[email protected]> * Reduced central speed zone in warehouse map. Signed-off-by: Leander Stephen D'Souza <[email protected]> --------- Signed-off-by: Leander Stephen D'Souza <[email protected]> * suppress rviz logging to warnings and above (#5163) * suppress rviz to warnings and above Signed-off-by: Steve Macenski <[email protected]> * Update nav2_bringup/launch/rviz_launch.py Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: Steve Macenski <[email protected]> * Adding Jazzy build job on Main PRs to automatically test Jazzy compatiblity long term (Kilted to come shortly) (#5164) * Adding jazzy testing job Signed-off-by: Steve Macenski <[email protected]> * on PR not push Signed-off-by: Steve Macenski <[email protected]> * move dir Signed-off-by: Steve Macenski <[email protected]> * more Signed-off-by: Steve Macenski <[email protected]> * moar Signed-off-by: Steve Macenski <[email protected]> * moar Signed-off-by: Steve Macenski <[email protected]> * more Signed-off-by: Steve Macenski <[email protected]> * fin Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: Steve Macenski <[email protected]> * Prevent MPPI controller from resetting speed limits upon goal execution. (#5165) Signed-off-by: Leander Stephen D'Souza <[email protected]> * Backward docking without sensors (#5153) * Merge remote-tracking branch 'jakub/backward-docking-without-sensors' into docking_backward Signed-off-by: Jakubach <[email protected]> Signed-off-by: Alberto Tudela <[email protected]> * Minor fixes and update controller test Signed-off-by: Alberto Tudela <[email protected]> * Add more tests Signed-off-by: Alberto Tudela <[email protected]> * Move backward_plugin param to plugin Signed-off-by: Alberto Tudela <[email protected]> * Fixed rotateToDock and tests Signed-off-by: Alberto Tudela <[email protected]> * Update readme Signed-off-by: Alberto Tudela <[email protected]> * Added rotate_to_dock_timeout Signed-off-by: Alberto Tudela <[email protected]> * Use angular acceleration te acelerate / decelerate Signed-off-by: Alberto Tudela <[email protected]> * Added mutex Signed-off-by: Alberto Tudela <[email protected]> * Fix exception Signed-off-by: Alberto Tudela <[email protected]> * Revert "Added mutex" This reverts commit 29ff010. Signed-off-by: Alberto Tudela <[email protected]> * Rename rotate_to_dock Signed-off-by: Alberto Tudela <[email protected]> * Rotate after undock and fixes Signed-off-by: Alberto Tudela <[email protected]> * Minor fixes Signed-off-by: Alberto Tudela <[email protected]> * Log after rotation Signed-off-by: Alberto Tudela <[email protected]> --------- Signed-off-by: Jakubach <[email protected]> Signed-off-by: Alberto Tudela <[email protected]> * Speed up CI builds for released distros (#5168) Signed-off-by: Steve Macenski <[email protected]> * Save 2 minutes in Main-Jazzy build times to align with other CI job lengths (#5169) * Save 2 minutes in Main-Jazzy build times to align with other CI job lengths Signed-off-by: Steve Macenski <[email protected]> * Update build_main_against_distros.yml Signed-off-by: Steve Macenski <[email protected]> * Update build_main_against_distros.yml Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: Steve Macenski <[email protected]> * Fixing docking server when already docked at the requeste ddock (#5171) Signed-off-by: Steve Macenski <[email protected]> * Update mergify.yml Signed-off-by: Steve Macenski <[email protected]> * fix MPPI goal critic inversion (#5088) (#5105) * fix MPPI goal critic inversion (#5088) Signed-off-by: brayanpa <[email protected]> * Support path inversion in all critics (#5088) Signed-off-by: brayanpa <[email protected]> * Fix code style issues and formatting Signed-off-by: brayanpa <[email protected]> * Remove trailing whitespaces Signed-off-by: brayanpa <[email protected]> * Fix goalAngleCritic tests Signed-off-by: brayanpa <[email protected]> * Normalize code formatting Signed-off-by: brayanpa <[email protected]> * Add getLastPathPose test Signed-off-by: brayanpa <[email protected]> * Abstract getCriticGoal in nav2_mppi critics Signed-off-by: brayanpa <[email protected]> * Fix whitespace issues Signed-off-by: brayanpa <[email protected]> * Fix getCriticGoal test Signed-off-by: brayanpa <[email protected]> --------- Signed-off-by: brayanpa <[email protected]> Signed-off-by: Brayan Pallares <[email protected]> * Add stateful to regulated pure pursuit controller (#5167) * add_stateful_to_regulated_pure_pursuit_controller Signed-off-by: Jad haj mustafa <[email protected]> * fix naming Signed-off-by: Jad haj mustafa <[email protected]> * fix naming left over Signed-off-by: Jad haj mustafa <[email protected]> * resolve comments Signed-off-by: Jad haj mustafa <[email protected]> * typo Signed-off-by: Jad haj mustafa <[email protected]> * add unit test for both cases stateful and not stateful Signed-off-by: Jad haj mustafa <[email protected]> --------- Signed-off-by: Jad haj mustafa <[email protected]> * tf2 uses hpp headers in rolling (and is backported) (#5180) Signed-off-by: Tim Clephas <[email protected]> * added config for laserscan in lb-sim (#5174) * added config for laserscan in lb-sim Signed-off-by: RamanaBotta <[email protected]> * fixing ament_flake8 errors Signed-off-by: RamanaBotta <[email protected]> * review: use_inf is default:true and added parameters on readme #4992 Signed-off-by: RamanaBotta <[email protected]> * refactor: meaningfull value for scan_angle_increment Signed-off-by: RamanaBotta <[email protected]> --------- Signed-off-by: RamanaBotta <[email protected]> Co-authored-by: RamanaBotta <[email protected]> * Publish planned footprints after smoothing (#5155) * Publish planned footprints after smoothing Signed-off-by: Tony Najjar <[email protected]> * Revert "Publish planned footprints after smoothing" This reverts commit c9b349a. * Add smoothed footprints publishing Signed-off-by: Tony Najjar <[email protected]> * fix formatting Signed-off-by: Tony Najjar <[email protected]> * Fix indentation for publisher creation in SmacPlannerHybrid and SmacPlannerLattice Signed-off-by: Tony Najjar <[email protected]> * address PR comments Signed-off-by: Tony Najjar <[email protected]> * fixes Signed-off-by: Tony Najjar <[email protected]> * fix build error Signed-off-by: Tony Najjar <[email protected]> --------- Signed-off-by: Tony Najjar <[email protected]> * fixing deprecation warning (#5182) Signed-off-by: Steve Macenski <[email protected]> * Removing action server timeout duration after fixes to ROS 2, Reverts 3787 (#5183) * Removing action server timeout duration after fixes to ROS 2 Signed-off-by: Steve Macenski <[email protected]> * fix build warning Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: Steve Macenski <[email protected]> * action timeout in BT client edits error code and string (#5184) Signed-off-by: Steve Macenski <[email protected]> * Dynamic Parameters Only validating params that are part of the plugin (#5106) * Only validating params that are part of the plugin Signed-off-by: Nils-ChristianIseke <[email protected]> * review Signed-off-by: Nils-Christian Iseke <[email protected]> * Refactoring type with param_type and name with param_name to get more consistency. Signed-off-by: Nils-Christian Iseke <[email protected]> * Check if plugin_name is part of param_name Signed-off-by: Nils-Christian Iseke <[email protected]> * Check if param_name contains name_ Signed-off-by: Nils-Christian Iseke <[email protected]> * Uncrustify Signed-off-by: Nils-Christian Iseke <[email protected]> * Add check param name in dynamic parameter upate. Signed-off-by: Nils-Christian Iseke <[email protected]> * fix Signed-off-by: Nils-Christian Iseke <[email protected]> * Merge remote-tracking branch 'upstream/main' into FixNamespaceCheck Signed-off-by: Nils-Christian Iseke <[email protected]> * Remove controller_frequency as dynamic parameter Signed-off-by: Nils-Christian Iseke <[email protected]> * Revert "Merge remote-tracking branch 'origin/main' into FixNamespaceCheck" This reverts commit 7632e41, reversing changes made to 19afc9e. Signed-off-by: Nils-Christian Iseke <[email protected]> * Merge remote-tracking branch 'upstream/main' into FixNamespaceCheck Signed-off-by: Nils-Christian Iseke <[email protected]> * Fix merge errors. Signed-off-by: Nils-Christian Iseke <[email protected]> * Add missing check to simple_goal_checker Signed-off-by: Nils-Christian Iseke <[email protected]> * Handel param_name resolution for smac_planner_hybrid Signed-off-by: Nils-Christian Iseke <[email protected]> * fix typo Signed-off-by: Nils-Christian Iseke <[email protected]> * uncrustify Signed-off-by: Nils-Christian Iseke <[email protected]> * fix Signed-off-by: Nils-Christian Iseke <[email protected]> * Revert "uncrustify" This reverts commit 43749c2. Signed-off-by: Nils-Christian Iseke <[email protected]> * uncrustify Signed-off-by: Nils-Christian Iseke <[email protected]> * Revert "uncrustify" This reverts commit e18f704. Signed-off-by: Nils-Christian Iseke <[email protected]> * Revert "fix" This reverts commit a0a7892. Signed-off-by: Nils-Christian Iseke <[email protected]> * Merge remote-tracking branch 'upstream/main' into FixNamespaceCheck Signed-off-by: Nils-Christian Iseke <[email protected]> * MPPI Check Namespace. Signed-off-by: Nils-Christian Iseke <[email protected]> * fixing parameter_handler tests. Signed-off-by: Nils-Christian Iseke <[email protected]> * Fix optimizer Signed-off-by: Nils-Christian Iseke <[email protected]> * Fix indentation Signed-off-by: Nils-Christian Iseke <[email protected]> * mppi param handler only execute post_callbacks if a param of mppi was updated. Signed-off-by: Nils-Christian Iseke <[email protected]> * Update nav2_rotation_shim_controller.hpp Signed-off-by: Nils-Christian Iseke <[email protected]> * Review Signed-off-by: Nils-Christian Iseke <[email protected]> * Update nav2_mppi_controller/src/parameters_handler.cpp Signed-off-by: Steve Macenski <[email protected]> * Update nav2_mppi_controller/src/parameters_handler.cpp Signed-off-by: Steve Macenski <[email protected]> * Update nav2_mppi_controller/src/parameters_handler.cpp Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: Nils-ChristianIseke <[email protected]> Signed-off-by: Nils-Christian Iseke <[email protected]> Signed-off-by: Nils-Christian Iseke <[email protected]> Signed-off-by: Steve Macenski <[email protected]> Co-authored-by: Steve Macenski <[email protected]> * Increase Readability of testing. (#5190) Signed-off-by: Nils-Christian Iseke <[email protected]> * Add value rewrites to RewrittenYaml (#5191) * Added context manager for safe file closing and prevent warnings. Signed-off-by: Leander Stephen D'Souza <[email protected]> * Implement value_rewrites to ReWrittenYaml. Signed-off-by: Leander Stephen D'Souza <[email protected]> * Use placeholders for costmap filters using the new value rewrite feature. Signed-off-by: Leander Stephen D'Souza <[email protected]> * Enable system tests to use value rewrites. Signed-off-by: Leander Stephen D'Souza <[email protected]> * Define remappings for costmap filters instead of inline substitution. Signed-off-by: Leander Stephen D'Souza <[email protected]> --------- Signed-off-by: Leander Stephen D'Souza <[email protected]> * Updates for Kilted Branch off (#5199) * Adding kilted build to main branch workflow Signed-off-by: Steve Macenski <[email protected]> * Updating kilted for ci image build Signed-off-by: Steve Macenski <[email protected]> * Bumping to 1.4.0 for kilted release Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: Steve Macenski <[email protected]> * Removing underlay workspace from Main (#5200) Signed-off-by: Steve Macenski <[email protected]> * Adding missing dep to loopback sim (#5204) * Adding missing dep Signed-off-by: Steve Macenski <[email protected]> * typo Signed-off-by: Steve Macenski <[email protected]> * updating fix Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: Steve Macenski <[email protected]> * Adding parameter warn_when_defaulting_parameters to control default parameter warnings (#5189) * Adding a parameter warn_when_defaulting_parameters to control default parameter warnings instead of using a flag Signed-off-by: Marco Bassa <[email protected]> * Adding parameter strict_param_loading for optionally throwing an exception if parameter overrides are missing Signed-off-by: Marco Bassa <[email protected]> * Using default false declaration instead of declare_or_get in param util Signed-off-by: Marco Bassa <[email protected]> --------- Signed-off-by: Marco Bassa <[email protected]> * Update mergify.yml Signed-off-by: Steve Macenski <[email protected]> * include bug fix for nav2_smac_planner (#5198) Signed-off-by: Stevedan Omodolor <[email protected]> * Revert "Removing underlay workspace from Main" (#5206) * Revert "Removing underlay workspace from Main (#5200)" This reverts commit 1278df7. * Update underlay.repos Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: Steve Macenski <[email protected]> * Option to Reduce Lethal to High-Cost Navigable To Get Out of Keepout Zones if Wandered In (#5187) * Adding toggle option of keepout zone Signed-off-by: Steve Macenski <[email protected]> * Default off Signed-off-by: Steve Macenski <[email protected]> * Join conditions Signed-off-by: Steve Macenski <[email protected]> * spell check Signed-off-by: Steve Macenski <[email protected]> * copilot suggestions Signed-off-by: Steve Macenski <[email protected]> * Update nav2_costmap_2d/plugins/costmap_filters/keepout_filter.cpp Co-authored-by: Leander Stephen D'Souza <[email protected]> Signed-off-by: Steve Macenski <[email protected]> * Update nav2_costmap_2d/plugins/costmap_filters/keepout_filter.cpp Co-authored-by: Leander Stephen D'Souza <[email protected]> Signed-off-by: Steve Macenski <[email protected]> * Update keepout_filter.cpp Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: Steve Macenski <[email protected]> Co-authored-by: Leander Stephen D'Souza <[email protected]> * Prototype solving #5192 Issue 2: Reeds-Shepp reduce small reverse expansions (#5207) * prototype solving 5192 issue 2 Signed-off-by: Steve Macenski <[email protected]> * Removing unnecessary variable Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: Steve Macenski <[email protected]> * Revert recent smac changes causing regressions (#5221) * Revert "Prototype solving #5192 Issue 2: Reeds-Shepp reduce small reverse expansions (#5207)" This reverts commit c32873d. * Revert "include bug fix for nav2_smac_planner (#5198)" This reverts commit 6a74ba6. * Revert "Feat/smac planner include orientation flexibility (#4127)" This reverts commit f5543c3. * Disable costmap filter zones from tb3 bringup (only Tb4 enabled) (#5223) * Update tb3_loopback_simulation_launch.py Signed-off-by: Steve Macenski <[email protected]> * Update tb3_simulation_launch.py Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: Steve Macenski <[email protected]> * Revert "Fix Ci from key signing (#5220)" (#5237) * Revert "Fix Ci from key signing (#5220)" This reverts the changes to the Dockerfile done in 1345c22. Signed-off-by: Nils-Christian Iseke <[email protected]> * Update Cache Version Signed-off-by: Nils-Christian Iseke <[email protected]> --------- Signed-off-by: Nils-Christian Iseke <[email protected]> * Updating readme table for kilted release (#5249) * updating readme table for kilted release Signed-off-by: Steve Macenski <[email protected]> * Updating table lint Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: Steve Macenski <[email protected]> * Add min_distance_to_obstacle parameter to RPP (#4543) * min_distance_to_obstacle Signed-off-by: Guillaume Doisy <[email protected]> * suggestion to time base and combine Signed-off-by: Guillaume Doisy <[email protected]> * typo Signed-off-by: Guillaume Doisy <[email protected]> * use min_approach_linear_velocity Signed-off-by: Guillaume Doisy <[email protected]> --------- Signed-off-by: Guillaume Doisy <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> * Fixing builds for message filters API change while retaining Jazzy, Kilted, and Rolling support (#5251) * Update amcl_node.hpp Signed-off-by: Steve Macenski <[email protected]> * Update amcl_node.cpp Signed-off-by: Steve Macenski <[email protected]> * Working for Kilted, Jazzy Signed-off-by: Steve Macenski <[email protected]> * Update amcl_node.cpp Signed-off-by: Steve Macenski <[email protected]> * Update amcl_node.cpp Signed-off-by: Steve Macenski <[email protected]> * Update amcl_node.cpp Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: Steve Macenski <[email protected]> * Route server corner smoothing (#5226) * added edge length method Signed-off-by: Alexander Yuen <[email protected]> * Added corner arc class Signed-off-by: Alexander Yuen <[email protected]> * replaced double vectors with Coordinates, added methods to return start and end coordinates Signed-off-by: Alexander Yuen <[email protected]> * using Coordinates, fixed direction of tangents Signed-off-by: Alexander Yuen <[email protected]> * added corner arc in header, added logger in protected variable Signed-off-by: Alexander Yuen <[email protected]> * first pass of corner smoothing algorithm Signed-off-by: Alexander Yuen <[email protected]> * reassigning next edge to have a different start, if a corner occurs before it Signed-off-by: Alexander Yuen <[email protected]> * using unique pointer instead of raw pointers for new edges and nodes Signed-off-by: Alexander Yuen <[email protected]> * added smoothing parameter Signed-off-by: Alexander Yuen <[email protected]> * made angle of interpolation a parameter Signed-off-by: Alexander Yuen <[email protected]> * const for return methods, added flag for smoothing corners Signed-off-by: Alexander Yuen <[email protected]> * moved getEdgeLength() into the Directional Edge struct Signed-off-by: Alexander Yuen <[email protected]> * using float instead of double Signed-off-by: Alexander Yuen <[email protected]> * smoothing radius is float, couple methods moved to protected Signed-off-by: Alexander Yuen <[email protected]> * removed signed_angle_ as a member variable Signed-off-by: Alexander Yuen <[email protected]> * removed unnecessary member variables Signed-off-by: Alexander Yuen <[email protected]> * removed angle of interpolation and inferring it from path density and radius instead Signed-off-by: Alexander Yuen <[email protected]> * consolidated corner arc into one header function Signed-off-by: Alexander Yuen <[email protected]> * readded newline Signed-off-by: Alexander Yuen <[email protected]> * changed corner arc to corner smoothing Signed-off-by: Alexander Yuen <[email protected]> * replaced the use of edges with coordinates to generate smoothing arc, removed storage of nodes and edges Signed-off-by: Alexander Yuen <[email protected]> * linting Signed-off-by: Alexander Yuen <[email protected]> * fixing cpplint Signed-off-by: Alexander Yuen <[email protected]> * linting for headers Signed-off-by: Alexander Yuen <[email protected]> * cpplinting Signed-off-by: Alexander Yuen <[email protected]> * Update nav2_route/src/path_converter.cpp Signed-off-by: Steve Macenski <[email protected]> * Update nav2_route/src/path_converter.cpp Signed-off-by: Steve Macenski <[email protected]> * Update nav2_route/src/path_converter.cpp Signed-off-by: Steve Macenski <[email protected]> * Update nav2_route/src/path_converter.cpp Signed-off-by: Steve Macenski <[email protected]> * Update nav2_route/include/nav2_route/corner_smoothing.hpp Signed-off-by: Steve Macenski <[email protected]> * fixed divide by zeros and accessing empty route.edges Signed-off-by: Alexander Yuen <[email protected]> * uncrustify linting Signed-off-by: Alexander Yuen <[email protected]> * cpp linting Signed-off-by: Alexander Yuen <[email protected]> * path converter linting Signed-off-by: Alexander Yuen <[email protected]> * changed all doubles to floats Signed-off-by: Alexander Yuen <[email protected]> * added check for edges that are colinear to avoid divide by 0, fixed final edge interpolation Signed-off-by: Alexander Yuen <[email protected]> * linting Signed-off-by: Alexander Yuen <[email protected]> * Update nav2_route/include/nav2_route/corner_smoothing.hpp Signed-off-by: Steve Macenski <[email protected]> * added doxygen for corner arc class Signed-off-by: Alexander Yuen <[email protected]> * added warning message if corner can't be smoothed Signed-off-by: Alexander Yuen <[email protected]> * added smooth_corners to the nav2 params file Signed-off-by: Alexander Yuen <[email protected]> * added smoothing flag and radius parameter to README.md' Signed-off-by: Alexander Yuen <[email protected]> * typo in README Signed-off-by: Alexander Yuen <[email protected]> * added testing for corner smoothing Signed-off-by: Alexander Yuen <[email protected]> * Update nav2_route/include/nav2_route/corner_smoothing.hpp Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: Alexander Yuen <[email protected]> Signed-off-by: Steve Macenski <[email protected]> Co-authored-by: Steve Macenski <[email protected]> * Conserve curvature with LIMIT action (#5255) * Conserve curvature with LIMIT action Signed-off-by: Tony Najjar <[email protected]> * fix format Signed-off-by: Tony Najjar <[email protected]> * fix test Signed-off-by: Tony Najjar <[email protected]> --------- Signed-off-by: Tony Najjar <[email protected]> * Parametrizing obstacle layer tf filter tolerance (#5261) Signed-off-by: Marco Bassa <[email protected]> * Add namespace support for rviz costmap cost tool (#5268) Signed-off-by: Maurice-1235 <[email protected]> * Fix/smac planner orientation goals (#5235) * cherry pick Signed-off-by: Stevedan Omodolor <[email protected]> * cherry pick 6a74ba6 Signed-off-by: Stevedan Omodolor <[email protected]> * cherrpy pick Signed-off-by: Stevedan Omodolor <[email protected]> * include x11 forwarding Signed-off-by: Stevedan Omodolor <[email protected]> * kind of working version Signed-off-by: Stevedan Omodolor <[email protected]> * cleanup Signed-off-by: Stevedan Omodolor <[email protected]> * formatting Signed-off-by: Stevedan Omodolor <[email protected]> * minor format change Signed-off-by: Stevedan Omodolor <[email protected]> * change naming Signed-off-by: Stevedan Omodolor <[email protected]> * minor changes Signed-off-by: Stevedan Omodolor <[email protected]> * working with new changes Signed-off-by: Stevedan Omodolor <[email protected]> * Revert "Fix Ci from key signing (#5220)" (#5237) * Revert "Fix Ci from key signing (#5220)" This reverts the changes to the Dockerfile done in 1345c22. Signed-off-by: Nils-Christian Iseke <[email protected]> * Update Cache Version Signed-off-by: Nils-Christian Iseke <[email protected]> --------- Signed-off-by: Nils-Christian Iseke <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * Revert back Signed-off-by: Stevedan Omodolor <[email protected]> * enable_groot_monitoring_ false (#5246) Signed-off-by: Guillaume Doisy <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * Updating readme table for kilted release (#5249) * updating readme table for kilted release Signed-off-by: Steve Macenski <[email protected]> * Updating table lint Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: Steve Macenski <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * Add min_distance_to_obstacle parameter to RPP (#4543) * min_distance_to_obstacle Signed-off-by: Guillaume Doisy <[email protected]> * suggestion to time base and combine Signed-off-by: Guillaume Doisy <[email protected]> * typo Signed-off-by: Guillaume Doisy <[email protected]> * use min_approach_linear_velocity Signed-off-by: Guillaume Doisy <[email protected]> --------- Signed-off-by: Guillaume Doisy <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * Fixing builds for message filters API change while retaining Jazzy, Kilted, and Rolling support (#5251) * Update amcl_node.hpp Signed-off-by: Steve Macenski <[email protected]> * Update amcl_node.cpp Signed-off-by: Steve Macenski <[email protected]> * Working for Kilted, Jazzy Signed-off-by: Steve Macenski <[email protected]> * Update amcl_node.cpp Signed-off-by: Steve Macenski <[email protected]> * Update amcl_node.cpp Signed-off-by: Steve Macenski <[email protected]> * Update amcl_node.cpp Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: Steve Macenski <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * Change max_cost default to 254 (#5256) Signed-off-by: Tony Najjar <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * linter Signed-off-by: Stevedan Omodolor <[email protected]> * remove const Signed-off-by: Stevedan Omodolor <[email protected]> * pass const pointer by value Signed-off-by: Stevedan Omodolor <[email protected]> * pass const pointer by value Signed-off-by: Stevedan Omodolor <[email protected]> * remove unused param Signed-off-by: Stevedan Omodolor <[email protected]> --------- Signed-off-by: Stevedan Omodolor <[email protected]> Signed-off-by: Nils-Christian Iseke <[email protected]> Signed-off-by: Guillaume Doisy <[email protected]> Signed-off-by: Steve Macenski <[email protected]> Signed-off-by: Tony Najjar <[email protected]> Co-authored-by: Steve Macenski <[email protected]> Co-authored-by: Nils-Christian Iseke <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> Co-authored-by: Tony Najjar <[email protected]> * Increase cache Signed-off-by: Steve Macenski <[email protected]> * fixes for humble main compatibility Signed-off-by: Steve Macenski <[email protected]> * Revert "Removing action server timeout duration after fixes to ROS 2, Reverts 3787 (#5183)" This reverts commit c9438b4. * fixing CI build Signed-off-by: Steve Macenski <[email protected]> * revert Signed-off-by: Steve Macenski <[email protected]> * done Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: Leander Stephen D'Souza <[email protected]> Signed-off-by: Steve Macenski <[email protected]> Signed-off-by: Jakubach <[email protected]> Signed-off-by: Alberto Tudela <[email protected]> Signed-off-by: brayanpa <[email protected]> Signed-off-by: Brayan Pallares <[email protected]> Signed-off-by: Jad haj mustafa <[email protected]> Signed-off-by: Tim Clephas <[email protected]> Signed-off-by: RamanaBotta <[email protected]> Signed-off-by: Tony Najjar <[email protected]> Signed-off-by: Nils-ChristianIseke <[email protected]> Signed-off-by: Nils-Christian Iseke <[email protected]> Signed-off-by: Nils-Christian Iseke <[email protected]> Signed-off-by: Marco Bassa <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> Signed-off-by: Guillaume Doisy <[email protected]> Signed-off-by: Alexander Yuen <[email protected]> Signed-off-by: Maurice-1235 <[email protected]> Co-authored-by: Leander Stephen D'Souza <[email protected]> Co-authored-by: Alberto Tudela <[email protected]> Co-authored-by: Brayan Pallares <[email protected]> Co-authored-by: Jad Haj Mustafa <[email protected]> Co-authored-by: Tim Clephas <[email protected]> Co-authored-by: Raman <[email protected]> Co-authored-by: RamanaBotta <[email protected]> Co-authored-by: Tony Najjar <[email protected]> Co-authored-by: Nils-Christian Iseke <[email protected]> Co-authored-by: Marco Bassa <[email protected]> Co-authored-by: Stevedan Ogochukwu Omodolor <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> Co-authored-by: alexanderjyuen <[email protected]> Co-authored-by: mini-1235 <[email protected]>
SakshayMahna
pushed a commit
to SakshayMahna/navigation2
that referenced
this pull request
Jul 6, 2025
* min_distance_to_obstacle Signed-off-by: Guillaume Doisy <[email protected]> * suggestion to time base and combine Signed-off-by: Guillaume Doisy <[email protected]> * typo Signed-off-by: Guillaume Doisy <[email protected]> * use min_approach_linear_velocity Signed-off-by: Guillaume Doisy <[email protected]> --------- Signed-off-by: Guillaume Doisy <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]>
SakshayMahna
pushed a commit
to SakshayMahna/navigation2
that referenced
this pull request
Jul 6, 2025
* cherry pick Signed-off-by: Stevedan Omodolor <[email protected]> * cherry pick 6a74ba6 Signed-off-by: Stevedan Omodolor <[email protected]> * cherrpy pick Signed-off-by: Stevedan Omodolor <[email protected]> * include x11 forwarding Signed-off-by: Stevedan Omodolor <[email protected]> * kind of working version Signed-off-by: Stevedan Omodolor <[email protected]> * cleanup Signed-off-by: Stevedan Omodolor <[email protected]> * formatting Signed-off-by: Stevedan Omodolor <[email protected]> * minor format change Signed-off-by: Stevedan Omodolor <[email protected]> * change naming Signed-off-by: Stevedan Omodolor <[email protected]> * minor changes Signed-off-by: Stevedan Omodolor <[email protected]> * working with new changes Signed-off-by: Stevedan Omodolor <[email protected]> * Revert "Fix Ci from key signing (ros-navigation#5220)" (ros-navigation#5237) * Revert "Fix Ci from key signing (ros-navigation#5220)" This reverts the changes to the Dockerfile done in 1345c22. Signed-off-by: Nils-Christian Iseke <[email protected]> * Update Cache Version Signed-off-by: Nils-Christian Iseke <[email protected]> --------- Signed-off-by: Nils-Christian Iseke <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * Revert back Signed-off-by: Stevedan Omodolor <[email protected]> * enable_groot_monitoring_ false (ros-navigation#5246) Signed-off-by: Guillaume Doisy <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * Updating readme table for kilted release (ros-navigation#5249) * updating readme table for kilted release Signed-off-by: Steve Macenski <[email protected]> * Updating table lint Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: Steve Macenski <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * Add min_distance_to_obstacle parameter to RPP (ros-navigation#4543) * min_distance_to_obstacle Signed-off-by: Guillaume Doisy <[email protected]> * suggestion to time base and combine Signed-off-by: Guillaume Doisy <[email protected]> * typo Signed-off-by: Guillaume Doisy <[email protected]> * use min_approach_linear_velocity Signed-off-by: Guillaume Doisy <[email protected]> --------- Signed-off-by: Guillaume Doisy <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * Fixing builds for message filters API change while retaining Jazzy, Kilted, and Rolling support (ros-navigation#5251) * Update amcl_node.hpp Signed-off-by: Steve Macenski <[email protected]> * Update amcl_node.cpp Signed-off-by: Steve Macenski <[email protected]> * Working for Kilted, Jazzy Signed-off-by: Steve Macenski <[email protected]> * Update amcl_node.cpp Signed-off-by: Steve Macenski <[email protected]> * Update amcl_node.cpp Signed-off-by: Steve Macenski <[email protected]> * Update amcl_node.cpp Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: Steve Macenski <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * Change max_cost default to 254 (ros-navigation#5256) Signed-off-by: Tony Najjar <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * linter Signed-off-by: Stevedan Omodolor <[email protected]> * remove const Signed-off-by: Stevedan Omodolor <[email protected]> * pass const pointer by value Signed-off-by: Stevedan Omodolor <[email protected]> * pass const pointer by value Signed-off-by: Stevedan Omodolor <[email protected]> * remove unused param Signed-off-by: Stevedan Omodolor <[email protected]> --------- Signed-off-by: Stevedan Omodolor <[email protected]> Signed-off-by: Nils-Christian Iseke <[email protected]> Signed-off-by: Guillaume Doisy <[email protected]> Signed-off-by: Steve Macenski <[email protected]> Signed-off-by: Tony Najjar <[email protected]> Co-authored-by: Steve Macenski <[email protected]> Co-authored-by: Nils-Christian Iseke <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> Co-authored-by: Tony Najjar <[email protected]>
Jakub-husarz
pushed a commit
to MuLTechnologies/navigation2
that referenced
this pull request
Jul 9, 2025
* cherry pick Signed-off-by: Stevedan Omodolor <[email protected]> * cherry pick 6a74ba6 Signed-off-by: Stevedan Omodolor <[email protected]> * cherrpy pick Signed-off-by: Stevedan Omodolor <[email protected]> * include x11 forwarding Signed-off-by: Stevedan Omodolor <[email protected]> * kind of working version Signed-off-by: Stevedan Omodolor <[email protected]> * cleanup Signed-off-by: Stevedan Omodolor <[email protected]> * formatting Signed-off-by: Stevedan Omodolor <[email protected]> * minor format change Signed-off-by: Stevedan Omodolor <[email protected]> * change naming Signed-off-by: Stevedan Omodolor <[email protected]> * minor changes Signed-off-by: Stevedan Omodolor <[email protected]> * working with new changes Signed-off-by: Stevedan Omodolor <[email protected]> * Revert "Fix Ci from key signing (ros-navigation#5220)" (ros-navigation#5237) * Revert "Fix Ci from key signing (ros-navigation#5220)" This reverts the changes to the Dockerfile done in 1345c22. Signed-off-by: Nils-Christian Iseke <[email protected]> * Update Cache Version Signed-off-by: Nils-Christian Iseke <[email protected]> --------- Signed-off-by: Nils-Christian Iseke <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * Revert back Signed-off-by: Stevedan Omodolor <[email protected]> * enable_groot_monitoring_ false (ros-navigation#5246) Signed-off-by: Guillaume Doisy <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * Updating readme table for kilted release (ros-navigation#5249) * updating readme table for kilted release Signed-off-by: Steve Macenski <[email protected]> * Updating table lint Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: Steve Macenski <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * Add min_distance_to_obstacle parameter to RPP (ros-navigation#4543) * min_distance_to_obstacle Signed-off-by: Guillaume Doisy <[email protected]> * suggestion to time base and combine Signed-off-by: Guillaume Doisy <[email protected]> * typo Signed-off-by: Guillaume Doisy <[email protected]> * use min_approach_linear_velocity Signed-off-by: Guillaume Doisy <[email protected]> --------- Signed-off-by: Guillaume Doisy <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * Fixing builds for message filters API change while retaining Jazzy, Kilted, and Rolling support (ros-navigation#5251) * Update amcl_node.hpp Signed-off-by: Steve Macenski <[email protected]> * Update amcl_node.cpp Signed-off-by: Steve Macenski <[email protected]> * Working for Kilted, Jazzy Signed-off-by: Steve Macenski <[email protected]> * Update amcl_node.cpp Signed-off-by: Steve Macenski <[email protected]> * Update amcl_node.cpp Signed-off-by: Steve Macenski <[email protected]> * Update amcl_node.cpp Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: Steve Macenski <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * Change max_cost default to 254 (ros-navigation#5256) Signed-off-by: Tony Najjar <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * linter Signed-off-by: Stevedan Omodolor <[email protected]> * remove const Signed-off-by: Stevedan Omodolor <[email protected]> * pass const pointer by value Signed-off-by: Stevedan Omodolor <[email protected]> * pass const pointer by value Signed-off-by: Stevedan Omodolor <[email protected]> * remove unused param Signed-off-by: Stevedan Omodolor <[email protected]> --------- Signed-off-by: Stevedan Omodolor <[email protected]> Signed-off-by: Nils-Christian Iseke <[email protected]> Signed-off-by: Guillaume Doisy <[email protected]> Signed-off-by: Steve Macenski <[email protected]> Signed-off-by: Tony Najjar <[email protected]> Co-authored-by: Steve Macenski <[email protected]> Co-authored-by: Nils-Christian Iseke <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> Co-authored-by: Tony Najjar <[email protected]>
Jakub-husarz
pushed a commit
to MuLTechnologies/navigation2
that referenced
this pull request
Jul 9, 2025
* cherry pick Signed-off-by: Stevedan Omodolor <[email protected]> * cherry pick 6a74ba6 Signed-off-by: Stevedan Omodolor <[email protected]> * cherrpy pick Signed-off-by: Stevedan Omodolor <[email protected]> * include x11 forwarding Signed-off-by: Stevedan Omodolor <[email protected]> * kind of working version Signed-off-by: Stevedan Omodolor <[email protected]> * cleanup Signed-off-by: Stevedan Omodolor <[email protected]> * formatting Signed-off-by: Stevedan Omodolor <[email protected]> * minor format change Signed-off-by: Stevedan Omodolor <[email protected]> * change naming Signed-off-by: Stevedan Omodolor <[email protected]> * minor changes Signed-off-by: Stevedan Omodolor <[email protected]> * working with new changes Signed-off-by: Stevedan Omodolor <[email protected]> * Revert "Fix Ci from key signing (ros-navigation#5220)" (ros-navigation#5237) * Revert "Fix Ci from key signing (ros-navigation#5220)" This reverts the changes to the Dockerfile done in 1345c22. Signed-off-by: Nils-Christian Iseke <[email protected]> * Update Cache Version Signed-off-by: Nils-Christian Iseke <[email protected]> --------- Signed-off-by: Nils-Christian Iseke <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * Revert back Signed-off-by: Stevedan Omodolor <[email protected]> * enable_groot_monitoring_ false (ros-navigation#5246) Signed-off-by: Guillaume Doisy <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * Updating readme table for kilted release (ros-navigation#5249) * updating readme table for kilted release Signed-off-by: Steve Macenski <[email protected]> * Updating table lint Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: Steve Macenski <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * Add min_distance_to_obstacle parameter to RPP (ros-navigation#4543) * min_distance_to_obstacle Signed-off-by: Guillaume Doisy <[email protected]> * suggestion to time base and combine Signed-off-by: Guillaume Doisy <[email protected]> * typo Signed-off-by: Guillaume Doisy <[email protected]> * use min_approach_linear_velocity Signed-off-by: Guillaume Doisy <[email protected]> --------- Signed-off-by: Guillaume Doisy <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * Fixing builds for message filters API change while retaining Jazzy, Kilted, and Rolling support (ros-navigation#5251) * Update amcl_node.hpp Signed-off-by: Steve Macenski <[email protected]> * Update amcl_node.cpp Signed-off-by: Steve Macenski <[email protected]> * Working for Kilted, Jazzy Signed-off-by: Steve Macenski <[email protected]> * Update amcl_node.cpp Signed-off-by: Steve Macenski <[email protected]> * Update amcl_node.cpp Signed-off-by: Steve Macenski <[email protected]> * Update amcl_node.cpp Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: Steve Macenski <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * Change max_cost default to 254 (ros-navigation#5256) Signed-off-by: Tony Najjar <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * linter Signed-off-by: Stevedan Omodolor <[email protected]> * remove const Signed-off-by: Stevedan Omodolor <[email protected]> * pass const pointer by value Signed-off-by: Stevedan Omodolor <[email protected]> * pass const pointer by value Signed-off-by: Stevedan Omodolor <[email protected]> * remove unused param Signed-off-by: Stevedan Omodolor <[email protected]> --------- Signed-off-by: Stevedan Omodolor <[email protected]> Signed-off-by: Nils-Christian Iseke <[email protected]> Signed-off-by: Guillaume Doisy <[email protected]> Signed-off-by: Steve Macenski <[email protected]> Signed-off-by: Tony Najjar <[email protected]> Co-authored-by: Steve Macenski <[email protected]> Co-authored-by: Nils-Christian Iseke <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> Co-authored-by: Tony Najjar <[email protected]>
Sushant-Chavan
added a commit
to Sushant-Chavan/navigation2
that referenced
this pull request
Aug 5, 2025
* Revert "Fix Ci from key signing (ros-navigation#5220)" (ros-navigation#5237) * Revert "Fix Ci from key signing (ros-navigation#5220)" This reverts the changes to the Dockerfile done in 1345c22. Signed-off-by: Nils-Christian Iseke <[email protected]> * Update Cache Version Signed-off-by: Nils-Christian Iseke <[email protected]> --------- Signed-off-by: Nils-Christian Iseke <[email protected]> * enable_groot_monitoring_ false (ros-navigation#5246) Signed-off-by: Guillaume Doisy <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> * Updating readme table for kilted release (ros-navigation#5249) * updating readme table for kilted release Signed-off-by: Steve Macenski <[email protected]> * Updating table lint Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: Steve Macenski <[email protected]> * Add min_distance_to_obstacle parameter to RPP (ros-navigation#4543) * min_distance_to_obstacle Signed-off-by: Guillaume Doisy <[email protected]> * suggestion to time base and combine Signed-off-by: Guillaume Doisy <[email protected]> * typo Signed-off-by: Guillaume Doisy <[email protected]> * use min_approach_linear_velocity Signed-off-by: Guillaume Doisy <[email protected]> --------- Signed-off-by: Guillaume Doisy <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> * Fixing builds for message filters API change while retaining Jazzy, Kilted, and Rolling support (ros-navigation#5251) * Update amcl_node.hpp Signed-off-by: Steve Macenski <[email protected]> * Update amcl_node.cpp Signed-off-by: Steve Macenski <[email protected]> * Working for Kilted, Jazzy Signed-off-by: Steve Macenski <[email protected]> * Update amcl_node.cpp Signed-off-by: Steve Macenski <[email protected]> * Update amcl_node.cpp Signed-off-by: Steve Macenski <[email protected]> * Update amcl_node.cpp Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: Steve Macenski <[email protected]> * Change max_cost default to 254 (ros-navigation#5256) Signed-off-by: Tony Najjar <[email protected]> * Route server corner smoothing (ros-navigation#5226) * added edge length method Signed-off-by: Alexander Yuen <[email protected]> * Added corner arc class Signed-off-by: Alexander Yuen <[email protected]> * replaced double vectors with Coordinates, added methods to return start and end coordinates Signed-off-by: Alexander Yuen <[email protected]> * using Coordinates, fixed direction of tangents Signed-off-by: Alexander Yuen <[email protected]> * added corner arc in header, added logger in protected variable Signed-off-by: Alexander Yuen <[email protected]> * first pass of corner smoothing algorithm Signed-off-by: Alexander Yuen <[email protected]> * reassigning next edge to have a different start, if a corner occurs before it Signed-off-by: Alexander Yuen <[email protected]> * using unique pointer instead of raw pointers for new edges and nodes Signed-off-by: Alexander Yuen <[email protected]> * added smoothing parameter Signed-off-by: Alexander Yuen <[email protected]> * made angle of interpolation a parameter Signed-off-by: Alexander Yuen <[email protected]> * const for return methods, added flag for smoothing corners Signed-off-by: Alexander Yuen <[email protected]> * moved getEdgeLength() into the Directional Edge struct Signed-off-by: Alexander Yuen <[email protected]> * using float instead of double Signed-off-by: Alexander Yuen <[email protected]> * smoothing radius is float, couple methods moved to protected Signed-off-by: Alexander Yuen <[email protected]> * removed signed_angle_ as a member variable Signed-off-by: Alexander Yuen <[email protected]> * removed unnecessary member variables Signed-off-by: Alexander Yuen <[email protected]> * removed angle of interpolation and inferring it from path density and radius instead Signed-off-by: Alexander Yuen <[email protected]> * consolidated corner arc into one header function Signed-off-by: Alexander Yuen <[email protected]> * readded newline Signed-off-by: Alexander Yuen <[email protected]> * changed corner arc to corner smoothing Signed-off-by: Alexander Yuen <[email protected]> * replaced the use of edges with coordinates to generate smoothing arc, removed storage of nodes and edges Signed-off-by: Alexander Yuen <[email protected]> * linting Signed-off-by: Alexander Yuen <[email protected]> * fixing cpplint Signed-off-by: Alexander Yuen <[email protected]> * linting for headers Signed-off-by: Alexander Yuen <[email protected]> * cpplinting Signed-off-by: Alexander Yuen <[email protected]> * Update nav2_route/src/path_converter.cpp Signed-off-by: Steve Macenski <[email protected]> * Update nav2_route/src/path_converter.cpp Signed-off-by: Steve Macenski <[email protected]> * Update nav2_route/src/path_converter.cpp Signed-off-by: Steve Macenski <[email protected]> * Update nav2_route/src/path_converter.cpp Signed-off-by: Steve Macenski <[email protected]> * Update nav2_route/include/nav2_route/corner_smoothing.hpp Signed-off-by: Steve Macenski <[email protected]> * fixed divide by zeros and accessing empty route.edges Signed-off-by: Alexander Yuen <[email protected]> * uncrustify linting Signed-off-by: Alexander Yuen <[email protected]> * cpp linting Signed-off-by: Alexander Yuen <[email protected]> * path converter linting Signed-off-by: Alexander Yuen <[email protected]> * changed all doubles to floats Signed-off-by: Alexander Yuen <[email protected]> * added check for edges that are colinear to avoid divide by 0, fixed final edge interpolation Signed-off-by: Alexander Yuen <[email protected]> * linting Signed-off-by: Alexander Yuen <[email protected]> * Update nav2_route/include/nav2_route/corner_smoothing.hpp Signed-off-by: Steve Macenski <[email protected]> * added doxygen for corner arc class Signed-off-by: Alexander Yuen <[email protected]> * added warning message if corner can't be smoothed Signed-off-by: Alexander Yuen <[email protected]> * added smooth_corners to the nav2 params file Signed-off-by: Alexander Yuen <[email protected]> * added smoothing flag and radius parameter to README.md' Signed-off-by: Alexander Yuen <[email protected]> * typo in README Signed-off-by: Alexander Yuen <[email protected]> * added testing for corner smoothing Signed-off-by: Alexander Yuen <[email protected]> * Update nav2_route/include/nav2_route/corner_smoothing.hpp Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: Alexander Yuen <[email protected]> Signed-off-by: Steve Macenski <[email protected]> Co-authored-by: Steve Macenski <[email protected]> * Conserve curvature with LIMIT action (ros-navigation#5255) * Conserve curvature with LIMIT action Signed-off-by: Tony Najjar <[email protected]> * fix format Signed-off-by: Tony Najjar <[email protected]> * fix test Signed-off-by: Tony Najjar <[email protected]> --------- Signed-off-by: Tony Najjar <[email protected]> * Parametrizing obstacle layer tf filter tolerance (ros-navigation#5261) Signed-off-by: Marco Bassa <[email protected]> * Add namespace support for rviz costmap cost tool (ros-navigation#5268) Signed-off-by: Maurice-1235 <[email protected]> * Fix/smac planner orientation goals (ros-navigation#5235) * cherry pick Signed-off-by: Stevedan Omodolor <[email protected]> * cherry pick 6a74ba6 Signed-off-by: Stevedan Omodolor <[email protected]> * cherrpy pick Signed-off-by: Stevedan Omodolor <[email protected]> * include x11 forwarding Signed-off-by: Stevedan Omodolor <[email protected]> * kind of working version Signed-off-by: Stevedan Omodolor <[email protected]> * cleanup Signed-off-by: Stevedan Omodolor <[email protected]> * formatting Signed-off-by: Stevedan Omodolor <[email protected]> * minor format change Signed-off-by: Stevedan Omodolor <[email protected]> * change naming Signed-off-by: Stevedan Omodolor <[email protected]> * minor changes Signed-off-by: Stevedan Omodolor <[email protected]> * working with new changes Signed-off-by: Stevedan Omodolor <[email protected]> * Revert "Fix Ci from key signing (ros-navigation#5220)" (ros-navigation#5237) * Revert "Fix Ci from key signing (ros-navigation#5220)" This reverts the changes to the Dockerfile done in 1345c22. Signed-off-by: Nils-Christian Iseke <[email protected]> * Update Cache Version Signed-off-by: Nils-Christian Iseke <[email protected]> --------- Signed-off-by: Nils-Christian Iseke <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * Revert back Signed-off-by: Stevedan Omodolor <[email protected]> * enable_groot_monitoring_ false (ros-navigation#5246) Signed-off-by: Guillaume Doisy <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * Updating readme table for kilted release (ros-navigation#5249) * updating readme table for kilted release Signed-off-by: Steve Macenski <[email protected]> * Updating table lint Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: Steve Macenski <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * Add min_distance_to_obstacle parameter to RPP (ros-navigation#4543) * min_distance_to_obstacle Signed-off-by: Guillaume Doisy <[email protected]> * suggestion to time base and combine Signed-off-by: Guillaume Doisy <[email protected]> * typo Signed-off-by: Guillaume Doisy <[email protected]> * use min_approach_linear_velocity Signed-off-by: Guillaume Doisy <[email protected]> --------- Signed-off-by: Guillaume Doisy <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * Fixing builds for message filters API change while retaining Jazzy, Kilted, and Rolling support (ros-navigation#5251) * Update amcl_node.hpp Signed-off-by: Steve Macenski <[email protected]> * Update amcl_node.cpp Signed-off-by: Steve Macenski <[email protected]> * Working for Kilted, Jazzy Signed-off-by: Steve Macenski <[email protected]> * Update amcl_node.cpp Signed-off-by: Steve Macenski <[email protected]> * Update amcl_node.cpp Signed-off-by: Steve Macenski <[email protected]> * Update amcl_node.cpp Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: Steve Macenski <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * Change max_cost default to 254 (ros-navigation#5256) Signed-off-by: Tony Najjar <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> * linter Signed-off-by: Stevedan Omodolor <[email protected]> * remove const Signed-off-by: Stevedan Omodolor <[email protected]> * pass const pointer by value Signed-off-by: Stevedan Omodolor <[email protected]> * pass const pointer by value Signed-off-by: Stevedan Omodolor <[email protected]> * remove unused param Signed-off-by: Stevedan Omodolor <[email protected]> --------- Signed-off-by: Stevedan Omodolor <[email protected]> Signed-off-by: Nils-Christian Iseke <[email protected]> Signed-off-by: Guillaume Doisy <[email protected]> Signed-off-by: Steve Macenski <[email protected]> Signed-off-by: Tony Najjar <[email protected]> Co-authored-by: Steve Macenski <[email protected]> Co-authored-by: Nils-Christian Iseke <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> Co-authored-by: Tony Najjar <[email protected]> * Fix backport compiler warning (ros-navigation#5277) Signed-off-by: Steve Macenski <[email protected]> * Fix ament mypy (ros-navigation#5280) * Configured nav2_loopback_sim to be compliant with mypy. Signed-off-by: Leander Stephen D'Souza <[email protected]> * Configured nav2_simple_commander to be compliant with mypy. Signed-off-by: Leander Stephen D'Souza <[email protected]> * Configured nav2_system_tests to be compliant with mypy. Signed-off-by: Leander Stephen D'Souza <[email protected]> --------- Signed-off-by: Leander Stephen D'Souza <[email protected]> * Publish zero velocitiy in case of goal failure (ros-navigation#5279) Signed-off-by: haider8645 <[email protected]> * Update PULL_REQUEST_TEMPLATE.md Signed-off-by: Steve Macenski <[email protected]> * Use fixed thresholds for Trinary yaml (ros-navigation#5278) Signed-off-by: Adi Vardi <[email protected]> * Add missing include of algorithm in differential_motion_model.cpp (ros-navigation#5293) Signed-off-by: Silvio Traversaro <[email protected]> * Remove unused unistd.h header from route_tool.cpp (ros-navigation#5292) Signed-off-by: Silvio Traversaro <[email protected]> * Fix compilation of nav2_smac_planner on Windows (ros-navigation#5291) Signed-off-by: Silvio <[email protected]> * Large Nav2 Node, Utils, and Interface Refactor (ros-navigation#5288) * initial unorganized prototype Signed-off-by: Steve Macenski <[email protected]> * break out files and add doxygen Signed-off-by: Steve Macenski <[email protected]> * Adding refactor for nav2_ros_common and new ROS interface factories Signed-off-by: Steve Macenski <[email protected]> * fixing CI - not sure how that got through merge conflicts Signed-off-by: Steve Macenski <[email protected]> * Lifecycle publisher a missing test Signed-off-by: Steve Macenski <[email protected]> * system tests Signed-off-by: Steve Macenski <[email protected]> * default Signed-off-by: Steve Macenski <[email protected]> * activating publishers Signed-off-by: Steve Macenski <[email protected]> * temp disable allow param qos overrides Signed-off-by: Steve Macenski <[email protected]> * API update for new constructor option Signed-off-by: Steve Macenski <[email protected]> * Supporting Jazzy and abstracting util Signed-off-by: Steve Macenski <[email protected]> * Review round 1 Signed-off-by: Steve Macenski <[email protected]> * Adding Nav2 Publisher and Subscriber objects to later build upon Signed-off-by: Steve Macenski <[email protected]> * Adding additional ::SharedPtr for readability Signed-off-by: Steve Macenski <[email protected]> * fix bug Signed-off-by: Steve Macenski <[email protected]> * fixing Jazzy support Signed-off-by: Steve Macenski <[email protected]> * missed one last spot Signed-off-by: Steve Macenski <[email protected]> * Adding migration instructions Signed-off-by: Steve Macenski <[email protected]> * more context Signed-off-by: Steve Macenski <[email protected]> * Adding migration context Signed-off-by: Steve Macenski <[email protected]> * precommit Signed-off-by: Steve Macenski <[email protected]> * adding missing dep Signed-off-by: Steve Macenski <[email protected]> * Updating system tess Signed-off-by: Steve Macenski <[email protected]> * more Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: Steve Macenski <[email protected]> * Adding logging for matched events and dropped messages into pub/sub of new nav2_ros_common package. Also adding QoS overrides default ON (ros-navigation#5302) * Adding logging for matched events and dropped messages Signed-off-by: Steve Macenski <[email protected]> * toggle on Signed-off-by: Steve Macenski <[email protected]> * apply for smac 2D Signed-off-by: Steve Macenski <[email protected]> * Update interface_factories.hpp Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: Steve Macenski <[email protected]> * Add LaunchConfigAsBool (Fixes ros-navigation#5233) (ros-navigation#5301) * Add LaunchConfigAsBool (Fixes ros-navigation#5233) Signed-off-by: nishalangovender <[email protected]> * Fix Linting Signed-off-by: nishalangovender <[email protected]> * Fix ament_mypy and pre-commit Signed-off-by: nishalangovender <[email protected]> * Added Type Annotations Signed-off-by: Nishalan Govender <[email protected]> * mypy ignore Signed-off-by: Nishalan Govender <[email protected]> * launch.Substitution Signed-off-by: Nishalan Govender <[email protected]> * Update All Bools in nav2_bringup Signed-off-by: Nishalan Govender <[email protected]> --------- Signed-off-by: nishalangovender <[email protected]> Signed-off-by: Nishalan Govender <[email protected]> * Create claude.yml Signed-off-by: Steve Macenski <[email protected]> * Update claude.yml Signed-off-by: Steve Macenski <[email protected]> * Update claude.yml Signed-off-by: Steve Macenski <[email protected]> * Update claude.yml for authorized users Signed-off-by: Steve Macenski <[email protected]> * Update claude.yml Signed-off-by: Steve Macenski <[email protected]> * Update claude.yml Signed-off-by: Steve Macenski <[email protected]> * Adding clear costmap around pose service option (ros-navigation#5309) * Adding clear costmap around pose impl Signed-off-by: Steve Macenski <[email protected]> * Update nav2_msgs/srv/ClearCostmapAroundPose.srv Signed-off-by: Steve Macenski <[email protected]> * Adding APIs for simple commander Signed-off-by: Steve Macenski <[email protected]> * linting Signed-off-by: Steve Macenski <[email protected]> * adding import Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: Steve Macenski <[email protected]> * Fix compiler errors in nav2_map_server * Fix compiler errors in nav2_costmap_2d * Add support for enable_lifecycle_services parameter in LifecycleNode (ros-navigation#5307) Expose the enable_communication_interface parameter from rclcpp_lifecycle::LifecycleNode through nav2's LifecycleNode wrapper. This allows users to disable lifecycle communication interfaces when manually managing node lifecycle transitions. The parameter can be set via NodeOptions parameter overrides: ```cpp rclcpp::NodeOptions options; options.parameter_overrides({{"enable_lifecycle_services", false}}); ``` Fixes ros-navigation#5305 Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> --------- Signed-off-by: Nils-Christian Iseke <[email protected]> Signed-off-by: Guillaume Doisy <[email protected]> Signed-off-by: Steve Macenski <[email protected]> Signed-off-by: Tony Najjar <[email protected]> Signed-off-by: Alexander Yuen <[email protected]> Signed-off-by: Marco Bassa <[email protected]> Signed-off-by: Maurice-1235 <[email protected]> Signed-off-by: Stevedan Omodolor <[email protected]> Signed-off-by: Leander Stephen D'Souza <[email protected]> Signed-off-by: haider8645 <[email protected]> Signed-off-by: Adi Vardi <[email protected]> Signed-off-by: Silvio Traversaro <[email protected]> Signed-off-by: Silvio <[email protected]> Signed-off-by: nishalangovender <[email protected]> Signed-off-by: Nishalan Govender <[email protected]> Co-authored-by: Nils-Christian Iseke <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> Co-authored-by: Steve Macenski <[email protected]> Co-authored-by: Tony Najjar <[email protected]> Co-authored-by: alexanderjyuen <[email protected]> Co-authored-by: Marco Bassa <[email protected]> Co-authored-by: mini-1235 <[email protected]> Co-authored-by: Stevedan Ogochukwu Omodolor <[email protected]> Co-authored-by: Leander Stephen D'Souza <[email protected]> Co-authored-by: Haider <[email protected]> Co-authored-by: Adi Vardi <[email protected]> Co-authored-by: Silvio Traversaro <[email protected]> Co-authored-by: Nishalan Govender <[email protected]> Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
SteveMacenski
pushed a commit
that referenced
this pull request
Aug 19, 2025
* min_distance_to_obstacle Signed-off-by: Guillaume Doisy <[email protected]> * suggestion to time base and combine Signed-off-by: Guillaume Doisy <[email protected]> * typo Signed-off-by: Guillaume Doisy <[email protected]> * use min_approach_linear_velocity Signed-off-by: Guillaume Doisy <[email protected]> --------- Signed-off-by: Guillaume Doisy <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]>
SteveMacenski
added a commit
that referenced
this pull request
Aug 20, 2025
* enable_groot_monitoring_ false (#5246) Signed-off-by: Guillaume Doisy <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> * Add min_distance_to_obstacle parameter to RPP (#4543) * min_distance_to_obstacle Signed-off-by: Guillaume Doisy <[email protected]> * suggestion to time base and combine Signed-off-by: Guillaume Doisy <[email protected]> * typo Signed-off-by: Guillaume Doisy <[email protected]> * use min_approach_linear_velocity Signed-off-by: Guillaume Doisy <[email protected]> --------- Signed-off-by: Guillaume Doisy <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> * Parametrizing obstacle layer tf filter tolerance (#5261) Signed-off-by: Marco Bassa <[email protected]> * Fix backport compiler warning (#5277) Signed-off-by: Steve Macenski <[email protected]> * Add missing include of algorithm in differential_motion_model.cpp (#5293) Signed-off-by: Silvio Traversaro <[email protected]> * Remove unused unistd.h header from route_tool.cpp (#5292) Signed-off-by: Silvio Traversaro <[email protected]> * Adding epsilon for voxel_layer precision loss (#5314) * Adding epsilon for voxel_layer precision loss Signed-off-by: bhx <[email protected]> * Update nav2_costmap_2d/plugins/voxel_layer.cpp Signed-off-by: Steve Macenski <[email protected]> * Update nav2_costmap_2d/plugins/voxel_layer.cpp Signed-off-by: Steve Macenski <[email protected]> * Update nav2_costmap_2d/plugins/voxel_layer.cpp Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: bhx <[email protected]> Signed-off-by: Steve Macenski <[email protected]> Co-authored-by: Steve Macenski <[email protected]> * fix: correct ThroughActionResult type alias in would_a_planner_recovery_help_condition (#5326) The ThroughActionResult type alias was incorrectly referencing Action::Result instead of ThroughAction::Result, causing the condition to not work properly for ComputePathThroughPoses actions. Fixes #5324 Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> * outputting tracker feedback on ComputeAndTrack BT node (#5327) * outputting tracker feedback on BT node Signed-off-by: Alexander Yuen <[email protected]> * initializing outputs Signed-off-by: Alexander Yuen <[email protected]> * outputting last state on success Signed-off-by: Alexander Yuen <[email protected]> * linting Signed-off-by: Alexander Yuen <[email protected]> * fixed nav2_tree_nodes.xml Signed-off-by: Alexander Yuen <[email protected]> * Update nav2_behavior_tree/include/nav2_behavior_tree/plugins/action/compute_and_track_route_action.hpp Co-authored-by: Steve Macenski <[email protected]> Signed-off-by: alexanderjyuen <[email protected]> * consolidated function to set outputs null, only setOutput with active feedback Signed-off-by: Alexander Yuen <[email protected]> * add class to method Signed-off-by: Alexander Yuen <[email protected]> * linting Signed-off-by: Alexander Yuen <[email protected]> --------- Signed-off-by: Alexander Yuen <[email protected]> Signed-off-by: alexanderjyuen <[email protected]> Co-authored-by: Steve Macenski <[email protected]> * Adding slow down at target heading to RPP Controller (#5361) * Adding slow down at target heading to RPP Signed-off-by: SteveMacenski <[email protected]> * Update test_regulated_pp.cpp Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: SteveMacenski <[email protected]> Signed-off-by: Steve Macenski <[email protected]> * Include <stdexcept> in docking_exceptions.hpp for exception handling (#5363) Signed-off-by: Alberto Tudela <[email protected]> * Eexception rethrow in dockRobot method (#5364) Signed-off-by: Alberto Tudela <[email protected]> * Add global min obstacle height in voxel layer (#5389) * Add min obstacle height in voxel layer Signed-off-by: mini-1235 <[email protected]> * Fix linting Signed-off-by: Maurice <[email protected]> --------- Signed-off-by: mini-1235 <[email protected]> Signed-off-by: Maurice <[email protected]> * [DEX] Enforce 3 digits precision (#5398) Signed-off-by: Guillaume Doisy <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> * [static_layer] limit comparison precision (#5405) * [DEX] limit comparison precision Signed-off-by: Guillaume Doisy <[email protected]> * EPSILON 1e-5 Signed-off-by: Guillaume Doisy <[email protected]> --------- Signed-off-by: Guillaume Doisy <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> * corner case bin check (#5413) Signed-off-by: Guillaume Doisy <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> * Add IndexType definition for Nanoflann KDTree in `node_spatial_tree`. (#5420) * fix: Add KDTree type definition to include unsigned int for IndexType Signed-off-by: Ericsii <[email protected]> * code format Signed-off-by: Ericsii <[email protected]> --------- Signed-off-by: Ericsii <[email protected]> * Smooth path even if goal pose is so much near to the robot (#5423) * Smooth path even if goal pose is so much near to the robot Signed-off-by: CihatAltiparmak <[email protected]> * Apply suggestions Signed-off-by: CihatAltiparmak <[email protected]> * Remove unnecessary diff Signed-off-by: CihatAltiparmak <[email protected]> --------- Signed-off-by: CihatAltiparmak <[email protected]> * Fix KeepoutFilter on the ARM architecture (#5436) Signed-off-by: Sushant Chavan <[email protected]> * Fix missing dependency (#5460) * Support loading multiple behavior tree files as subtrees (#5426) * Support loading multiple behavior tree files as subtrees Signed-off-by: Jad El Hajj <[email protected]> * Fix code style Signed-off-by: Jad El Hajj <[email protected]> * Added default param value Signed-off-by: Jad El Hajj <[email protected]> * Added recursive check to loadBehaviorTree and adapted unit test accordingly Signed-off-by: Jad El Hajj <[email protected]> * Removed nested loadBehaviorTree check in navigators Signed-off-by: Jad El Hajj <[email protected]> * Removed whitespace cpplint Signed-off-by: Jad El Hajj <[email protected]> * Fixed goalReceived Signed-off-by: Jad El Hajj <[email protected]> * Let loadbehaviorTree use its own search_directories var Signed-off-by: Jad El Hajj <[email protected]> * PR fixes-format-lint and test Signed-off-by: Jad El Hajj <[email protected]> * fix pointer Signed-off-by: Jad El Hajj <[email protected]> * Added unit test for BT xml validity Signed-off-by: Jad El Hajj <[email protected]> * CPPLint Signed-off-by: Jad El Hajj <[email protected]> * Check non existent search directory for bt Signed-off-by: Jad El Hajj <[email protected]> * CPPLint Signed-off-by: Jad El Hajj <[email protected]> * Fixed BT tests Signed-off-by: Jad El Hajj <[email protected]> * Fixed BT tests Signed-off-by: Jad El Hajj <[email protected]> --------- Signed-off-by: Jad El Hajj <[email protected]> * bump 1.4.0 to 1.4.1 for aug 19 sync Signed-off-by: SteveMacenski <[email protected]> * Fixing backport error Signed-off-by: SteveMacenski <[email protected]> * load balance CI Signed-off-by: SteveMacenski <[email protected]> * Fixing BT Navigator backport merge conflict issue Signed-off-by: SteveMacenski <[email protected]> --------- Signed-off-by: Guillaume Doisy <[email protected]> Signed-off-by: Marco Bassa <[email protected]> Signed-off-by: Steve Macenski <[email protected]> Signed-off-by: Silvio Traversaro <[email protected]> Signed-off-by: bhx <[email protected]> Signed-off-by: Alexander Yuen <[email protected]> Signed-off-by: alexanderjyuen <[email protected]> Signed-off-by: SteveMacenski <[email protected]> Signed-off-by: Alberto Tudela <[email protected]> Signed-off-by: mini-1235 <[email protected]> Signed-off-by: Maurice <[email protected]> Signed-off-by: Ericsii <[email protected]> Signed-off-by: CihatAltiparmak <[email protected]> Signed-off-by: Sushant Chavan <[email protected]> Signed-off-by: Jad El Hajj <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> Co-authored-by: Guillaume Doisy <[email protected]> Co-authored-by: Marco Bassa <[email protected]> Co-authored-by: Silvio Traversaro <[email protected]> Co-authored-by: hutao <[email protected]> Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: alexanderjyuen <[email protected]> Co-authored-by: Alberto Tudela <[email protected]> Co-authored-by: mini-1235 <[email protected]> Co-authored-by: YLFeng <[email protected]> Co-authored-by: Cihat Kurtuluş Altıparmak <[email protected]> Co-authored-by: Sushant Chavan <[email protected]> Co-authored-by: Tim Clephas <[email protected]> Co-authored-by: Jad EL HAJJ <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
This PR adds the parameter
min_distance_to_obstacleto stop in front of an obstacle based on distance and not only time to collisionDescription of documentation updates required from your changes
Future work that may be required in bullet points
For Maintainers: