Merged
Conversation
AndWeHaveAPlan
added
R0-no-crate-publish-required
Contributor
Author
|
dockerhub, google registry (for 299e45c) |
BulatSaif
approved these changes
Apr 24, 2025
nprt
approved these changes
Apr 24, 2025
alvicsam
reviewed
Apr 24, 2025
| image-name: "europe-docker.pkg.dev/parity-ci-2024/temp-images/test-parachain" | ||
| image-name: "test-parachain" | ||
| dockerfile: "docker/dockerfiles/test-parachain_injected.Dockerfile" | ||
| username: ${{ secrets.PARITYPR_DOCKERHUB_USERNAME }} |
Contributor
There was a problem hiding this comment.
It's going to fail for PRs from forks. I'd add a separate job that'll push images for master only.
There was a problem hiding this comment.
we also need optional image push from PR branches not only master.
Contributor
Author
There was a problem hiding this comment.
updated, now login/push only if secrets are present
EgorPopelyaev
approved these changes
Apr 25, 2025
alvicsam
approved these changes
Apr 25, 2025
BulatSaif
approved these changes
Apr 25, 2025
wassimans
pushed a commit
to wassimans/polkadot-sdk
that referenced
this pull request
Apr 27, 2025
Push images to dockerhub paritypr org in addition to private google registry fix https://github.com/paritytech/devops/issues/3976
ordian
added a commit
that referenced
this pull request
Apr 28, 2025
* master: (120 commits) [CI] Improve GH build status checking (#8331) [CI/CD] Use original PR name in prdoc check for the backport PR's to the stable branches (#8329) Add new host APIs set_storage_or_clear and get_storage_or_zero (#7857) push to dockerhub (#8322) Snowbridge - V1 - Adds 2 hop transfer to Rococo (#7956) [AHM] Prepare `election-provider-multi-block` for full lazy data deletion (#8304) Check umbrella version (#8250) [AHM] Fully bound staking async (#8303) migrate parachain-templates tests to `gha` (#8226) staking-async: add missing new_session_genesis (#8310) New NFT traits: granular and abstract interface (#5620) Extract create_pool_with_native_on macro to common crate (#8289) XCMP: use batching when enqueuing inbound messages (#8021) Snowbridge - Tests refactor (#8014) Allow configuration of worst case buy execution weight (#7944) Fix faulty pre-upgrade migration check in pallet-session (#8294) [pallet-revive] add get_storage_var_key for variable-sized keys (#8274) add poke_deposit extrinsic to pallet-recovery (#7882) `txpool`: use tracing for structured logging (#8001) [revive] eth-rpc refactoring (#8148) ...
castillax
pushed a commit
that referenced
this pull request
May 12, 2025
Push images to dockerhub paritypr org in addition to private google registry fix paritytech/devops#3976
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Push images to dockerhub paritypr org in addition to private google registry
fix https://github.com/paritytech/devops/issues/3976