Conversation
There was a problem hiding this comment.
Copilot reviewed 9 out of 12 changed files in this pull request and generated no comments.
Files not reviewed (3)
- substrate/frame/revive/rpc/.sqlx/query-6345c84da6afad02d0fdf4e1657c53e64320c118d39db73f573510235baf4ba0.json: Language not supported
- substrate/frame/revive/rpc/.sqlx/query-d7377b5a09f075668d259d02e3fc7a12048a70a33b96381118d6c24210afce34.json: Language not supported
- substrate/frame/revive/rpc/.sqlx/query-e3d7860041663651866032e8fb054cff3e1707381845f47f693177dbce110448.json: Language not supported
Comments suppressed due to low confidence (2)
substrate/frame/revive/rpc/src/client.rs:525
- The conversion for the storage key has been changed from big endian to little endian. Please verify that using little endian encoding aligns with the storage layout expectations to avoid potential mismatches.
.get_storage(contract_address, key.to_little_endian());
substrate/frame/revive/rpc/src/tests.rs:129
- [nitpick] The error message string in the assert_eq! macro mixes placeholder syntax with literal variable names. Consider using a properly formatted message with all variables explicitly passed to ensure they are correctly interpolated.
assert_eq!(Some(value), balance.checked_sub(initial_balance), "Ethan {:?} {balance:?} should have increased by {value:?} from {initial_balance}.", ethan.address());
xermicus
approved these changes
Apr 7, 2025
Contributor
Author
|
/cmd prdoc --audience runtime_dev --bump patch |
pgherveou
added
T7-smart_contracts
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
athei
approved these changes
Apr 22, 2025
auto-merge was automatically disabled
April 22, 2025 09:50
Pull Request is not mergeable
ordian
added a commit
that referenced
this pull request
Apr 28, 2025
* master: (120 commits) [CI] Improve GH build status checking (#8331) [CI/CD] Use original PR name in prdoc check for the backport PR's to the stable branches (#8329) Add new host APIs set_storage_or_clear and get_storage_or_zero (#7857) push to dockerhub (#8322) Snowbridge - V1 - Adds 2 hop transfer to Rococo (#7956) [AHM] Prepare `election-provider-multi-block` for full lazy data deletion (#8304) Check umbrella version (#8250) [AHM] Fully bound staking async (#8303) migrate parachain-templates tests to `gha` (#8226) staking-async: add missing new_session_genesis (#8310) New NFT traits: granular and abstract interface (#5620) Extract create_pool_with_native_on macro to common crate (#8289) XCMP: use batching when enqueuing inbound messages (#8021) Snowbridge - Tests refactor (#8014) Allow configuration of worst case buy execution weight (#7944) Fix faulty pre-upgrade migration check in pallet-session (#8294) [pallet-revive] add get_storage_var_key for variable-sized keys (#8274) add poke_deposit extrinsic to pallet-recovery (#7882) `txpool`: use tracing for structured logging (#8001) [revive] eth-rpc refactoring (#8148) ...
castillax
pushed a commit
that referenced
this pull request
May 12, 2025
Refactor eth-rpc - Get rid of the in memory-cache, we can just store receipts logs into sqlite, and use in-memory db for non archive node. - Track both best and finalized blocks so that we can properly index transaction receipts in case of a relay chain re-org. - Keep reference to the latest finalized block so that we can use that for queries that use the `finalized` block tag - use `--index-last-n-blocks` cli parameter to re-index the last n block when the server start - Fix issue related to gas estimate calculation for EIP1559 transaction types tested changes with paritytech/evm-test-suite#87 fix paritytech/contract-issues#35 paritytech/contract-issues#33 --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-project-automation
bot
moved this from Todo
to Done
in [preview] release tracker
github-project-automation
bot
moved this from Todo
to Done
in [preview] release tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor eth-rpc
finalizedblock tag--index-last-n-blockscli parameter to re-index the last n block when the server starttested changes with paritytech/evm-test-suite#87
fix paritytech/contract-issues#35 paritytech/contract-issues#33