Snowbridge - V1 - Adds 2 hop transfer to Rococo#7956
Merged
acatangiu merged 26 commits intoparitytech:masterfrom Apr 25, 2025
Merged
Snowbridge - V1 - Adds 2 hop transfer to Rococo#7956acatangiu merged 26 commits intoparitytech:masterfrom
acatangiu merged 26 commits intoparitytech:masterfrom
Conversation
…-hop-transfer-to-rococo
# Conflicts: # cumulus/parachains/integration-tests/emulated/chains/parachains/assets/asset-hub-rococo/src/genesis.rs # cumulus/parachains/integration-tests/emulated/chains/parachains/assets/asset-hub-westend/src/genesis.rs # cumulus/parachains/integration-tests/emulated/common/src/lib.rs # cumulus/parachains/integration-tests/emulated/tests/bridges/bridge-hub-westend/src/tests/snowbridge.rs
claravanstaden
changed the title
# Conflicts: # cumulus/parachains/integration-tests/emulated/tests/bridges/bridge-hub-westend/src/tests/snowbridge.rs
claravanstaden
changed the title
acatangiu
reviewed
Apr 18, 2025
Contributor
acatangiu
left a comment
acatangiu
left a comment
There was a problem hiding this comment.
Code changes look good, but some tests are failing - without running them to debug, and by just looking at diff, my best guess is WETH registration in AHR genesis maybe conflicting with explicit registration attempts from older tests
cumulus/parachains/integration-tests/emulated/tests/bridges/bridge-hub-westend/src/tests/mod.rs
Outdated
Show resolved
Hide resolved
Contributor
Author
acatangiu
added
R0-no-crate-publish-required
acatangiu
approved these changes
Apr 23, 2025
auto-merge was automatically disabled
April 23, 2025 12:14
Head branch was pushed to by a user without write access
# Conflicts: # cumulus/parachains/integration-tests/emulated/chains/parachains/assets/asset-hub-rococo/src/genesis.rs # cumulus/parachains/integration-tests/emulated/chains/parachains/assets/asset-hub-westend/src/genesis.rs # cumulus/parachains/integration-tests/emulated/common/src/lib.rs # cumulus/parachains/integration-tests/emulated/tests/bridges/bridge-hub-westend/src/tests/asset_transfers.rs # cumulus/parachains/integration-tests/emulated/tests/bridges/bridge-hub-westend/src/tests/mod.rs # cumulus/parachains/integration-tests/emulated/tests/bridges/bridge-hub-westend/src/tests/register_bridged_assets.rs # cumulus/parachains/integration-tests/emulated/tests/bridges/bridge-hub-westend/src/tests/snowbridge.rs # cumulus/parachains/integration-tests/emulated/tests/bridges/bridge-hub-westend/src/tests/snowbridge_edge_case.rs # cumulus/parachains/integration-tests/emulated/tests/bridges/bridge-hub-westend/src/tests/transact.rs
raymondkfcheung
approved these changes
Apr 23, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
|
@claravanstaden this needs rebase and fixing some imports since your other PR got it that moved some stuff around |
Contributor
|
maybe you can also address #8289 (comment) in this PR |
Contributor
Author
@acatangiu added a comment over here: #8289 (comment) |
Merged
via the queue into
paritytech:master
with commit Apr 25, 2025
8da42e8
233 of 243 checks passed
wassimans
pushed a commit
to wassimans/polkadot-sdk
that referenced
this pull request
Apr 27, 2025
Adds a test to demonstrate a 2-hop (Ethereum to Westend AH, second transaction from Westend AH to Rococo AH) transfer to Rococo AH (and back to Ethereum in a 2-hop fashion as well).
ordian
added a commit
that referenced
this pull request
Apr 28, 2025
* master: (120 commits) [CI] Improve GH build status checking (#8331) [CI/CD] Use original PR name in prdoc check for the backport PR's to the stable branches (#8329) Add new host APIs set_storage_or_clear and get_storage_or_zero (#7857) push to dockerhub (#8322) Snowbridge - V1 - Adds 2 hop transfer to Rococo (#7956) [AHM] Prepare `election-provider-multi-block` for full lazy data deletion (#8304) Check umbrella version (#8250) [AHM] Fully bound staking async (#8303) migrate parachain-templates tests to `gha` (#8226) staking-async: add missing new_session_genesis (#8310) New NFT traits: granular and abstract interface (#5620) Extract create_pool_with_native_on macro to common crate (#8289) XCMP: use batching when enqueuing inbound messages (#8021) Snowbridge - Tests refactor (#8014) Allow configuration of worst case buy execution weight (#7944) Fix faulty pre-upgrade migration check in pallet-session (#8294) [pallet-revive] add get_storage_var_key for variable-sized keys (#8274) add poke_deposit extrinsic to pallet-recovery (#7882) `txpool`: use tracing for structured logging (#8001) [revive] eth-rpc refactoring (#8148) ...
castillax
pushed a commit
that referenced
this pull request
May 12, 2025
Adds a test to demonstrate a 2-hop (Ethereum to Westend AH, second transaction from Westend AH to Rococo AH) transfer to Rococo AH (and back to Ethereum in a 2-hop fashion as well).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a test to demonstrate a 2-hop (Ethereum to Westend AH, second transaction from Westend AH to Rococo AH) transfer to Rococo AH (and back to Ethereum in a 2-hop fashion as well).