Extract create_pool_with_native_on macro to common crate#8289
Merged
bkchr merged 5 commits intoparitytech:masterfrom Apr 23, 2025
Merged
Extract create_pool_with_native_on macro to common crate#8289bkchr merged 5 commits intoparitytech:masterfrom
bkchr merged 5 commits intoparitytech:masterfrom
Conversation
1 task
acatangiu
approved these changes
Apr 23, 2025
Contributor
acatangiu
left a comment
acatangiu
left a comment
There was a problem hiding this comment.
Looks good, needs to get CI green. Also needs prdoc to make sure to publish new version of common crate.
# Conflicts: # cumulus/parachains/integration-tests/emulated/tests/bridges/bridge-hub-westend/src/tests/asset_transfers.rs # cumulus/parachains/integration-tests/emulated/tests/bridges/bridge-hub-westend/src/tests/transact.rs
bkchr
approved these changes
Apr 23, 2025
Merged
via the queue into
paritytech:master
with commit Apr 23, 2025
e8e8d6e
233 of 244 checks passed
bkontur
reviewed
Apr 23, 2025
|
|
||
| assert_ok!(<$chain as [<$chain Pallet>]>::AssetConversion::add_liquidity( | ||
| signed_owner, | ||
| Box::new(native_asset), |
Contributor
There was a problem hiding this comment.
@claravanstaden I am afraid of native_asset's import Location - it works for polkadot-sdk where we use xcm::v5 for pallet_assets/pallet_asset_conversion, but will it work if those pallets are using older version (e.g. polkadot-fellows) and also the same for GeneralIndex? Would Box::new(native_asset.into()) do the trick?
Contributor
Author
There was a problem hiding this comment.
@bkontur it doesn't seem to work. There are impls from v4 into v5, but not the other way around (from what I can see): https://github.com/paritytech/polkadot-sdk/blob/master/polkadot/xcm/src/v5/location.rs#L748. I can change the method signature to pass in the native_asset? Not sure what to do about GeneralIndex though.
wassimans
pushed a commit
to wassimans/polkadot-sdk
that referenced
this pull request
Apr 27, 2025
…8289) Moves macro to a common crate so that it can be reused in the polkadot runtimes repo.
ordian
added a commit
that referenced
this pull request
Apr 28, 2025
* master: (120 commits) [CI] Improve GH build status checking (#8331) [CI/CD] Use original PR name in prdoc check for the backport PR's to the stable branches (#8329) Add new host APIs set_storage_or_clear and get_storage_or_zero (#7857) push to dockerhub (#8322) Snowbridge - V1 - Adds 2 hop transfer to Rococo (#7956) [AHM] Prepare `election-provider-multi-block` for full lazy data deletion (#8304) Check umbrella version (#8250) [AHM] Fully bound staking async (#8303) migrate parachain-templates tests to `gha` (#8226) staking-async: add missing new_session_genesis (#8310) New NFT traits: granular and abstract interface (#5620) Extract create_pool_with_native_on macro to common crate (#8289) XCMP: use batching when enqueuing inbound messages (#8021) Snowbridge - Tests refactor (#8014) Allow configuration of worst case buy execution weight (#7944) Fix faulty pre-upgrade migration check in pallet-session (#8294) [pallet-revive] add get_storage_var_key for variable-sized keys (#8274) add poke_deposit extrinsic to pallet-recovery (#7882) `txpool`: use tracing for structured logging (#8001) [revive] eth-rpc refactoring (#8148) ...
castillax
pushed a commit
that referenced
this pull request
May 12, 2025
Moves macro to a common crate so that it can be reused in the polkadot runtimes repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves macro to a common crate so that it can be reused in the polkadot runtimes repo.