Merged
Conversation
kianenigma
added
the
R0-no-crate-publish-required
…/polkadot-sdk into kiz-fully-bound-staking-async
Ank4n
approved these changes
Apr 23, 2025
Contributor
Ank4n
left a comment
Ank4n
left a comment
There was a problem hiding this comment.
Just one nit and one question out of curiosity — everything else looks awesome!
re-gius
reviewed
Apr 23, 2025
kianenigma
commented
Apr 23, 2025
kianenigma
commented
Apr 23, 2025
Contributor
|
/cmd fmt |
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
re-gius
approved these changes
Apr 24, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
wassimans
pushed a commit
to wassimans/polkadot-sdk
that referenced
this pull request
Apr 27, 2025
Follow up to paritytech#8127 - [x] Bound `BondedEras`, making it super clear that `ErasStartSessionIndex` is no longer needed and is ergo removed. We only want to query the start index of the active era, which we already have in `BondedEras` - [x] Bound `EraRewardPoints` by `MaxValidatorSet` - [x] Bound `ErasClaimedRewards` with a custom bound. This type is using `WeakBoundedVec` under the hood as we expect `MaxExposurePageSize` to change. It is, in essence, only used in benchmarking and the code uses a `force_from` to set it. - [x] Bound `ErasStakersPaged` with a custom wrapper type. This type is actually unbounded under the hood as `MaxExposurePagesize` might change, and is pretending to be bounded by providing a bounded wrapper. - [ ] re-run benchmarks --------- Co-authored-by: Ankan <10196091+Ank4n@users.noreply.github.com> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
ordian
added a commit
that referenced
this pull request
Apr 28, 2025
* master: (120 commits) [CI] Improve GH build status checking (#8331) [CI/CD] Use original PR name in prdoc check for the backport PR's to the stable branches (#8329) Add new host APIs set_storage_or_clear and get_storage_or_zero (#7857) push to dockerhub (#8322) Snowbridge - V1 - Adds 2 hop transfer to Rococo (#7956) [AHM] Prepare `election-provider-multi-block` for full lazy data deletion (#8304) Check umbrella version (#8250) [AHM] Fully bound staking async (#8303) migrate parachain-templates tests to `gha` (#8226) staking-async: add missing new_session_genesis (#8310) New NFT traits: granular and abstract interface (#5620) Extract create_pool_with_native_on macro to common crate (#8289) XCMP: use batching when enqueuing inbound messages (#8021) Snowbridge - Tests refactor (#8014) Allow configuration of worst case buy execution weight (#7944) Fix faulty pre-upgrade migration check in pallet-session (#8294) [pallet-revive] add get_storage_var_key for variable-sized keys (#8274) add poke_deposit extrinsic to pallet-recovery (#7882) `txpool`: use tracing for structured logging (#8001) [revive] eth-rpc refactoring (#8148) ...
ggwpez
reviewed
May 7, 2025
| )] | ||
| #[codec(mel_bound())] | ||
| #[scale_info(skip_type_params(T))] | ||
| pub struct EraRewardPoints<T: Config> { |
Member
There was a problem hiding this comment.
Pulling in Config is a nightmare for anyone using it. Please try to only pull in Config if absolutely necessary.
It is better here to just pull in what is needed: AccountID and the MEL bound.
castillax
pushed a commit
that referenced
this pull request
May 12, 2025
Follow up to #8127 - [x] Bound `BondedEras`, making it super clear that `ErasStartSessionIndex` is no longer needed and is ergo removed. We only want to query the start index of the active era, which we already have in `BondedEras` - [x] Bound `EraRewardPoints` by `MaxValidatorSet` - [x] Bound `ErasClaimedRewards` with a custom bound. This type is using `WeakBoundedVec` under the hood as we expect `MaxExposurePageSize` to change. It is, in essence, only used in benchmarking and the code uses a `force_from` to set it. - [x] Bound `ErasStakersPaged` with a custom wrapper type. This type is actually unbounded under the hood as `MaxExposurePagesize` might change, and is pretending to be bounded by providing a bounded wrapper. - [ ] re-run benchmarks --------- Co-authored-by: Ankan <10196091+Ank4n@users.noreply.github.com> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #8127
BondedEras, making it super clear thatErasStartSessionIndexis no longer needed and is ergo removed. We only want to query the start index of the active era, which we already have inBondedErasEraRewardPointsbyMaxValidatorSetErasClaimedRewardswith a custom bound. This type is usingWeakBoundedVecunder the hood as we expectMaxExposurePageSizeto change. It is, in essence, only used in benchmarking and the code uses aforce_fromto set it.ErasStakersPagedwith a custom wrapper type. This type is actually unbounded under the hood asMaxExposurePagesizemight change, and is pretending to be bounded by providing a bounded wrapper.