txpool: use tracing for structured logging#8001
Merged
iulianbarbu merged 12 commits intoparitytech:masterfrom Apr 22, 2025
Merged
txpool: use tracing for structured logging#8001iulianbarbu merged 12 commits intoparitytech:masterfrom
txpool: use tracing for structured logging#8001iulianbarbu merged 12 commits intoparitytech:masterfrom
Conversation
Contributor
michalkucharczyk
left a comment
michalkucharczyk
left a comment
There was a problem hiding this comment.
Almost there. Please use tx_hash instead of [{}]. I left a comment wherever I noticed this.
substrate/client/transaction-pool/src/common/enactment_state.rs
Outdated
Show resolved
Hide resolved
substrate/client/transaction-pool/src/single_state_txpool/revalidation.rs
Outdated
Show resolved
Hide resolved
substrate/client/transaction-pool/src/single_state_txpool/revalidation.rs
Outdated
Show resolved
Hide resolved
substrate/client/transaction-pool/src/single_state_txpool/revalidation.rs
Outdated
Show resolved
Hide resolved
substrate/client/transaction-pool/src/single_state_txpool/single_state_txpool.rs
Outdated
Show resolved
Hide resolved
michalkucharczyk
added
R0-no-crate-publish-required
substrate/client/transaction-pool/src/single_state_txpool/single_state_txpool.rs
Outdated
Show resolved
Hide resolved
Contributor
|
@dharjeezy Would you please resolve conversations that are already fixed? |
michalkucharczyk
approved these changes
Apr 2, 2025
michalkucharczyk
changed the title
txpool: Use tracing for structured logging
michalkucharczyk
changed the title
txpool: Use tracing for structured loggingtxpool: use tracing for structured logging
iulianbarbu
reviewed
Apr 3, 2025
substrate/client/transaction-pool/src/single_state_txpool/revalidation.rs
Outdated
Show resolved
Hide resolved
substrate/client/transaction-pool/src/single_state_txpool/revalidation.rs
Outdated
Show resolved
Hide resolved
iulianbarbu
reviewed
Apr 7, 2025
iulianbarbu
approved these changes
Apr 7, 2025
Contributor
iulianbarbu
left a comment
iulianbarbu
left a comment
There was a problem hiding this comment.
Otherwise looks good! 👍 Feel free to apply my suggestion, and then we should be good to go. :D
bkchr
reviewed
Apr 11, 2025
substrate/client/transaction-pool/src/common/enactment_state.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Iulian Barbu <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: Michal Kucharczyk <[email protected]>
Contributor
|
I think this can be merged. @bkchr @michalkucharczyk can you take another look? |
michalkucharczyk
approved these changes
Apr 18, 2025
Merged
via the queue into
paritytech:master
with commit Apr 22, 2025
38a4dfe
234 of 244 checks passed
ordian
added a commit
that referenced
this pull request
Apr 28, 2025
* master: (120 commits) [CI] Improve GH build status checking (#8331) [CI/CD] Use original PR name in prdoc check for the backport PR's to the stable branches (#8329) Add new host APIs set_storage_or_clear and get_storage_or_zero (#7857) push to dockerhub (#8322) Snowbridge - V1 - Adds 2 hop transfer to Rococo (#7956) [AHM] Prepare `election-provider-multi-block` for full lazy data deletion (#8304) Check umbrella version (#8250) [AHM] Fully bound staking async (#8303) migrate parachain-templates tests to `gha` (#8226) staking-async: add missing new_session_genesis (#8310) New NFT traits: granular and abstract interface (#5620) Extract create_pool_with_native_on macro to common crate (#8289) XCMP: use batching when enqueuing inbound messages (#8021) Snowbridge - Tests refactor (#8014) Allow configuration of worst case buy execution weight (#7944) Fix faulty pre-upgrade migration check in pallet-session (#8294) [pallet-revive] add get_storage_var_key for variable-sized keys (#8274) add poke_deposit extrinsic to pallet-recovery (#7882) `txpool`: use tracing for structured logging (#8001) [revive] eth-rpc refactoring (#8148) ...
castillax
pushed a commit
that referenced
this pull request
May 12, 2025
Follow up on #6897 cc: @michalkucharczyk Polkadot address: 12GyGD3QhT4i2JJpNzvMf96sxxBLWymz4RdGCxRH5Rj5agKW Fixes: #5490 --------- Co-authored-by: Iulian Barbu <[email protected]> Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Michal Kucharczyk <[email protected]>
github-project-automation
bot
moved this from Todo
to Done
in [preview] release tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #6897 cc: @michalkucharczyk
Polkadot address: 12GyGD3QhT4i2JJpNzvMf96sxxBLWymz4RdGCxRH5Rj5agKW
Fixes: #5490