Move requests-responses and polling from ChainSync to SyncingEngine#1650
Merged
dmitry-markin merged 22 commits intomasterfrom Sep 27, 2023
Merged
Move requests-responses and polling from ChainSync to SyncingEngine#1650dmitry-markin merged 22 commits intomasterfrom
ChainSync to SyncingEngine#1650dmitry-markin merged 22 commits intomasterfrom
Conversation
dmitry-markin
added
R0-no-crate-publish-required
altonen
reviewed
Sep 21, 2023
altonen
reviewed
Sep 23, 2023
|
The CI pipeline was cancelled due to failure one of the required jobs. |
altonen
reviewed
Sep 25, 2023
altonen
approved these changes
Sep 25, 2023
Co-authored-by: Aaro Altonen <[email protected]>
…response-from-chainsync
bkchr
approved these changes
Sep 26, 2023
Member
bkchr
left a comment
bkchr
left a comment
There was a problem hiding this comment.
Didn't check too deeply as it is mainly about moving code.
Left some nitpicks.
Co-authored-by: Bastian Köcher <[email protected]>
…response-from-chainsync
dmitry-markin
commented
Sep 27, 2023
dmitry-markin
deleted the
dm-extract-request-response-from-chainsync
branch
dmitry-markin
commented
Sep 28, 2023
ordian
added a commit
that referenced
this pull request
Oct 10, 2023
* tsv-disabling-node-side: (69 commits) runtime-api: cleanup after v7 stabilization (#1729) Move requests-responses and polling from `ChainSync` to `SyncingEngine` (#1650) Add custom error message for `StorageNoopGuard` (#1727) Clarify docs cargo fmt add a CAVEAT comment implement disabled_validators correctly remove unnecessary hash string (#1722) OpenGov in Westend and Rococo (#1177) Associated type Hasher for `QueryPreimage`, `StorePreimage` and `Bounded` (#1720) Migrate polkadot-primitives to v6 (#1543) genesis-builder: implemented for all runtimes (#1492) `BlockId` removal: `tx-pool` refactor (#1678) Bump directories from 4.0.1 to 5.0.1 (#1656) Allow debug_assertions in short-benchmarks CI job (#1711) chainHead/storage: Fix storage iteration using the query key (#1665) Implement more useful traits in `Slot` type (#1595) Make downloads in parallel and give more time to complete (#1699) Bump actions/checkout from 4.0.0 to 4.1.0 (#1688) contracts: Fix incorrect storage alias in mirgration (#1687) ...
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
…e` (paritytech#1650) Move request-response handling from `ChainSync` to `SyncingEngine` as part of [Sync 2.0](paritytech#534) refactoring aimed at making `ChainSync` a pure state machine. Resolves paritytech#502. --------- Co-authored-by: Aaro Altonen <[email protected]> Co-authored-by: Bastian Köcher <[email protected]>
bkchr
pushed a commit
that referenced
this pull request
Apr 10, 2024
* prune messages from on-idle callback * no more secondary lanes at deployments * clippy * Update modules/messages/src/lib.rs Co-authored-by: Adrian Catangiu <[email protected]> * sub -> add * more tests + check that message is sent using one of ActiveOutboundLanes * ensure spent_weight is correct Co-authored-by: Adrian Catangiu <[email protected]>
This was referenced Jun 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move request-response handling from
ChainSynctoSyncingEngineas part of Sync 2.0 refactoring aimed at makingChainSynca pure state machine.Resolves #502.