Skip to content

Enable async backing on Rococo#1496

Closed
Sophia-Gold wants to merge 1 commit intomasterfrom
sophia-async-rococo
Closed

Enable async backing on Rococo#1496
Sophia-Gold wants to merge 1 commit intomasterfrom
sophia-async-rococo

Conversation

@Sophia-Gold
Copy link
Copy Markdown
Contributor

@Sophia-Gold Sophia-Gold commented Sep 11, 2023

This enables async backing in the Rococo runtime.

Requires #1543 and #1542.

@paritytech-cicd-pr
Copy link
Copy Markdown

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3650532

}
}

#[api_version(99)]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a problem. We can not have a release with version 99. We have to pick a proper version, which has consequences (which should be fine): We have to release this API next in production. We can then no longer release any other new functionality without also releasing async backing.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be more correct: We have to determine now what the next version is exactly. By making it no longer 99, this version is stable and must no longer be changed/modified in any way without bumping the version again.

Copy link
Copy Markdown
Contributor

@rphmeier rphmeier Sep 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What we need is a way to stabilize the API version without automatically upgrading all runtimes to it

@Sophia-Gold
Copy link
Copy Markdown
Contributor Author

Closing in favor of #1543.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants