cn doc translation - PR723, PR721#352
Merged
eshaben merged 26 commits intomoonbeam-foundation:eshaben/check-formatting-pr352from Dec 8, 2023
Merged
cn doc translation - PR723, PR721#352eshaben merged 26 commits intomoonbeam-foundation:eshaben/check-formatting-pr352from
eshaben merged 26 commits intomoonbeam-foundation:eshaben/check-formatting-pr352from
Conversation
Original PR:https://github.com/moonbeam-foundation/moonbeam-docs/pull/721/files#diff-bcba214e56e9e1497d6db81bf4ab8bbc94f674e27236426af6dee54d1da45084 note: docker.md has already been updated There are a few inconsistencies between en doc and cn doc. They are updated too.
eshaben
requested changes
Oct 31, 2023
Contributor
eshaben
left a comment
eshaben
left a comment
There was a problem hiding this comment.
Nice job! Just a few minor things 🙂
Co-authored-by: Erin Shaben <eshaben@icloud.com>
Co-authored-by: Erin Shaben <eshaben@icloud.com>
Co-authored-by: Erin Shaben <eshaben@icloud.com>
Co-authored-by: Erin Shaben <eshaben@icloud.com>
Co-authored-by: Erin Shaben <eshaben@icloud.com>
Co-authored-by: Erin Shaben <eshaben@icloud.com>
eshaben
changed the base branch from
master
to
eshaben/check-formatting-pr352
Contributor
|
There were some changes that I think I had initially requested on the translations for PR 723 and 721 that I was waiting to get fixed, but now it looks like there are some additional PRs that have been added. Can you please update the PR description to include the additional PRs? I just need to cross-reference the changes in the original PRs with the changes made here! Thank you! 🙂 |
eshaben
reviewed
Dec 1, 2023
Co-authored-by: Erin Shaben <eshaben@icloud.com>
Co-authored-by: Erin Shaben <eshaben@icloud.com>
Co-authored-by: Erin Shaben <eshaben@icloud.com>
Co-authored-by: wuzhong-papermoon <144415646+wuzhong-papermoon@users.noreply.github.com>
eshaben
reviewed
Dec 7, 2023
eshaben
reviewed
Dec 7, 2023
eshaben
reviewed
Dec 7, 2023
eshaben
reviewed
Dec 7, 2023
eshaben
reviewed
Dec 7, 2023
eshaben
reviewed
Dec 7, 2023
eshaben
reviewed
Dec 7, 2023
eshaben
reviewed
Dec 7, 2023
eshaben
reviewed
Dec 8, 2023
eshaben
reviewed
Dec 8, 2023
eshaben
reviewed
Dec 8, 2023
eshaben
approved these changes
Dec 8, 2023
Contributor
eshaben
left a comment
eshaben
left a comment
There was a problem hiding this comment.
Wooo! First translations PR 🎉
Still some changes that need to be made to a few code snippets and a couple lines left out, but I'll add them on my local branch and request a translation from there.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Translation for the following PR
moonbeam-foundation/moonbeam-docs#723
moonbeam-foundation/moonbeam-docs#721