Skip to content

update docs for ws/rpc changes#740

Merged
eshaben merged 4 commits intomasterfrom
eshaben/client-v0.33.0-ws-params
Sep 7, 2023
Merged

update docs for ws/rpc changes#740
eshaben merged 4 commits intomasterfrom
eshaben/client-v0.33.0-ws-params

Conversation

@eshaben
Copy link
Copy Markdown
Contributor

@eshaben eshaben commented Sep 6, 2023

Description

As of client v0.33.0, some --ws-* flags have been deprecated in favor of --rpc-*. The complete list of flags changed can be viewed in this PR: paritytech/substrate#13384

With this change, the default port for the --rpc-port flag is 9944, which is the default port for handling both RPC and WS connections as it has been since client v0.30.0.

This PR makes the necessary changes.

Checklist

  • If this requires translations for the moonbeam-docs-cn repo, I have created a ticket for the translations in Jira

After Translation Requirements

  • No additional PRs are required after the translations are done

@eshaben eshaben requested a review from albertov19 September 6, 2023 19:39
@eshaben eshaben added the A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) label Sep 6, 2023
@eshaben eshaben requested a review from themacexpert September 6, 2023 19:47
Copy link
Copy Markdown
Contributor

@themacexpert themacexpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@@ -51,15 +51,15 @@ Using Docker enables you to spin up a node in a matter of seconds. Once you have
```bash
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking is there a reason we don't have the RPC external flag on the Ubuntu command?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oversight. i'll add it! thanks! 🎣

@eshaben eshaben merged commit 49af231 into master Sep 7, 2023
@eshaben eshaben deleted the eshaben/client-v0.33.0-ws-params branch September 7, 2023 15:04
wuzhong-papermoon added a commit to wuzhong-papermoon/moonbeam-docs-cn that referenced this pull request Nov 28, 2023
eshaben pushed a commit to moonbeam-foundation/moonbeam-docs-cn that referenced this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants