Skip to content

Updates to Ethers.js Page#734

Merged
eshaben merged 14 commits intomasterfrom
albertov19/update-ethersjs
Sep 6, 2023
Merged

Updates to Ethers.js Page#734
eshaben merged 14 commits intomasterfrom
albertov19/update-ethersjs

Conversation

@albertov19
Copy link
Copy Markdown
Collaborator

@albertov19 albertov19 commented Aug 31, 2023

Description

Minor ages to Ethers.js page to go in line with new style of docs.

Checklist

  • If this requires translations for the moonbeam-docs-cn repo, I have created a ticket for the translations in Jira
  • I have created an additional PR in moonbeam-docs-cn for the scripts that have been renamed

Corresponding PRs

moonbeam-foundation/moonbeam-docs-cn#331

After Translation Requirements

  • No additional PRs are required after the translations are done

@albertov19 albertov19 requested a review from eshaben August 31, 2023 18:11
@eshaben
Copy link
Copy Markdown
Contributor

eshaben commented Sep 1, 2023

Since this PR deletes old snippets and replaces them with new ones, will need to wait for the CN companion PR to be approved before merging: moonbeam-foundation/moonbeam-docs-cn#331

Copy link
Copy Markdown
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks! ✨

@eshaben eshaben added the A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) label Sep 6, 2023
@eshaben eshaben merged commit 1b8ed40 into master Sep 6, 2023
@eshaben eshaben deleted the albertov19/update-ethersjs branch September 6, 2023 04:12
wuzhong-papermoon added a commit to wuzhong-papermoon/moonbeam-docs-cn that referenced this pull request Nov 28, 2023
eshaben pushed a commit to moonbeam-foundation/moonbeam-docs-cn that referenced this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants