Skip to content

update the gmp precompile as it now accepts a v2 user versioned action#742

Merged
eshaben merged 4 commits intomasterfrom
eshaben/rt2500-gmp-precompile
Sep 26, 2023
Merged

update the gmp precompile as it now accepts a v2 user versioned action#742
eshaben merged 4 commits intomasterfrom
eshaben/rt2500-gmp-precompile

Conversation

@eshaben
Copy link
Copy Markdown
Contributor

@eshaben eshaben commented Sep 6, 2023

Description

As of Runtime 2500, a new fee mechanism has been added for the GMP precompile, which is implemented in the V2 VersionedUserAction. This PR updates the GMP precompile page and snippet for creating a V2 payload.

Checklist

  • If this requires translations for the moonbeam-docs-cn repo, I have created a ticket for the translations in Jira

After Translation Requirements

  • No additional PRs are required after the translations are done

@eshaben eshaben added the A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) label Sep 6, 2023
@themacexpert themacexpert self-requested a review September 7, 2023 00:17
Copy link
Copy Markdown
Contributor

@themacexpert themacexpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jboetticher
Copy link
Copy Markdown
Contributor

Hi @eshaben , I've updated my example code in my repository, which changes the way that the types are handled (the "right" way, using package defined objects). It includes support for the fee in the payload and it also includes support for encoding with MultiLocation V3, which is important for future proofing the code.

This is all in typescript, so let me know if you need a javascript version.

https://github.com/jboetticher/mrl-example/blob/a7dac88728964401eae13c87ec0c6a2fd6508ab1/src/MoonbeamRoutedLiquidityPayloads.ts

@eshaben
Copy link
Copy Markdown
Contributor Author

eshaben commented Sep 15, 2023

@themacexpert made some changes here, so although you already approved i would appreciate it if you could take a look at the changes! thanks!

Copy link
Copy Markdown
Contributor

@themacexpert themacexpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@eshaben eshaben merged commit a6831b7 into master Sep 26, 2023
@eshaben eshaben deleted the eshaben/rt2500-gmp-precompile branch September 26, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants