Skip to content

Update XCM SDK Examples#772

Merged
eshaben merged 1 commit intomasterfrom
themacexpert/xcmsdk
Oct 16, 2023
Merged

Update XCM SDK Examples#772
eshaben merged 1 commit intomasterfrom
themacexpert/xcmsdk

Conversation

@themacexpert
Copy link
Copy Markdown
Contributor

Description

@ekenigs helped me figure out why a team was facing an issue (irrelevant to the docs) but while doing so we revised the example scripts a bit.

Checklist

  • If this requires translations for the moonbeam-docs-cn repo, I have created a ticket for the translations in Jira
  • If pages have been moved around, I have created an additional PR in moonbeam-mkdocs to update redirects
  • If pages have been moved around, I have run the move-pages.py script to move the pages and update the image paths on the chinese repo
    • After the script has been run, I have created an additional PR in moonbeam-docs-cn
  • If images have been added, I have run the compress-images.py script to compress the images.
  • If variables (in variables.yml) need to be updated (such as a name change), I have updated the moonbeam-docs-cn repo to use the new variables
  • If this page requires a disclaimer, I have added one

Corresponding PRs

Please link to any corresponding PRs here.

After Translation Requirements

  • Will need to create PR in moonbeam-docs repo to remove images
  • Will need to create PR in moonbeam-docs repo to remove variables
  • Will need to create PR in moonbeam-mkdocs repo to add redirects for Chinese site
  • No additional PRs are required after the translations are done

Items to be Updated

Please list any of the items that will need to be added or deleted after the translations are done here.

@themacexpert themacexpert requested a review from eshaben October 12, 2023 22:36
Copy link
Copy Markdown
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants