This repository was archived by the owner on Jan 3, 2023. It is now read-only.
Merged
Conversation
Signed-off-by: Sihui Han <[email protected]>
* Fix tables handling race condition in buffermgr Signed-off-by: Andriy Moroz <[email protected]> * Fixed status lose in loop Signed-off-by: Andriy Moroz <[email protected]>
…t#489) * [buffermgr]: remove the item from consumer queue if invalid Signed-off-by: Sihui Han <[email protected]> * change error to task_invalid_entry Signed-off-by: Sihui Han <[email protected]>
* [pfcwd]: enable BIG_RED_SWITCH mode Signed-off-by: Sihui Han <[email protected]> * update as comments
…c-net#491) * Populate existing interface cache, bring down before configDone * simplify the logic and add logging Signed-off-by: Guohan Lu <[email protected]> * add logging for publish event to state db Signed-off-by: Guohan Lu <[email protected]>
Signed-off-by: Sihui Han <[email protected]>
Signed-off-by: Nadiya Stetskovych <[email protected]>
Without the return value check, it is possible that ifname is empty due to interface not found. Signed-off-by: Shu0T1an ChenG <[email protected]>
Signed-off-by: Andriy Moroz <[email protected]>
…ic-net#501) * [crmorch]: neighbor used counter increased twice
…:PortConfigDone error (sonic-net#503)
…pe (sonic-net#504) Signed-off-by: Sihui Han <[email protected]>
Signed-off-by: Guohan Lu <[email protected]>
…c-net#482) * Add new test case for ACL - Rule Priority New test case - I created 4 rules with priorities 10, 20, 30, 40, then I added a fifth rule with priority 21. Made sure they were all programmed correctly in the DB * new acl test case: added a rule in between configured rules I configured five rules with priorities 10, 20, 30, 40, then configured another rule with priority 21. Verified that all five rules were pushed to the ASICDB * Delete test_acl.py mistakenly added this file * removing redundant code by inserting via a loop * created helper function to check proper rule config
…ch (sonic-net#506) * We have enough logging inside of the method. Remove the excessive one * Rewrite portsorch::validatespeed. Use true lazy approach to minimize SAI get operations on each port * Restore the missed attr.id * Rename validatePortSpeed to isSpeedSupported. Change logic to return true for erross also. Even we receive an error, we could move further. It's not critical
…ic-net#474) Signed-off-by: Jipan Yang <[email protected]>
…sonic-net#499) Signed-off-by: Sihui Han <[email protected]>
Signed-off-by: Sihui Han <[email protected]>
…ovided (sonic-net#509) * Suppress Cable length error in case buffer config file is not provided * fix PR feedback
…onic-net#494) * enhance acl orch to handle the LAG port not configured case * rename variable, function; redunce redundant code; fix memory issue * revise according to comments * one more blank line * add new VS test cases for acl on LAG * update with PR comments fix * rename getValidPortId and move it to portOrch * fix indent * fix test case comments
…onic-net#494) * enhance acl orch to handle the LAG port not configured case * rename variable, function; redunce redundant code; fix memory issue * revise according to comments * one more blank line * add new VS test cases for acl on LAG * update with PR comments fix * rename getValidPortId and move it to portOrch * fix indent * fix test case comments
…TABLE in orchagent processing (sonic-net#514) Signed-off-by: Jipan Yang <[email protected]>
* Add files via upload * Test case: ACL rule with diff subnet masks Added a test case with ACL rules with different mask /8 /19 ,etc. Verified the proper subnet masks were reflected in the ASICDB. * changing addition of acl rules to a loop to avoid redundancy * added a helper function to improve code efficiency * Update test_acl.py
…uration was applied (sonic-net#515) * Don't up ports, until buffer configuration is applied * Set MTU first, then set port state to UP * Introduce the test * Use logical operator && for boolean values
…t0 (sonic-net#522) Signed-off-by: Jipan Yang <[email protected]>
* Allocate buffer for 256 entries for ACL resource query * Changed to MACRO
Signed-off-by: Sihui Han <[email protected]>
Signed-off-by: Sihui Han <[email protected]>
…tialization (sonic-net#528) * Pospone QueueMap initialization until activation of counters * Initialize CounterCheckOrch after we initialized the QueueMaps
* Generate queue maps only for front panel ports
…sonic-net#530) * Pospone QueueMap initialization until activation of counters * Check that port ready list has the information before referencing the information
* Pospone QueueMap initialization until activation of counters * Generate queue maps only for front panel ports * Create empty buffer lists by default
|
any issues on our side with latest changes, particularly SAI 1.3? |
NStetskovych-zz
pushed a commit
that referenced
this pull request
Nov 20, 2018
* VNET/VRF Changes (#6) * VRF changes * Fixed an IPv6 address parsing issue * Updated logs, removed intfmgr changes in favour of PR sonic-net#635 * Updated VRF table name * Addressed review comment, test fixes * Remove extra semi-colon * Route handling, review comments (#8) * Vnet route table handling * Addressed review comments * Fix for interface routes, add debug logs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bring in changes from Azure master