[pfcwd]: create PFCWD acl instead of L3 ACL#479
Merged
sihuihan88 merged 1 commit intosonic-net:masterfrom Apr 20, 2018
Merged
Conversation
Signed-off-by: Sihui Han <[email protected]>
prsunny
reviewed
Apr 19, 2018
|
|
||
| if (type == ACL_TABLE_PFCWD) | ||
| { | ||
| attr.id = SAI_ACL_TABLE_ATTR_FIELD_TC; |
Collaborator
There was a problem hiding this comment.
Just a thought.. we can have TC and STAGE outside the if so, no need to duplicate the code below.
Contributor
Author
|
Retest this please |
prsunny
approved these changes
Apr 19, 2018
Contributor
Author
|
Retest this please |
sihuihan88
force-pushed
the
dev/sihan/pfcacl
branch
from
ffec0c2 to
118345f
Compare
sihuihan88
added a commit
to sihuihan88/sonic-swss
that referenced
this pull request
Apr 23, 2018
Signed-off-by: Sihui Han <[email protected]>
lguohan
pushed a commit
that referenced
this pull request
Apr 24, 2018
Signed-off-by: Sihui Han <[email protected]>
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
Signed-off-by: Sihui Han <[email protected]>
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
Signed-off-by: Sihui Han <[email protected]>
jianyuewu
pushed a commit
to jianyuewu/sonic-swss
that referenced
this pull request
Dec 24, 2025
* Fixed the MACRO name as per review comment. Signed-off-by: Venkatesan Mahalingam <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sihui Han [email protected]
What I did
Create a new ACL type called for PFCWD
Why I did it
L3 ACL has many qualifiers that are not needed for PFCWD. Creating L3 ACL consumes more resources than needed, which will cause issue when the ACL resources is limited.
How I verified it
Tested on DUT
Details if related