Skip to content

Check m_port_ready_list_ref value for presense before using the value#530

Merged
lguohan merged 4 commits intosonic-net:masterfrom
pavel-shirshov:pavelsh/check_hash_before_use
Jul 3, 2018
Merged

Check m_port_ready_list_ref value for presense before using the value#530
lguohan merged 4 commits intosonic-net:masterfrom
pavel-shirshov:pavelsh/check_hash_before_use

Conversation

@pavel-shirshov
Copy link
Copy Markdown
Contributor

What I did
Check that m_port_ready_list_ref item is exist before using it.

Why I did it
Otherwise it could be a race condition if portsorch receive events before we initialize bufferorch

How I verified it
Build an image and run on DUT.

Details if related

@pavel-shirshov pavel-shirshov self-assigned this Jul 2, 2018
@pavel-shirshov pavel-shirshov requested a review from lguohan July 2, 2018 19:24
@pavel-shirshov
Copy link
Copy Markdown
Contributor Author

retest this please

1 similar comment
@pavel-shirshov
Copy link
Copy Markdown
Contributor Author

retest this please

@lguohan lguohan merged commit 22bb2cd into sonic-net:master Jul 3, 2018
lguohan pushed a commit that referenced this pull request Jul 12, 2018
…#530)

* Pospone QueueMap initialization until activation of counters

* Check that port ready list has the information before referencing the information
EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this pull request Mar 1, 2023
Signed-off-by: Andriy Kokhan <akokhan@barefootnetworks.com>
Janetxxx pushed a commit to Janetxxx/sonic-swss that referenced this pull request Nov 10, 2025
…sonic-net#530)

* Pospone QueueMap initialization until activation of counters

* Check that port ready list has the information before referencing the information
jianyuewu pushed a commit to jianyuewu/sonic-swss that referenced this pull request Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants