[acl]: Insert new acl rule with priority in between other rules#482
Merged
prsunny merged 5 commits intosonic-net:masterfrom May 17, 2018
Merged
[acl]: Insert new acl rule with priority in between other rules#482prsunny merged 5 commits intosonic-net:masterfrom
prsunny merged 5 commits intosonic-net:masterfrom
Conversation
New test case - I created 4 rules with priorities 10, 20, 30, 40, then I added a fifth rule with priority 21. Made sure they were all programmed correctly in the DB
I configured five rules with priorities 10, 20, 30, 40, then configured another rule with priority 21. Verified that all five rules were pushed to the ASICDB
zhenggen-xu
suggested changes
Apr 20, 2018
Collaborator
zhenggen-xu
left a comment
zhenggen-xu
left a comment
There was a problem hiding this comment.
Why do you add a new test_acl.py file in the orchagent directory? If by accident, please remove it. Modification should be in the tests/test_acl.py only.
mistakenly added this file
Contributor
Author
|
Thanks for pointing it out. I have removed the extra file |
lguohan
requested changes
Apr 23, 2018
Contributor
lguohan
left a comment
lguohan
left a comment
There was a problem hiding this comment.
can you simplify the code logic by using for loop? for example, for the first four rules, can you use for loop to insert, the code are very similar. The validation code has similar issues.
lguohan
requested changes
May 3, 2018
Contributor
lguohan
left a comment
lguohan
left a comment
There was a problem hiding this comment.
please use the same check_rule_existence function you are going to write in your other PR.
prsunny
reviewed
May 3, 2018
tests/test_acl.py
Outdated
|
|
||
| tbl = swsscommon.Table(db, "ACL_RULE") | ||
| fvs5 = swsscommon.FieldValuePairs([("PRIORITY", "21"), ("PACKET_ACTION", "DROP"), ("ETHER_TYPE", "4660")]) | ||
| tbl.set("test_insert|acl_test_rule5", fvs5) |
Collaborator
There was a problem hiding this comment.
You could use num_rules as above for indexing instead of hard-coding to 5
tests/test_acl.py
Outdated
| (status, fvs) = atbl.get(entry) | ||
| assert status == True | ||
| assert len(fvs) == 6 | ||
| if ('SAI_ACL_ENTRY_ATTR_PRIORITY', '10') in fvs: |
Collaborator
There was a problem hiding this comment.
Kindly optimize this part as suggested by Guohan. As a general comment, suggest to use elif if you are checking the same condition against different values
lguohan
approved these changes
May 17, 2018
Contributor
Author
prsunny
approved these changes
May 17, 2018
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
…sonic-net#482) * Tool to verify ASIC route entries against APPL-DB ROUTE & INTF tables * code updated per review comments
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
…c-net#482) * Add new test case for ACL - Rule Priority New test case - I created 4 rules with priorities 10, 20, 30, 40, then I added a fifth rule with priority 21. Made sure they were all programmed correctly in the DB * new acl test case: added a rule in between configured rules I configured five rules with priorities 10, 20, 30, 40, then configured another rule with priority 21. Verified that all five rules were pushed to the ASICDB * Delete test_acl.py mistakenly added this file * removing redundant code by inserting via a loop * created helper function to check proper rule config
jianyuewu
pushed a commit
to jianyuewu/sonic-swss
that referenced
this pull request
Dec 24, 2025
MUX Metrics table will be used to collect metrics relevant to the MUX hardware. signed-off-by: Tamer Ahmed <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
I added a new acl test case: Four ACL rules are configured with priorities 10, 20, 30, 40. Then I added another rule with priority 21. I made sure all five rules were pushed to the ASICDB and with the proper priorities.
Why I did it
Part of the ACL test cases suggested by Dell and approved by Microsoft
How I verified it
Ran the python script in the repo
Details if related
Logs are attached
insert_acl_rule_logs.txt