[buffermgr]: remove the item from consumer queue if invalid#489
Merged
lguohan merged 2 commits intosonic-net:masterfrom Apr 26, 2018
Merged
[buffermgr]: remove the item from consumer queue if invalid#489lguohan merged 2 commits intosonic-net:masterfrom
lguohan merged 2 commits intosonic-net:masterfrom
Conversation
added 2 commits
April 25, 2018 21:31
Signed-off-by: Sihui Han <[email protected]>
Signed-off-by: Sihui Han <[email protected]>
lguohan
approved these changes
Apr 26, 2018
lguohan
pushed a commit
that referenced
this pull request
Apr 27, 2018
* [buffermgr]: remove the item from consumer queue if invalid Signed-off-by: Sihui Han <[email protected]> * change error to task_invalid_entry Signed-off-by: Sihui Han <[email protected]>
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
* fixed issue of permenent block on redisBufferRead() due to unprotected access from different threads syncd main thread was doing g_redisClient->hget without acquiring g_mutex, thereby causing either syncd main thread or notification thread to block indefinitely on redisBufferRead(). * Delete .DS_Store . * resolved merge conflict * Revert "resolved merge conflict" This reverts commit f0094914cb93249482ee79fc5d4db402aecf79d6. * Revert "Merge remote-tracking branch 'upstream/master'" This reverts commit 550aca906c4f0ccca0d03a95c96152e9a37abae1, reversing changes made to 676c0b58c4452478161d14a04140ed663127e91d. * Revert "Revert "Merge remote-tracking branch 'upstream/master'"" This reverts commit 03fc996e8c530505a3ad22b23e75ef2c77ebc668. * Revert "Revert "resolved merge conflict"" This reverts commit e840a6b0f4d2df1679d654796f4e303f73d98abe. * Update syncd.cpp * Update syncd.cpp * Update syncd.cpp * Update syncd.cpp
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
…t#489) * [buffermgr]: remove the item from consumer queue if invalid Signed-off-by: Sihui Han <[email protected]> * change error to task_invalid_entry Signed-off-by: Sihui Han <[email protected]>
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
…t#489) * [buffermgr]: remove the item from consumer queue if invalid Signed-off-by: Sihui Han <[email protected]> * change error to task_invalid_entry Signed-off-by: Sihui Han <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sihui Han [email protected]
What I did
Remove the item from consumer queue if invalid
Why I did it
Otherwise, it will keep trying to process the item, write errors and pollutes the syslog.
How I verified it
Tested on DUT.
Details if related