Allocate buffer for 256 entries for ACL resource query#523
Merged
prsunny merged 2 commits intosonic-net:masterfrom Jun 13, 2018
Merged
Allocate buffer for 256 entries for ACL resource query#523prsunny merged 2 commits intosonic-net:masterfrom
prsunny merged 2 commits intosonic-net:masterfrom
Conversation
jleveque
approved these changes
Jun 11, 2018
zhenggen-xu
suggested changes
Jun 12, 2018
orchagent/crmorch.cpp
Outdated
| { | ||
| attr.value.aclresource.count = 0; | ||
| attr.value.aclresource.list = NULL; | ||
| const int aclResourceCount = 256; |
Collaborator
There was a problem hiding this comment.
Can we define this number as a macro?
lguohan
approved these changes
Jun 12, 2018
zhenggen-xu
approved these changes
Jun 13, 2018
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
* Allocate buffer for 256 entries for ACL resource query * Changed to MACRO
jianyuewu
pushed a commit
to jianyuewu/sonic-swss
that referenced
this pull request
Dec 24, 2025
…nters (sonic-net#523) Introduce a new field for FLEX_COUNTER_TABLE, indicating the current state of flex counters delay. The indicator will set to 'true' when executing fast-reboot command to ensure no counters are created before enable_counters script is called.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Allocate an initial buffer instead of NULL during ACL table/group query
Why I did it
During every CRM polling interval, the following
WARNINGmessage is observed. This fix will suppress the frequent WARNINGsJun 11 20:23:07.092436 str-a7060cx-acs-1 WARNING syncd: :- processEvent: get API for key: SAI_OBJECT_TYPE_SWITCH:oid:0x21000000000000 op: get returned status: SAI_STATUS_BUFFER_OVERFLOWHow I verified it
Load the changes and verify for WARNING message.
RUN CRM test and also the following commands:
Details if related